Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
WARNING: multiple messages refer to this Message-ID
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (ina3221) Implement ti,single-shot DT property
Date: Fri, 04 Jan 2019 18:48:37 -0800
Message-ID: <20190105024823.GA20936@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190105004904.17947-1-nicoleotsuka@gmail.com>

On Fri, Jan 04, 2019 at 06:37:55PM -0800, Guenter Roeck wrote:
> > +enum ina3221_modes {
> > +   INA3221_MODE_SINGLE_SHOT,
> > +   INA3221_MODE_CONTINUOUS,
> > +   INA3221_NUM_MODES,
> 
> Is NUM_MODES used anywhere ? Please drop unless there is a reason to keep it.

Will clean it up in v2.

Thanks
Nicolin

From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (ina3221) Implement ti,single-shot DT property
Date: Fri, 4 Jan 2019 18:48:24 -0800
Message-ID: <20190105024823.GA20936@Asurada-Nvidia.nvidia.com> (raw)
Message-ID: <20190105024824.1AMZPc_0VjMgbtxwZaO2bspx-I598j1ai3qR26f77eA@z> (raw)
In-Reply-To: <c5d8771d-3274-6982-2f9f-903fd5310488@roeck-us.net>

On Fri, Jan 04, 2019 at 06:37:55PM -0800, Guenter Roeck wrote:
> > +enum ina3221_modes {
> > +	INA3221_MODE_SINGLE_SHOT,
> > +	INA3221_MODE_CONTINUOUS,
> > +	INA3221_NUM_MODES,
> 
> Is NUM_MODES used anywhere ? Please drop unless there is a reason to keep it.

Will clean it up in v2.

Thanks
Nicolin

  parent reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-05  0:50 [PATCH 0/2] hwmon (ina3221) Add single-shot mode support Nicolin Chen
2019-01-05  0:49 ` Nicolin Chen
2019-01-05  0:50 ` [PATCH 2/2] hwmon: (ina3221) Implement ti,single-shot DT property Nicolin Chen
2019-01-05  0:49   ` Nicolin Chen
2019-01-05  0:50 ` [PATCH 1/2] dt-bindings: hwmon: ina3221: Add ti,single-shot property Nicolin Chen
2019-01-05  0:49   ` Nicolin Chen
2019-01-11 21:31   ` Rob Herring
2019-01-05  2:38 ` [PATCH 2/2] hwmon: (ina3221) Implement ti,single-shot DT property Guenter Roeck
2019-01-05  2:37   ` Guenter Roeck
2019-01-05  2:48 ` Nicolin Chen [this message]
2019-01-05  2:48   ` Nicolin Chen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190105024823.GA20936@Asurada-Nvidia.nvidia.com \
    --to=nicoleotsuka@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox