From: Guenter Roeck <linux@roeck-us.net>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com
Subject: Re: [PATCH] dt-bindings: hwmon: Add lm75 documentation
Date: Thu, 31 Jan 2019 10:06:19 -0800 [thread overview]
Message-ID: <20190131180619.GA17074@roeck-us.net> (raw)
In-Reply-To: <20190129065623.6771-1-jagan@amarulasolutions.com>
On Tue, Jan 29, 2019 at 12:26:23PM +0530, Jagan Teki wrote:
> Add dt-binding documentation for lm75 hwmon sensor.
>
> Currently documented for national,lm75 and st,stlm75 and
> rest might add when required.
Why ? The various properties are already implemented in the driver.
I don't see the value documenting only two of them.
I do see though that nxp,lm75, and nxp,lm75a are used but _not_
referenced in the driver.
If we start cleaning that up I think it would make more sense
to clean up everything, not just part of it.
Thanks,
Guenter
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Documentation/devicetree/bindings/hwmon/lm75.txt | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> new file mode 100644
> index 000000000000..e384a3765f10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> @@ -0,0 +1,15 @@
> +*LM75 hwmon sensor.
> +
> +Required properties:
> +- compatible: one of
> + "national,lm75"
> + "st,stlm75"
> +
> +- reg: I2C address
> +
> +Example:
> +
> +sensor@48 {
> + compatible = "st,stlm75";
> + reg = <0x48>;
> +};
prev parent reply other threads:[~2019-01-31 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 6:56 [PATCH] dt-bindings: hwmon: Add lm75 documentation Jagan Teki
2019-01-31 18:06 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131180619.GA17074@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=jdelvare@suse.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).