Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
* [RFC PATCH hwmon] hwmon: max6650_pwm_modes[] can be static
  2019-04-24  7:36 [hwmon:hwmon-playground 130/134] drivers/hwmon/max6650.c:602:10: sparse: symbol 'max6650_pwm_modes' was not declared. Should it be static? kbuild test robot
@ 2019-04-24  7:36 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-04-24  7:36 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: kbuild-all, linux-hwmon


Fixes: 77d270a1d4db ("hwmon: (max6650) Convert to use devm_hwmon_device_register_with_info")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 max6650.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
index 3011841..6364bc9 100644
--- a/drivers/hwmon/max6650.c
+++ b/drivers/hwmon/max6650.c
@@ -599,7 +599,7 @@ static int max6650_read(struct device *dev, enum hwmon_sensor_types type,
 	return 0;
 }
 
-const u8 max6650_pwm_modes[] = {
+static const u8 max6650_pwm_modes[] = {
 	MAX6650_CFG_MODE_ON,
 	MAX6650_CFG_MODE_OPEN_LOOP,
 	MAX6650_CFG_MODE_CLOSED_LOOP,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [hwmon:hwmon-playground 130/134] drivers/hwmon/max6650.c:602:10: sparse: symbol 'max6650_pwm_modes' was not declared. Should it be static?
@ 2019-04-24  7:36 kbuild test robot
  2019-04-24  7:36 ` [RFC PATCH hwmon] hwmon: max6650_pwm_modes[] can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-04-24  7:36 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: kbuild-all, linux-hwmon

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-playground
head:   05d763050bbaa40daa4b60a3912c9311ca5791a5
commit: 77d270a1d4db919db0b02fec1d85ad5a57d556d7 [130/134] hwmon: (max6650) Convert to use devm_hwmon_device_register_with_info
reproduce:
        # apt-get install sparse
        git checkout 77d270a1d4db919db0b02fec1d85ad5a57d556d7
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>



sparse warnings: (new ones prefixed by >>)

   drivers/hwmon/max6650.c:160:16: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:160:16: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:160:16: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:160:16: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:160:16: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:160:16: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:160:16: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:280:15: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:280:15: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:280:15: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:280:15: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:280:15: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:280:15: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:280:15: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:490:17: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:490:17: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:490:17: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:490:17: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:490:17: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:490:17: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:490:17: sparse: expression using sizeof(void)
>> drivers/hwmon/max6650.c:602:10: sparse: symbol 'max6650_pwm_modes' was not declared. Should it be static?
   drivers/hwmon/max6650.c:622:42: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:622:42: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:622:42: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:622:42: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:622:42: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:622:42: sparse: expression using sizeof(void)
   drivers/hwmon/max6650.c:622:42: sparse: expression using sizeof(void)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24  7:36 [hwmon:hwmon-playground 130/134] drivers/hwmon/max6650.c:602:10: sparse: symbol 'max6650_pwm_modes' was not declared. Should it be static? kbuild test robot
2019-04-24  7:36 ` [RFC PATCH hwmon] hwmon: max6650_pwm_modes[] can be static kbuild test robot

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org linux-hwmon@archiver.kernel.org
	public-inbox-index linux-hwmon


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/ public-inbox