From: Guenter Roeck <linux@roeck-us.net>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: ina3221.c: Add of_node_put() before return
Date: Mon, 8 Jul 2019 11:16:34 -0700 [thread overview]
Message-ID: <20190708181633.GA15102@roeck-us.net> (raw)
In-Reply-To: <20190706132130.3129-1-nishkadg.linux@gmail.com>
On Sat, Jul 06, 2019 at 06:51:30PM +0530, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous
> node, but in the case of a return from the middle of the loop, there is
> no put, thus causing a memory leak. Hence add an of_node_put before the
> return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Applied. For future patches, please don't put source file extensions
into the subject line.
Thanks,
Guenter
> ---
> drivers/hwmon/ina3221.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
> index 55943b4dcc7b..0037e2bdacd6 100644
> --- a/drivers/hwmon/ina3221.c
> +++ b/drivers/hwmon/ina3221.c
> @@ -713,8 +713,10 @@ static int ina3221_probe_from_dt(struct device *dev, struct ina3221_data *ina)
>
> for_each_child_of_node(np, child) {
> ret = ina3221_probe_child_from_dt(dev, child, ina);
> - if (ret)
> + if (ret) {
> + of_node_put(child);
> return ret;
> + }
> }
>
> return 0;
next prev parent reply other threads:[~2019-07-08 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 13:21 [PATCH] hwmon: ina3221.c: Add of_node_put() before return Nishka Dasgupta
2019-07-08 18:16 ` Guenter Roeck [this message]
2019-07-11 6:29 ` Nishka Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708181633.GA15102@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).