* [PATCH v2 10/11] hwmon: (scmi-hwmon) Match scmi device by both name and protocol id
[not found] <20191218111742.29731-1-sudeep.holla@arm.com>
@ 2019-12-18 11:17 ` Sudeep Holla
2020-01-04 16:19 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Sudeep Holla @ 2019-12-18 11:17 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: Sudeep Holla, Cristian Marussi, Guenter Roeck, linux-hwmon
The scmi bus now has support to match the driver with devices not only
based on their protocol id but also based on their device name if one is
available. This was added to cater the need to support multiple devices
and drivers for the same protocol.
Let us add the name "hwmon" to scmi_device_id table in the driver so
that in matches only with device with the same name and protocol id
SCMI_PROTOCOL_SENSOR. This is just for sake of completion and must
not be used to add IIO support in parallel. Instead, if IIO support is
added ever in future, we need to drop this hwmon driver entirely and
use the iio->hwmon bridge to access the sensors as hwmon devices if
needed.
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/hwmon/scmi-hwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
index 8a7732c0bef3..286d3cfda7de 100644
--- a/drivers/hwmon/scmi-hwmon.c
+++ b/drivers/hwmon/scmi-hwmon.c
@@ -259,7 +259,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
}
static const struct scmi_device_id scmi_id_table[] = {
- { SCMI_PROTOCOL_SENSOR },
+ { SCMI_PROTOCOL_SENSOR, "hwmon" },
{ },
};
MODULE_DEVICE_TABLE(scmi, scmi_id_table);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 10/11] hwmon: (scmi-hwmon) Match scmi device by both name and protocol id
2019-12-18 11:17 ` [PATCH v2 10/11] hwmon: (scmi-hwmon) Match scmi device by both name and protocol id Sudeep Holla
@ 2020-01-04 16:19 ` Guenter Roeck
2020-01-06 10:39 ` Sudeep Holla
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2020-01-04 16:19 UTC (permalink / raw)
To: Sudeep Holla
Cc: linux-arm-kernel, linux-kernel, Cristian Marussi, linux-hwmon
On Wed, Dec 18, 2019 at 11:17:41AM +0000, Sudeep Holla wrote:
> The scmi bus now has support to match the driver with devices not only
> based on their protocol id but also based on their device name if one is
> available. This was added to cater the need to support multiple devices
> and drivers for the same protocol.
>
> Let us add the name "hwmon" to scmi_device_id table in the driver so
> that in matches only with device with the same name and protocol id
> SCMI_PROTOCOL_SENSOR. This is just for sake of completion and must
> not be used to add IIO support in parallel. Instead, if IIO support is
> added ever in future, we need to drop this hwmon driver entirely and
> use the iio->hwmon bridge to access the sensors as hwmon devices if
> needed.
>
Acked-by: Guenter Roeck <linux@roeck-us.net>
[ assuming the series will be pushed into the kernel together ]
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-hwmon@vger.kernel.org
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/hwmon/scmi-hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> index 8a7732c0bef3..286d3cfda7de 100644
> --- a/drivers/hwmon/scmi-hwmon.c
> +++ b/drivers/hwmon/scmi-hwmon.c
> @@ -259,7 +259,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
> }
>
> static const struct scmi_device_id scmi_id_table[] = {
> - { SCMI_PROTOCOL_SENSOR },
> + { SCMI_PROTOCOL_SENSOR, "hwmon" },
> { },
> };
> MODULE_DEVICE_TABLE(scmi, scmi_id_table);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 10/11] hwmon: (scmi-hwmon) Match scmi device by both name and protocol id
2020-01-04 16:19 ` Guenter Roeck
@ 2020-01-06 10:39 ` Sudeep Holla
0 siblings, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2020-01-06 10:39 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-arm-kernel, linux-kernel, Cristian Marussi, linux-hwmon,
Sudeep Holla
On Sat, Jan 04, 2020 at 08:19:46AM -0800, Guenter Roeck wrote:
> On Wed, Dec 18, 2019 at 11:17:41AM +0000, Sudeep Holla wrote:
> > The scmi bus now has support to match the driver with devices not only
> > based on their protocol id but also based on their device name if one is
> > available. This was added to cater the need to support multiple devices
> > and drivers for the same protocol.
> >
> > Let us add the name "hwmon" to scmi_device_id table in the driver so
> > that in matches only with device with the same name and protocol id
> > SCMI_PROTOCOL_SENSOR. This is just for sake of completion and must
> > not be used to add IIO support in parallel. Instead, if IIO support is
> > added ever in future, we need to drop this hwmon driver entirely and
> > use the iio->hwmon bridge to access the sensors as hwmon devices if
> > needed.
> >
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
>
Thanks
> [ assuming the series will be pushed into the kernel together ]
>
Indeed.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-06 10:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191218111742.29731-1-sudeep.holla@arm.com>
2019-12-18 11:17 ` [PATCH v2 10/11] hwmon: (scmi-hwmon) Match scmi device by both name and protocol id Sudeep Holla
2020-01-04 16:19 ` Guenter Roeck
2020-01-06 10:39 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).