From: Guenter Roeck <linux@roeck-us.net>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com,
logan.shaw@alliedtelesis.co.nz, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/5] dt-bindings: hwmon: Document adt7475 bypass-attenuator property
Date: Tue, 3 Mar 2020 13:00:58 -0800 [thread overview]
Message-ID: <20200303210058.GB14692@roeck-us.net> (raw)
In-Reply-To: <20200227084642.7057-3-chris.packham@alliedtelesis.co.nz>
On Thu, Feb 27, 2020 at 09:46:39PM +1300, Chris Packham wrote:
> From: Logan Shaw <logan.shaw@alliedtelesis.co.nz>
>
> Add documentation for the bypass-attenuator-in[0-4] property.
>
> Signed-off-by: Logan Shaw <logan.shaw@alliedtelesis.co.nz>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied.
Thanks,
Guenter
> ---
>
> Notes:
> Changes in v5:
> - add review from Rob
>
> Changes in v4:
> - use $ref uint32 and enum
> - add 'adi' vendor prefix
>
> Changes in v3:
> - separated addition of new properties from conversion to yaml
>
> .../devicetree/bindings/hwmon/adt7475.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.yaml b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> index 2252499ea201..e40612ee075f 100644
> --- a/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> @@ -39,6 +39,17 @@ properties:
> reg:
> maxItems: 1
>
> +patternProperties:
> + "^adi,bypass-attenuator-in[0-4]$":
> + description: |
> + Configures bypassing the individual voltage input attenuator. If
> + set to 1 the attenuator is bypassed if set to 0 the attenuator is
> + not bypassed. If the property is absent then the attenuator
> + retains it's configuration from the bios/bootloader.
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - enum: [0, 1]
> +
> required:
> - compatible
> - reg
> @@ -52,6 +63,8 @@ examples:
> hwmon@2e {
> compatible = "adi,adt7476";
> reg = <0x2e>;
> + adi,bypass-attenuator-in0 = <1>;
> + adi,bypass-attenuator-in1 = <0>;
> };
> };
>
next prev parent reply other threads:[~2020-03-03 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 8:46 [PATCH v5 0/5] hwmon: (adt7475) attenuator bypass and pwm invert Chris Packham
2020-02-27 8:46 ` [PATCH v5 1/5] dt-bindings: hwmon: Document adt7475 binding Chris Packham
2020-03-03 21:00 ` Guenter Roeck
2020-02-27 8:46 ` [PATCH v5 2/5] dt-bindings: hwmon: Document adt7475 bypass-attenuator property Chris Packham
2020-03-03 21:00 ` Guenter Roeck [this message]
2020-02-27 8:46 ` [PATCH v5 3/5] dt-bindings: hwmon: Document adt7475 pwm-active-state property Chris Packham
2020-03-03 1:25 ` Rob Herring
2020-03-03 21:01 ` Guenter Roeck
2020-02-27 8:46 ` [PATCH v5 4/5] hwmon: (adt7475) Add attenuator bypass support Chris Packham
2020-03-03 21:05 ` Guenter Roeck
2020-02-27 8:46 ` [PATCH v5 5/5] hwmon: (adt7475) Add support for inverting pwm output Chris Packham
2020-03-03 21:08 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303210058.GB14692@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logan.shaw@alliedtelesis.co.nz \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).