* [PATCH v8 03/12] hwmon: pwm-fan: Use 64-bit division macro [not found] <cover.1583889178.git.gurus@codeaurora.org> @ 2020-03-11 1:41 ` Guru Das Srinagesh 2020-03-11 15:08 ` Guenter Roeck 0 siblings, 1 reply; 2+ messages in thread From: Guru Das Srinagesh @ 2020-03-11 1:41 UTC (permalink / raw) To: linux-pwm Cc: Thierry Reding, Uwe Kleine-König, Subbaraman Narayanamurthy, linux-kernel, Guru Das Srinagesh, Kamil Debski, Bartlomiej Zolnierkiewicz, Jean Delvare, Guenter Roeck, Liam Girdwood, Mark Brown, linux-hwmon Since the PWM framework is switching struct pwm_args.period's datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL to handle a 64-bit dividend. Cc: Kamil Debski <kamil@wypas.org> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Jean Delvare <jdelvare@suse.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: linux-hwmon@vger.kernel.org Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org> --- drivers/hwmon/pwm-fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index 42ffd2e..283423a 100644 --- a/drivers/hwmon/pwm-fan.c +++ b/drivers/hwmon/pwm-fan.c @@ -437,7 +437,7 @@ static int pwm_fan_resume(struct device *dev) return 0; pwm_get_args(ctx->pwm, &pargs); - duty = DIV_ROUND_UP(ctx->pwm_value * (pargs.period - 1), MAX_PWM); + duty = DIV_ROUND_UP_ULL(ctx->pwm_value * (pargs.period - 1), MAX_PWM); ret = pwm_config(ctx->pwm, duty, pargs.period); if (ret) return ret; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v8 03/12] hwmon: pwm-fan: Use 64-bit division macro 2020-03-11 1:41 ` [PATCH v8 03/12] hwmon: pwm-fan: Use 64-bit division macro Guru Das Srinagesh @ 2020-03-11 15:08 ` Guenter Roeck 0 siblings, 0 replies; 2+ messages in thread From: Guenter Roeck @ 2020-03-11 15:08 UTC (permalink / raw) To: Guru Das Srinagesh Cc: linux-pwm, Thierry Reding, Uwe Kleine-König, Subbaraman Narayanamurthy, linux-kernel, Kamil Debski, Bartlomiej Zolnierkiewicz, Jean Delvare, Liam Girdwood, Mark Brown, linux-hwmon On Tue, Mar 10, 2020 at 06:41:12PM -0700, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_args.period's datatype > to u64, prepare for this transition by using DIV_ROUND_UP_ULL to handle > a 64-bit dividend. > > Cc: Kamil Debski <kamil@wypas.org> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: linux-hwmon@vger.kernel.org > > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org> Not sure if I entirely buy the use case, but then the performance impact is minimal, at least for this driver, so Acked-by: Guenter Roeck <linux@roeck-us.net> Guenter > --- > drivers/hwmon/pwm-fan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c > index 42ffd2e..283423a 100644 > --- a/drivers/hwmon/pwm-fan.c > +++ b/drivers/hwmon/pwm-fan.c > @@ -437,7 +437,7 @@ static int pwm_fan_resume(struct device *dev) > return 0; > > pwm_get_args(ctx->pwm, &pargs); > - duty = DIV_ROUND_UP(ctx->pwm_value * (pargs.period - 1), MAX_PWM); > + duty = DIV_ROUND_UP_ULL(ctx->pwm_value * (pargs.period - 1), MAX_PWM); > ret = pwm_config(ctx->pwm, duty, pargs.period); > if (ret) > return ret; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-11 15:08 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <cover.1583889178.git.gurus@codeaurora.org> 2020-03-11 1:41 ` [PATCH v8 03/12] hwmon: pwm-fan: Use 64-bit division macro Guru Das Srinagesh 2020-03-11 15:08 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).