Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
* [RESUBMIT PATCH 1/1] hwmon: (tmp513) Fix build issue by selecting CONFIG_REGMAP_I2C
@ 2020-03-23 14:50 Mike Pagano
  2020-03-23 16:32 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Pagano @ 2020-03-23 14:50 UTC (permalink / raw)
  To: linux-hwmon; +Cc: etremblay

Thanks for the review, Guenter.
---

This driver requires REGMAP_I2C to build.  Select it by default in Kconfig. 
Reported at gentoo bugzilla: https://bugs.gentoo.org/710790

Reported-by: Phil Stracchino <phils@caerllewys.net>
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 47ac20aee06f..530b4f29ba85 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1769,6 +1769,7 @@ config SENSORS_TMP421
 config SENSORS_TMP513
  tristate "Texas Instruments TMP513 and compatibles"
  depends on I2C
+ select REGMAP_I2C
  help
    If you say yes here you get support for Texas Instruments TMP512,
    and TMP513 temperature and power supply sensor chips.
-- 
2.24.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RESUBMIT PATCH 1/1] hwmon: (tmp513) Fix build issue by selecting CONFIG_REGMAP_I2C
  2020-03-23 14:50 [RESUBMIT PATCH 1/1] hwmon: (tmp513) Fix build issue by selecting CONFIG_REGMAP_I2C Mike Pagano
@ 2020-03-23 16:32 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-03-23 16:32 UTC (permalink / raw)
  To: Mike Pagano; +Cc: linux-hwmon, etremblay

On Mon, Mar 23, 2020 at 10:50:18AM -0400, Mike Pagano wrote:
> Thanks for the review, Guenter.
> ---

Please have a look into Documentation/process/submitting-patches.rst.

This is not a resubmit, and above comments should come after ---,
not before it. On top of that, it is corrupted (tabs replaced with
spaces).

Guenter

> 
> This driver requires REGMAP_I2C to build.  Select it by default in Kconfig. 
> Reported at gentoo bugzilla: https://bugs.gentoo.org/710790
> 
> Reported-by: Phil Stracchino <phils@caerllewys.net>
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
>  drivers/hwmon/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 47ac20aee06f..530b4f29ba85 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1769,6 +1769,7 @@ config SENSORS_TMP421
>  config SENSORS_TMP513
>   tristate "Texas Instruments TMP513 and compatibles"
>   depends on I2C
> + select REGMAP_I2C
>   help
>     If you say yes here you get support for Texas Instruments TMP512,
>     and TMP513 temperature and power supply sensor chips.
> -- 
> 2.24.1
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 14:50 [RESUBMIT PATCH 1/1] hwmon: (tmp513) Fix build issue by selecting CONFIG_REGMAP_I2C Mike Pagano
2020-03-23 16:32 ` Guenter Roeck

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git