Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h
       [not found] <20200607043709.48178-1-hengqing.hu@gmail.com>
@ 2020-06-15 11:59 ` Borislav Petkov
  2020-06-15 15:01   ` Guenter Roeck
  2020-06-16 14:11   ` Yazen Ghannam
  0 siblings, 2 replies; 6+ messages in thread
From: Borislav Petkov @ 2020-06-15 11:59 UTC (permalink / raw)
  To: Jacky Hu
  Cc: linux-edac, linux-kernel, tony.luck, x86, Yazen Ghannam, linux-hwmon

+ Yazen and linux-hwmon.

On Sun, Jun 07, 2020 at 12:37:07PM +0800, Jacky Hu wrote:
> This patchset adds MCA and EDAC support for AMD Family 17h, Model 60h.
> 
> Also k10temp works with 4800h
> 
> k10temp-pci-00c3
> Adapter: PCI adapter
> Vcore:         1.55 V
> Vsoc:          1.55 V
> Tctl:         +49.6°C
> Tdie:         +49.6°C
> Icore:         0.00 A
> Isoc:          0.00 A
> 
> Jacky Hu (2):
>   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
>   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
> 
>  arch/x86/kernel/amd_nb.c  |  5 +++++
>  drivers/edac/amd64_edac.c | 14 ++++++++++++++
>  drivers/edac/amd64_edac.h |  3 +++
>  drivers/hwmon/k10temp.c   |  2 ++
>  include/linux/pci_ids.h   |  1 +
>  5 files changed, 25 insertions(+)
> 
> -- 
> 2.27.0
> 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h
  2020-06-15 11:59 ` [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Borislav Petkov
@ 2020-06-15 15:01   ` Guenter Roeck
  2020-06-16 14:35     ` Borislav Petkov
  2020-06-16 14:11   ` Yazen Ghannam
  1 sibling, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2020-06-15 15:01 UTC (permalink / raw)
  To: Borislav Petkov, Jacky Hu
  Cc: linux-edac, linux-kernel, tony.luck, x86, Yazen Ghannam, linux-hwmon

On 6/15/20 4:59 AM, Borislav Petkov wrote:
> + Yazen and linux-hwmon.
> 
> On Sun, Jun 07, 2020 at 12:37:07PM +0800, Jacky Hu wrote:
>> This patchset adds MCA and EDAC support for AMD Family 17h, Model 60h.
>>
>> Also k10temp works with 4800h
>>
>> k10temp-pci-00c3
>> Adapter: PCI adapter
>> Vcore:         1.55 V
>> Vsoc:          1.55 V
>> Tctl:         +49.6°C
>> Tdie:         +49.6°C
>> Icore:         0.00 A
>> Isoc:          0.00 A
>>

Looks like we may have to black-list current measurements
for that chip, though.

Guenter

>> Jacky Hu (2):
>>   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
>>   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
>>
>>  arch/x86/kernel/amd_nb.c  |  5 +++++
>>  drivers/edac/amd64_edac.c | 14 ++++++++++++++
>>  drivers/edac/amd64_edac.h |  3 +++
>>  drivers/hwmon/k10temp.c   |  2 ++
>>  include/linux/pci_ids.h   |  1 +
>>  5 files changed, 25 insertions(+)
>>
>> -- 
>> 2.27.0
>>
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h
  2020-06-15 11:59 ` [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Borislav Petkov
  2020-06-15 15:01   ` Guenter Roeck
@ 2020-06-16 14:11   ` Yazen Ghannam
  1 sibling, 0 replies; 6+ messages in thread
From: Yazen Ghannam @ 2020-06-16 14:11 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: Jacky Hu, linux-edac, linux-kernel, tony.luck, x86, linux-hwmon

On Mon, Jun 15, 2020 at 07:59:50AM -0400, Borislav Petkov wrote:
> + Yazen and linux-hwmon.
> 
> On Sun, Jun 07, 2020 at 12:37:07PM +0800, Jacky Hu wrote:
> > This patchset adds MCA and EDAC support for AMD Family 17h, Model 60h.
> > 
> > Also k10temp works with 4800h
> > 
> > k10temp-pci-00c3
> > Adapter: PCI adapter
> > Vcore:         1.55 V
> > Vsoc:          1.55 V
> > Tctl:         +49.6°C
> > Tdie:         +49.6°C
> > Icore:         0.00 A
> > Isoc:          0.00 A
> > 
> > Jacky Hu (2):
> >   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
> >   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
> > 
> >  arch/x86/kernel/amd_nb.c  |  5 +++++
> >  drivers/edac/amd64_edac.c | 14 ++++++++++++++
> >  drivers/edac/amd64_edac.h |  3 +++
> >  drivers/hwmon/k10temp.c   |  2 ++
> >  include/linux/pci_ids.h   |  1 +
> >  5 files changed, 25 insertions(+)
> >

PCI IDs and EDAC look good to me.

Acked-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h
  2020-06-15 15:01   ` Guenter Roeck
@ 2020-06-16 14:35     ` Borislav Petkov
  2020-06-16 14:46       ` Guenter Roeck
  0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2020-06-16 14:35 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Jacky Hu, linux-edac, linux-kernel, tony.luck, x86,
	Yazen Ghannam, linux-hwmon

On Mon, Jun 15, 2020 at 08:01:22AM -0700, Guenter Roeck wrote:
> Looks like we may have to black-list current measurements
> for that chip, though.
> 
> Guenter
> 
> >> Jacky Hu (2):
> >>   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
> >>   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
> >>
> >>  arch/x86/kernel/amd_nb.c  |  5 +++++
> >>  drivers/edac/amd64_edac.c | 14 ++++++++++++++
> >>  drivers/edac/amd64_edac.h |  3 +++
> >>  drivers/hwmon/k10temp.c   |  2 ++

... meaning I should not take the k10temp changes yet? I can drop them
and take the rest...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h
  2020-06-16 14:35     ` Borislav Petkov
@ 2020-06-16 14:46       ` Guenter Roeck
  2020-06-16 14:55         ` Borislav Petkov
  0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2020-06-16 14:46 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: Jacky Hu, linux-edac, linux-kernel, tony.luck, x86,
	Yazen Ghannam, linux-hwmon

On 6/16/20 7:35 AM, Borislav Petkov wrote:
> On Mon, Jun 15, 2020 at 08:01:22AM -0700, Guenter Roeck wrote:
>> Looks like we may have to black-list current measurements
>> for that chip, though.
>>
>> Guenter
>>
>>>> Jacky Hu (2):
>>>>   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
>>>>   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
>>>>
>>>>  arch/x86/kernel/amd_nb.c  |  5 +++++
>>>>  drivers/edac/amd64_edac.c | 14 ++++++++++++++
>>>>  drivers/edac/amd64_edac.h |  3 +++
>>>>  drivers/hwmon/k10temp.c   |  2 ++
> 
> ... meaning I should not take the k10temp changes yet? I can drop them
> and take the rest...
> 

No, that is independent. It is more like a note to myself. I'll have to get
debug dumps from someone with affected chip(s), and for that to work
support for those chips has to be enabled in k10temp.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h
  2020-06-16 14:46       ` Guenter Roeck
@ 2020-06-16 14:55         ` Borislav Petkov
  0 siblings, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2020-06-16 14:55 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Jacky Hu, linux-edac, linux-kernel, tony.luck, x86,
	Yazen Ghannam, linux-hwmon

On Tue, Jun 16, 2020 at 07:46:36AM -0700, Guenter Roeck wrote:
> No, that is independent. It is more like a note to myself. I'll have to get
> debug dumps from someone with affected chip(s), and for that to work
> support for those chips has to be enabled in k10temp.

Ok, then, will take those patches as is.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200607043709.48178-1-hengqing.hu@gmail.com>
2020-06-15 11:59 ` [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Borislav Petkov
2020-06-15 15:01   ` Guenter Roeck
2020-06-16 14:35     ` Borislav Petkov
2020-06-16 14:46       ` Guenter Roeck
2020-06-16 14:55         ` Borislav Petkov
2020-06-16 14:11   ` Yazen Ghannam

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git