From: kernel test robot <lkp@intel.com>
To: Troy Lee <troy_lee@aspeedtech.com>,
openbmc@lists.ozlabs.org, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
Jonathan Corbet <corbet@lwn.net>,
Philipp Zabel <p.zabel@pengutronix.de>,
Ryan Chen <ryan_chen@aspeedtech.com>,
"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer
Date: Wed, 13 Jan 2021 17:46:33 +0800 [thread overview]
Message-ID: <202101131741.tGzZZxXq-lkp@intel.com> (raw)
In-Reply-To: <20210113070850.1184506-5-troy_lee@aspeedtech.com>
[-- Attachment #1: Type: text/plain, Size: 4161 bytes --]
Hi Troy,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on joel-aspeed/for-next v5.11-rc3 next-20210113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Troy-Lee/hwmon-aspeed2600-pwm-tacho-Add-driver-support/20210113-151325
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: riscv-randconfig-r023-20210113 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 68ff52ffead2ba25cca442778ab19286000daad7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/19a51124badf28349d26657b611da77d5dfba2f1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Troy-Lee/hwmon-aspeed2600-pwm-tacho-Add-driver-support/20210113-151325
git checkout 19a51124badf28349d26657b611da77d5dfba2f1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/hwmon/aspeed2600-pwm-tacho.c:581:5: warning: no previous prototype for function 'aspeed_pwm_tacho_read' [-Wmissing-prototypes]
int aspeed_pwm_tacho_read(struct device *dev, enum hwmon_sensor_types type,
^
drivers/hwmon/aspeed2600-pwm-tacho.c:581:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int aspeed_pwm_tacho_read(struct device *dev, enum hwmon_sensor_types type,
^
static
>> drivers/hwmon/aspeed2600-pwm-tacho.c:615:5: warning: no previous prototype for function 'aspeed_pwm_tacho_write' [-Wmissing-prototypes]
int aspeed_pwm_tacho_write(struct device *dev, enum hwmon_sensor_types type,
^
drivers/hwmon/aspeed2600-pwm-tacho.c:615:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int aspeed_pwm_tacho_write(struct device *dev, enum hwmon_sensor_types type,
^
static
2 warnings generated.
vim +/aspeed_pwm_tacho_read +581 drivers/hwmon/aspeed2600-pwm-tacho.c
580
> 581 int aspeed_pwm_tacho_read(struct device *dev, enum hwmon_sensor_types type,
582 u32 attr, int channel, long *val)
583 {
584 struct aspeed_pwm_tachometer_data *priv = dev_get_drvdata(dev);
585 long rpm;
586
587 switch (type) {
588 case hwmon_pwm:
589 switch (attr) {
590 case hwmon_pwm_input:
591 *val = priv->pwm_channel[channel].falling;
592 break;
593 default:
594 return -EOPNOTSUPP;
595 }
596 break;
597 case hwmon_fan:
598 switch (attr) {
599 case hwmon_fan_input:
600 rpm = aspeed_get_fan_tach_ch_rpm(dev, priv, channel);
601 if (rpm < 0)
602 return rpm;
603 *val = rpm;
604 break;
605 default:
606 return -EOPNOTSUPP;
607 }
608 break;
609 default:
610 return -EOPNOTSUPP;
611 }
612 return 0;
613 }
614
> 615 int aspeed_pwm_tacho_write(struct device *dev, enum hwmon_sensor_types type,
616 u32 attr, int channel, long val)
617 {
618 switch (type) {
619 case hwmon_pwm:
620 switch (attr) {
621 case hwmon_pwm_input:
622 return set_pwm(dev, channel, val);
623 default:
624 return -EOPNOTSUPP;
625 }
626 break;
627 default:
628 return -EOPNOTSUPP;
629 }
630 return -EOPNOTSUPP;
631 }
632
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 22597 bytes --]
next prev parent reply other threads:[~2021-01-13 9:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 7:08 [PATCH v2 0/4] hwmon: aspeed2600-pwm-tacho: Add driver support Troy Lee
2021-01-13 7:08 ` [PATCH v2 1/4] dt-bindings: hwmon: Add Aspeed AST2600 PWM/Fan Troy Lee
2021-01-13 15:45 ` Rob Herring
2021-01-14 1:35 ` Troy Lee
2021-01-14 14:13 ` Rob Herring
2021-01-15 1:46 ` Troy Lee
2021-01-13 7:08 ` [PATCH v2 2/4] hwmon: Add Aspeed AST2600 support Troy Lee
2021-01-13 7:08 ` [PATCH v2 3/4] ARM: dts: aspeed: Add Aspeed AST2600 PWM/Fan node in devicetree Troy Lee
2021-01-13 7:08 ` [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer Troy Lee
2021-01-13 9:46 ` kernel test robot [this message]
2021-01-13 9:48 ` kernel test robot
2021-01-14 1:27 ` Troy Lee
2021-01-23 16:14 ` Guenter Roeck
2021-01-25 10:01 ` Troy Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101131741.tGzZZxXq-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@aj.id.au \
--cc=clang-built-linux@googlegroups.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=kbuild-all@lists.01.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).