From: Guenter Roeck <linux@roeck-us.net>
To: W_Armin@gmx.de
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (w83627ehf) Make DEVICE_ATTR_RO static
Date: Sat, 24 Jul 2021 20:21:07 -0700 [thread overview]
Message-ID: <20210725032107.GA2294115@roeck-us.net> (raw)
In-Reply-To: <20210724154817.18796-1-W_Armin@gmx.de>
On Sat, Jul 24, 2021 at 05:48:17PM +0200, W_Armin@gmx.de wrote:
> From: Armin Wolf <W_Armin@gmx.de>
>
> Make DEVICE_ATTR_RO static to fix sparse warning:
> warning: symbol 'dev_attr_cpu0_vid' was not declared. Should it be static?
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/w83627ehf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.20.1
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 3cea66c58c25..705a59663d42 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1081,7 +1081,7 @@ cpu0_vid_show(struct device *dev, struct device_attribute *attr, char *buf)
> struct w83627ehf_data *data = dev_get_drvdata(dev);
> return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
> }
> -DEVICE_ATTR_RO(cpu0_vid);
> +static DEVICE_ATTR_RO(cpu0_vid);
>
>
> /* Case open detection */
prev parent reply other threads:[~2021-07-25 3:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 15:48 [PATCH] hwmon: (w83627ehf) Make DEVICE_ATTR_RO static W_Armin
2021-07-25 3:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210725032107.GA2294115@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).