From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Jiri Kosina <trivial@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices
Date: Thu, 23 Sep 2021 18:51:09 -0700 [thread overview]
Message-ID: <20210924015109.GA3029984@roeck-us.net> (raw)
In-Reply-To: <20210920182114.339419-1-krzysztof.kozlowski@canonical.com>
On Mon, Sep 20, 2021 at 08:21:09PM +0200, Krzysztof Kozlowski wrote:
> The lm70 thermometer bindings are trivial, so like many other I2C/SPI
> temperature sensors can be integrated into trivial devices bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied, per Rob's comment that he prefers devices as .yaml
over .txt, and would rather have a transition from device.txt ->
trivial.yaml -> device.yaml than no transition at all.
Guenter
> ---
> .../devicetree/bindings/hwmon/lm70.txt | 22 -------------------
> .../devicetree/bindings/trivial-devices.yaml | 8 +++++++
> 2 files changed, 8 insertions(+), 22 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/hwmon/lm70.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/lm70.txt b/Documentation/devicetree/bindings/hwmon/lm70.txt
> deleted file mode 100644
> index ea417a0d32af..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/lm70.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -* LM70/TMP121/LM71/LM74 thermometer.
> -
> -Required properties:
> -- compatible: one of
> - "ti,lm70"
> - "ti,tmp121"
> - "ti,tmp122"
> - "ti,lm71"
> - "ti,lm74"
> -
> -See Documentation/devicetree/bindings/spi/spi-bus.txt for more required and
> -optional properties.
> -
> -Example:
> -
> -spi_master {
> - temperature-sensor@0 {
> - compatible = "ti,lm70";
> - reg = <0>;
> - spi-max-frequency = <1000000>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 1eb4ce7dcdfd..183ee0da22c6 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -303,8 +303,13 @@ properties:
> - ti,hdc1050
> # Temperature and humidity sensor with i2c interface
> - ti,hdc1080
> + # Thermometer with SPI interface
> + - ti,lm70
> + - ti,lm71
> # Temperature sensor with 2-wire interface
> - ti,lm73
> + # Thermometer with SPI interface
> + - ti,lm74
> # Temperature sensor with integrated fan control
> - ti,lm96000
> # I2C Touch-Screen Controller
> @@ -313,6 +318,9 @@ properties:
> - ti,tmp102
> # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> - ti,tmp103
> + # Thermometer with SPI interface
> + - ti,tmp121
> + - ti,tmp122
> # Digital Temperature Sensor
> - ti,tmp275
> # TI Dual channel DCAP+ multiphase controller TPS53676 with AVSBus
prev parent reply other threads:[~2021-09-24 1:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
2021-09-20 18:21 ` [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from " Krzysztof Kozlowski
2021-09-23 21:13 ` Rob Herring
2021-09-24 2:05 ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to " Krzysztof Kozlowski
2021-09-23 21:14 ` Rob Herring
2021-09-24 2:06 ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 4/6] dt-bindings: hwmon: hih6130: " Krzysztof Kozlowski
2021-09-23 21:14 ` Rob Herring
2021-09-24 2:07 ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema Krzysztof Kozlowski
2021-09-23 21:15 ` Rob Herring
2021-09-24 2:08 ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b Krzysztof Kozlowski
2021-09-23 21:16 ` Rob Herring
2021-09-24 6:57 ` Krzysztof Kozlowski
2021-09-24 11:51 ` Guenter Roeck
2021-10-08 8:00 ` Krzysztof Kozlowski
2021-10-08 15:15 ` Guenter Roeck
2021-10-08 18:57 ` Rob Herring
2021-10-08 21:06 ` Guenter Roeck
2021-09-23 21:13 ` [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Rob Herring
2021-09-24 1:51 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924015109.GA3029984@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).