From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Rob Herring <robh@kernel.org>, Jean Delvare <jdelvare@suse.com>,
Jiri Kosina <trivial@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
Date: Fri, 24 Sep 2021 04:51:52 -0700 [thread overview]
Message-ID: <20210924115152.GC2694238@roeck-us.net> (raw)
In-Reply-To: <8871dd77-f9f1-bf25-78ad-48f97efcf7d9@canonical.com>
On Fri, Sep 24, 2021 at 08:57:44AM +0200, Krzysztof Kozlowski wrote:
> On 23/09/2021 23:16, Rob Herring wrote:
> > On Mon, Sep 20, 2021 at 08:21:14PM +0200, Krzysztof Kozlowski wrote:
> >> Document bindings for NXP SE97B, a DDR memory module temperature sensor
> >> with integrated SPD and EEPROM via Atmel's AT24 interface.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >> ---
> >> Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
> >> 1 file changed, 9 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> index a7bb4e3a1c46..0e49b3901161 100644
> >> --- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> @@ -10,6 +10,14 @@ maintainers:
> >> - Jean Delvare <jdelvare@suse.com>
> >> - Guenter Roeck <linux@roeck-us.net>
> >>
> >> +select:
> >> + properties:
> >> + compatible:
> >> + const: jedec,jc-42.4-temp
> >> +
> >> + required:
> >> + - compatible
> >> +
> >
> > Is this supposed to be in the last patch? And why is it needed?
>
> Yes, this is here on purpose because of nxp,se97b which is sensor with
> at24-compatible EEPROM.
>
> arch/arm/boot/dts/at91-nattis-2-natte-2.dts:
> 169 temp@18 {
> 170 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>
> 171 reg = <0x18>;
> 172 smbus-timeout-disable;
> 173 };
> 174
> 175 eeprom@50 {
> 176 compatible = "nxp,se97b", "atmel,24c02";
How would that be handled anyway ? Yes, the chip includes both a temperature
sensor and an eeprom, but this node should most definitely not instantiate as
temperature sensor.
Guenter
> 177 reg = <0x50>;
> 178 pagesize = <16>;
>
> Without the select, dtbs_check was complaining about the second node:
>
> eeprom@50: compatible: 'oneOf' conditional failed, one must be fixed:
> ['nxp,se97b', 'atmel,24c02'] is too long
> Additional items are not allowed ('atmel,24c02' was unexpected)
> 'jedec,jc-42.4-temp' was expected
> From schema:
> /home/dev/linux/linux/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>
> eeprom@50: 'pagesize' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema:
> /home/dev/linux/linux/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>
>
> >> properties:
> >> compatible:
> >> oneOf:
> >> @@ -31,6 +39,7 @@ properties:
> >> - microchip,mcp98244
> >> - microchip,mcp9843
> >> - nxp,se97
> >> + - nxp,se97b
> >> - nxp,se98
> >> - onnn,cat6095
> >> - onnn,cat34ts02
> >> --
> >> 2.30.2
> >>
> >>
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2021-09-24 11:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
2021-09-20 18:21 ` [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from " Krzysztof Kozlowski
2021-09-23 21:13 ` Rob Herring
2021-09-24 2:05 ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to " Krzysztof Kozlowski
2021-09-23 21:14 ` Rob Herring
2021-09-24 2:06 ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 4/6] dt-bindings: hwmon: hih6130: " Krzysztof Kozlowski
2021-09-23 21:14 ` Rob Herring
2021-09-24 2:07 ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema Krzysztof Kozlowski
2021-09-23 21:15 ` Rob Herring
2021-09-24 2:08 ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b Krzysztof Kozlowski
2021-09-23 21:16 ` Rob Herring
2021-09-24 6:57 ` Krzysztof Kozlowski
2021-09-24 11:51 ` Guenter Roeck [this message]
2021-10-08 8:00 ` Krzysztof Kozlowski
2021-10-08 15:15 ` Guenter Roeck
2021-10-08 18:57 ` Rob Herring
2021-10-08 21:06 ` Guenter Roeck
2021-09-23 21:13 ` [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Rob Herring
2021-09-24 1:51 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924115152.GC2694238@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).