linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of
@ 2023-01-22 21:36 SeongJae Park
  2023-01-22 21:36 ` [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier SeongJae Park
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: SeongJae Park @ 2023-01-22 21:36 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: SeongJae Park, Alex Deucher, Daniel Vetter, David Airlie,
	David S. Miller, Dmitry Torokhov, Guenter Roeck, Herbert Xu,
	Jaroslav Kysela, Jean Delvare, Maarten Lankhorst, Maxime Ripard,
	Takashi Iwai, Thomas Zimmermann, Andrew Morton, linux-mm,
	alsa-devel, dri-devel, linux-crypto, linux-doc, linux-hwmon,
	linux-input, linux-kernel

Some subsystem documents are missing SPDX license identifiers on index
files.  This patchset adds those.

Changes from v1
(https://lore.kernel.org/lkml/20230114194741.115855-2-sj@kernel.org/)
- Separate from index file content changes
- Separate patch for each subsystem doc (Alex Deucher)
- Use MIT license for gpu (Alex Deucher)

SeongJae Park (8):
  Docs/crypto/index: Add missing SPDX License Identifier
  Docs/driver-api/index: Add missing SPDX License Identifier
  Docs/gpu/index: Add missing SPDX License Identifier
  Docs/hwmon/index: Add missing SPDX License Identifier
  Docs/input/index: Add missing SPDX License Identifier
  Docs/mm/index: Add missing SPDX License Identifier
  Docs/scheduler/index: Add missing SPDX License Identifier
  Docs/sound/index: Add missing SPDX License Identifier

 Documentation/crypto/index.rst     | 2 ++
 Documentation/driver-api/index.rst | 2 ++
 Documentation/gpu/index.rst        | 2 ++
 Documentation/hwmon/index.rst      | 2 ++
 Documentation/input/index.rst      | 2 ++
 Documentation/mm/index.rst         | 2 ++
 Documentation/scheduler/index.rst  | 2 ++
 Documentation/sound/index.rst      | 2 ++
 8 files changed, 16 insertions(+)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
  2023-01-22 21:36 [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of SeongJae Park
@ 2023-01-22 21:36 ` SeongJae Park
  2023-01-24 13:49   ` Guenter Roeck
                     ` (3 more replies)
  2023-01-23 15:02 ` [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of Jonathan Corbet
  2023-01-24 22:31 ` Jonathan Corbet
  2 siblings, 4 replies; 11+ messages in thread
From: SeongJae Park @ 2023-01-22 21:36 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: SeongJae Park, Jean Delvare, Guenter Roeck, linux-hwmon,
	linux-doc, linux-kernel

Add missing SPDX License Identifier for hwmon documentation index file.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 Documentation/hwmon/index.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
index c2b3c1a822dd..2186d732654f 100644
--- a/Documentation/hwmon/index.rst
+++ b/Documentation/hwmon/index.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
 ===================
 Hardware Monitoring
 ===================
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of
  2023-01-22 21:36 [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of SeongJae Park
  2023-01-22 21:36 ` [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier SeongJae Park
@ 2023-01-23 15:02 ` Jonathan Corbet
  2023-01-24 22:31 ` Jonathan Corbet
  2 siblings, 0 replies; 11+ messages in thread
From: Jonathan Corbet @ 2023-01-23 15:02 UTC (permalink / raw)
  To: SeongJae Park
  Cc: SeongJae Park, Alex Deucher, Daniel Vetter, David Airlie,
	David S. Miller, Dmitry Torokhov, Guenter Roeck, Herbert Xu,
	Jaroslav Kysela, Jean Delvare, Maarten Lankhorst, Maxime Ripard,
	Takashi Iwai, Thomas Zimmermann, Andrew Morton, linux-mm,
	alsa-devel, dri-devel, linux-crypto, linux-doc, linux-hwmon,
	linux-input, linux-kernel

SeongJae Park <sj@kernel.org> writes:

> Some subsystem documents are missing SPDX license identifiers on index
> files.  This patchset adds those.

Documentation/ is far behind on the SPDX front, and I'm all in favor of
fixing that.  I do worry, though, about sticking license declarations
onto files that did not previously have them; do we know what the
original contributor's intent was?

> Changes from v1
> (https://lore.kernel.org/lkml/20230114194741.115855-2-sj@kernel.org/)
> - Separate from index file content changes
> - Separate patch for each subsystem doc (Alex Deucher)
> - Use MIT license for gpu (Alex Deucher)
>
> SeongJae Park (8):
>   Docs/crypto/index: Add missing SPDX License Identifier
>   Docs/driver-api/index: Add missing SPDX License Identifier
>   Docs/gpu/index: Add missing SPDX License Identifier
>   Docs/hwmon/index: Add missing SPDX License Identifier
>   Docs/input/index: Add missing SPDX License Identifier
>   Docs/mm/index: Add missing SPDX License Identifier
>   Docs/scheduler/index: Add missing SPDX License Identifier
>   Docs/sound/index: Add missing SPDX License Identifier
>
>  Documentation/crypto/index.rst     | 2 ++
>  Documentation/driver-api/index.rst | 2 ++

I added this one, and GPLv2 is fine there.

>  Documentation/gpu/index.rst        | 2 ++
>  Documentation/hwmon/index.rst      | 2 ++
>  Documentation/input/index.rst      | 2 ++
>  Documentation/mm/index.rst         | 2 ++
>  Documentation/scheduler/index.rst  | 2 ++
>  Documentation/sound/index.rst      | 2 ++
>  8 files changed, 16 insertions(+)

Thanks,

jon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
  2023-01-22 21:36 ` [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier SeongJae Park
@ 2023-01-24 13:49   ` Guenter Roeck
  2023-01-31  3:44   ` Guenter Roeck
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 11+ messages in thread
From: Guenter Roeck @ 2023-01-24 13:49 UTC (permalink / raw)
  To: SeongJae Park
  Cc: Jonathan Corbet, Jean Delvare, linux-hwmon, linux-doc, linux-kernel

On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> Add missing SPDX License Identifier for hwmon documentation index file.
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>

Is it documented somewhere that GPL 2.0 is the default in the absence
of an explicit SPDX or other license identifier ? I don't find it
in Documentation/process/license-rules.rst, though maybe I am missing
it.

Guenter

> ---
>  Documentation/hwmon/index.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  ===================
>  Hardware Monitoring
>  ===================

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of
  2023-01-22 21:36 [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of SeongJae Park
  2023-01-22 21:36 ` [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier SeongJae Park
  2023-01-23 15:02 ` [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of Jonathan Corbet
@ 2023-01-24 22:31 ` Jonathan Corbet
  2023-01-24 23:03   ` SeongJae Park
  2 siblings, 1 reply; 11+ messages in thread
From: Jonathan Corbet @ 2023-01-24 22:31 UTC (permalink / raw)
  To: SeongJae Park
  Cc: SeongJae Park, Alex Deucher, Daniel Vetter, David Airlie,
	David S. Miller, Dmitry Torokhov, Guenter Roeck, Herbert Xu,
	Jaroslav Kysela, Jean Delvare, Maarten Lankhorst, Maxime Ripard,
	Takashi Iwai, Thomas Zimmermann, Andrew Morton, linux-mm,
	alsa-devel, dri-devel, linux-crypto, linux-doc, linux-hwmon,
	linux-input, linux-kernel

SeongJae Park <sj@kernel.org> writes:

> Some subsystem documents are missing SPDX license identifiers on index
> files.  This patchset adds those.
>
> Changes from v1
> (https://lore.kernel.org/lkml/20230114194741.115855-2-sj@kernel.org/)
> - Separate from index file content changes
> - Separate patch for each subsystem doc (Alex Deucher)
> - Use MIT license for gpu (Alex Deucher)
>
> SeongJae Park (8):
>   Docs/crypto/index: Add missing SPDX License Identifier
>   Docs/driver-api/index: Add missing SPDX License Identifier
>   Docs/gpu/index: Add missing SPDX License Identifier
>   Docs/hwmon/index: Add missing SPDX License Identifier
>   Docs/input/index: Add missing SPDX License Identifier
>   Docs/mm/index: Add missing SPDX License Identifier
>   Docs/scheduler/index: Add missing SPDX License Identifier
>   Docs/sound/index: Add missing SPDX License Identifier

So I've applied patches 2 (since I wrote the initial file) and 8 (with
Takashi's ack).  The others are also fine, I think, but I hesitate to
apply license texts to files without knowing that they match the
author's intent.  I hate to say it, but I think the best approach is to
send each of the remaining patches to the appropriate maintainers for
the subsystem involved.

Thanks,

jon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of
  2023-01-24 22:31 ` Jonathan Corbet
@ 2023-01-24 23:03   ` SeongJae Park
  0 siblings, 0 replies; 11+ messages in thread
From: SeongJae Park @ 2023-01-24 23:03 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: SeongJae Park, Alex Deucher, Daniel Vetter, David Airlie,
	David S. Miller, Dmitry Torokhov, Guenter Roeck, Herbert Xu,
	Jaroslav Kysela, Jean Delvare, Maarten Lankhorst, Maxime Ripard,
	Takashi Iwai, Thomas Zimmermann, Andrew Morton, linux-mm,
	alsa-devel, dri-devel, linux-crypto, linux-doc, linux-hwmon,
	linux-input, linux-kernel

On Tue, 24 Jan 2023 15:31:04 -0700 Jonathan Corbet <corbet@lwn.net> wrote:

> SeongJae Park <sj@kernel.org> writes:
> 
> > Some subsystem documents are missing SPDX license identifiers on index
> > files.  This patchset adds those.
> >
> > Changes from v1
> > (https://lore.kernel.org/lkml/20230114194741.115855-2-sj@kernel.org/)
> > - Separate from index file content changes
> > - Separate patch for each subsystem doc (Alex Deucher)
> > - Use MIT license for gpu (Alex Deucher)
> >
> > SeongJae Park (8):
> >   Docs/crypto/index: Add missing SPDX License Identifier
> >   Docs/driver-api/index: Add missing SPDX License Identifier
> >   Docs/gpu/index: Add missing SPDX License Identifier
> >   Docs/hwmon/index: Add missing SPDX License Identifier
> >   Docs/input/index: Add missing SPDX License Identifier
> >   Docs/mm/index: Add missing SPDX License Identifier
> >   Docs/scheduler/index: Add missing SPDX License Identifier
> >   Docs/sound/index: Add missing SPDX License Identifier
> 
> So I've applied patches 2 (since I wrote the initial file) and 8 (with
> Takashi's ack).  The others are also fine, I think, but I hesitate to
> apply license texts to files without knowing that they match the
> author's intent.  I hate to say it, but I think the best approach is to
> send each of the remaining patches to the appropriate maintainers for
> the subsystem involved.

That makes 100% sense, thank you, Jon!


Thanks,
SJ

> 
> Thanks,
> 
> jon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
  2023-01-22 21:36 ` [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier SeongJae Park
  2023-01-24 13:49   ` Guenter Roeck
@ 2023-01-31  3:44   ` Guenter Roeck
  2023-01-31 14:44     ` Jonathan Corbet
  2023-01-31 14:48   ` Mauro Carvalho Chehab
  2023-01-31 15:02   ` Guenter Roeck
  3 siblings, 1 reply; 11+ messages in thread
From: Guenter Roeck @ 2023-01-31  3:44 UTC (permalink / raw)
  To: SeongJae Park
  Cc: Jonathan Corbet, Jean Delvare, linux-hwmon, linux-doc, linux-kernel

On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> Add missing SPDX License Identifier for hwmon documentation index file.
> 

I do not feel comfortable accepting this change without confirmation
that changing the license from <none> to an explicit <GPL v2.0> is
legally acceptable.

Guenter

> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
>  Documentation/hwmon/index.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  ===================
>  Hardware Monitoring
>  ===================

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
  2023-01-31  3:44   ` Guenter Roeck
@ 2023-01-31 14:44     ` Jonathan Corbet
  2023-01-31 14:51       ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 11+ messages in thread
From: Jonathan Corbet @ 2023-01-31 14:44 UTC (permalink / raw)
  To: Guenter Roeck, SeongJae Park
  Cc: Jean Delvare, linux-hwmon, linux-doc, linux-kernel,
	Mauro Carvalho Chehab

Guenter Roeck <linux@roeck-us.net> writes:

> On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
>> Add missing SPDX License Identifier for hwmon documentation index file.
>> 
>
> I do not feel comfortable accepting this change without confirmation
> that changing the license from <none> to an explicit <GPL v2.0> is
> legally acceptable.

As with many of these, this file was initially added by Mauro (added to
CC).  Mauro, can you confirm that GPLv2 was your intention for these
index.rst files?  That would clear the path for a lot of these patches.

Thanks,

jon

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
  2023-01-22 21:36 ` [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier SeongJae Park
  2023-01-24 13:49   ` Guenter Roeck
  2023-01-31  3:44   ` Guenter Roeck
@ 2023-01-31 14:48   ` Mauro Carvalho Chehab
  2023-01-31 15:02   ` Guenter Roeck
  3 siblings, 0 replies; 11+ messages in thread
From: Mauro Carvalho Chehab @ 2023-01-31 14:48 UTC (permalink / raw)
  To: SeongJae Park
  Cc: Jonathan Corbet, Jean Delvare, Guenter Roeck, linux-hwmon,
	linux-doc, linux-kernel

Em Sun, 22 Jan 2023 21:36:46 +0000
SeongJae Park <sj@kernel.org> escreveu:

> Add missing SPDX License Identifier for hwmon documentation index file.
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  Documentation/hwmon/index.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  ===================
>  Hardware Monitoring
>  ===================



Thanks,
Mauro

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
  2023-01-31 14:44     ` Jonathan Corbet
@ 2023-01-31 14:51       ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 11+ messages in thread
From: Mauro Carvalho Chehab @ 2023-01-31 14:51 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: Guenter Roeck, SeongJae Park, Jean Delvare, linux-hwmon,
	linux-doc, linux-kernel

Em Tue, 31 Jan 2023 07:44:02 -0700
Jonathan Corbet <corbet@lwn.net> escreveu:

> Guenter Roeck <linux@roeck-us.net> writes:
> 
> > On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:  
> >> Add missing SPDX License Identifier for hwmon documentation index file.
> >>   
> >
> > I do not feel comfortable accepting this change without confirmation
> > that changing the license from <none> to an explicit <GPL v2.0> is
> > legally acceptable.  
> 
> As with many of these, this file was initially added by Mauro (added to
> CC).  Mauro, can you confirm that GPLv2 was your intention for these
> index.rst files?  That would clear the path for a lot of these patches.

Yes, that's the intend. Feel free to add either:

	Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Or
	Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

to Documentation/*/index.rst files I wrote that might have missing:

	.. SPDX-License-Identifier: GPL-2.0

on the top of it.

Thanks,
Mauro

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
  2023-01-22 21:36 ` [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier SeongJae Park
                     ` (2 preceding siblings ...)
  2023-01-31 14:48   ` Mauro Carvalho Chehab
@ 2023-01-31 15:02   ` Guenter Roeck
  3 siblings, 0 replies; 11+ messages in thread
From: Guenter Roeck @ 2023-01-31 15:02 UTC (permalink / raw)
  To: SeongJae Park
  Cc: Jonathan Corbet, Jean Delvare, linux-hwmon, linux-doc, linux-kernel

On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> Add missing SPDX License Identifier for hwmon documentation index file.
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>
> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  Documentation/hwmon/index.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  ===================
>  Hardware Monitoring
>  ===================

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-01-31 15:06 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-22 21:36 [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of SeongJae Park
2023-01-22 21:36 ` [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier SeongJae Park
2023-01-24 13:49   ` Guenter Roeck
2023-01-31  3:44   ` Guenter Roeck
2023-01-31 14:44     ` Jonathan Corbet
2023-01-31 14:51       ` Mauro Carvalho Chehab
2023-01-31 14:48   ` Mauro Carvalho Chehab
2023-01-31 15:02   ` Guenter Roeck
2023-01-23 15:02 ` [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of Jonathan Corbet
2023-01-24 22:31 ` Jonathan Corbet
2023-01-24 23:03   ` SeongJae Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).