linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/1] Fix race condition for X670E Hero
@ 2023-08-21 11:52 Eugene Shalygin
  2023-08-21 11:52 ` [PATCH v2 1/1] hwmon: (asus-ec-sensosrs) fix mutex path " Eugene Shalygin
  0 siblings, 1 reply; 3+ messages in thread
From: Eugene Shalygin @ 2023-08-21 11:52 UTC (permalink / raw)
  To: eugene.shalygin
  Cc: Jean Delvare, Guenter Roeck, Michael Carns, linux-hwmon, linux-kernel

Changes in v2:
 - Add a link to a GitHub inssue to the commit message.

Eugene Shalygin (1):
  hwmon: (asus-ec-sensosrs) fix mutex path for X670E Hero

 drivers/hwmon/asus-ec-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/1] hwmon: (asus-ec-sensosrs) fix mutex path for X670E Hero
  2023-08-21 11:52 [PATCH v2 0/1] Fix race condition for X670E Hero Eugene Shalygin
@ 2023-08-21 11:52 ` Eugene Shalygin
  2023-08-21 13:06   ` Guenter Roeck
  0 siblings, 1 reply; 3+ messages in thread
From: Eugene Shalygin @ 2023-08-21 11:52 UTC (permalink / raw)
  To: eugene.shalygin
  Cc: Jean Delvare, Guenter Roeck, Michael Carns, linux-hwmon, linux-kernel

A user reported that they observe race condition warning [1] and after
looking once again into the DSDT source it was found that wrong mutex
was used.

[1] https://github.com/zeule/asus-ec-sensors/issues/43

Fixes: 790dec13c012 ("hwmon: (asus-ec-sensors) add ROG Crosshair X670E Hero.")
Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
---
 drivers/hwmon/asus-ec-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index f52a539eb33e..51f9c2db403e 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -340,7 +340,7 @@ static const struct ec_board_info board_info_crosshair_x670e_hero = {
 	.sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
 		SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
 		SENSOR_SET_TEMP_WATER,
-	.mutex_path = ASUS_HW_ACCESS_MUTEX_RMTW_ASMX,
+	.mutex_path = ACPI_GLOBAL_LOCK_PSEUDO_PATH,
 	.family = family_amd_600_series,
 };
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] hwmon: (asus-ec-sensosrs) fix mutex path for X670E Hero
  2023-08-21 11:52 ` [PATCH v2 1/1] hwmon: (asus-ec-sensosrs) fix mutex path " Eugene Shalygin
@ 2023-08-21 13:06   ` Guenter Roeck
  0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-08-21 13:06 UTC (permalink / raw)
  To: Eugene Shalygin; +Cc: Jean Delvare, Michael Carns, linux-hwmon, linux-kernel

On Mon, Aug 21, 2023 at 01:52:35PM +0200, Eugene Shalygin wrote:
> A user reported that they observe race condition warning [1] and after
> looking once again into the DSDT source it was found that wrong mutex
> was used.
> 
> [1] https://github.com/zeule/asus-ec-sensors/issues/43
> 
> Fixes: 790dec13c012 ("hwmon: (asus-ec-sensors) add ROG Crosshair X670E Hero.")
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>

Applied.

Note that you don't have to (and should not) send an introduction
for a 1-patch "series". Add the change log after "---" instead.

Thanks,
Guenter

> ---
>  drivers/hwmon/asus-ec-sensors.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index f52a539eb33e..51f9c2db403e 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -340,7 +340,7 @@ static const struct ec_board_info board_info_crosshair_x670e_hero = {
>  	.sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
>  		SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
>  		SENSOR_SET_TEMP_WATER,
> -	.mutex_path = ASUS_HW_ACCESS_MUTEX_RMTW_ASMX,
> +	.mutex_path = ACPI_GLOBAL_LOCK_PSEUDO_PATH,
>  	.family = family_amd_600_series,
>  };
>  

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-21 13:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-21 11:52 [PATCH v2 0/1] Fix race condition for X670E Hero Eugene Shalygin
2023-08-21 11:52 ` [PATCH v2 1/1] hwmon: (asus-ec-sensosrs) fix mutex path " Eugene Shalygin
2023-08-21 13:06   ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).