* Re: [PATCH v2 4/4] hwmon: (it87) Disable/enable SMBus access for IT8622E chipset
@ 2023-04-16 14:51 Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2023-04-16 14:51 UTC (permalink / raw)
To: Frank Crawford; +Cc: Jean Delvare, linux-hwmon
On Sun, Apr 16, 2023 at 02:25:10PM +1000, Frank Crawford wrote:
> Configure the IT8622E chip to disable/re-enable access via an SMBus when
> reading or writing the chip's registers.
>
> Signed-off-by: Frank Crawford <frank@crawford.emu.id.au>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 0/4] hwmon: (it87) Add access control for SMBus
@ 2023-04-16 4:25 Frank Crawford
2023-04-16 4:25 ` [PATCH v2 4/4] hwmon: (it87) Disable/enable SMBus access for IT8622E chipset Frank Crawford
0 siblings, 1 reply; 2+ messages in thread
From: Frank Crawford @ 2023-04-16 4:25 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck; +Cc: linux-hwmon, Frank Crawford
Some chips support Environmental Controller access through SMBus.
On those chips, it is possible that an Embedded Controller accesses
Environmental Controller chip registers at any time. There is no real
means for synchronization. On banked chips, this can and will result in
access errors with unpredictable result.
Disable SMBus access while reading or writing environmental controller
registers to work around the problem.
---
Changes since v1:
* Reorder patches within patchset.
* Remove spaces before tab.
Frank Crawford (4):
Some chips support Environmental Controller access through SMBus.
Disable SMBus access while reading or writing environmental
controller registers.
Test for error in call to it87_update_device and return error.
Add calls to smbus_enable/smbus_disable as required.
Disable/enable SMBus access for IT8622E chipset.
drivers/hwmon/it87.c | 288 +++++++++++++++++++++++++++++++++++--------
1 file changed, 240 insertions(+), 48 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 4/4] hwmon: (it87) Disable/enable SMBus access for IT8622E chipset
2023-04-16 4:25 [PATCH v2 0/4] hwmon: (it87) Add access control for SMBus Frank Crawford
@ 2023-04-16 4:25 ` Frank Crawford
0 siblings, 0 replies; 2+ messages in thread
From: Frank Crawford @ 2023-04-16 4:25 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck; +Cc: linux-hwmon, Frank Crawford
Configure the IT8622E chip to disable/re-enable access via an SMBus when
reading or writing the chip's registers.
Signed-off-by: Frank Crawford <frank@crawford.emu.id.au>
---
v2:
* No change.
---
drivers/hwmon/it87.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 2922f551b717..9b7628b2a678 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -474,6 +474,7 @@ static const struct it87_devices it87_devices[] = {
| FEAT_FIVE_PWM | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2
| FEAT_AVCC3 | FEAT_VIN3_5V,
.peci_mask = 0x07,
+ .smbus_bitmap = BIT(1) | BIT(2),
},
[it8628] = {
.name = "it8628",
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-16 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-16 14:51 [PATCH v2 4/4] hwmon: (it87) Disable/enable SMBus access for IT8622E chipset Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2023-04-16 4:25 [PATCH v2 0/4] hwmon: (it87) Add access control for SMBus Frank Crawford
2023-04-16 4:25 ` [PATCH v2 4/4] hwmon: (it87) Disable/enable SMBus access for IT8622E chipset Frank Crawford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).