* Re: hwmon: (pcf8591) Unused attribute group pcf8591_attr_group_opt
[not found] <141521621084257@mail.yandex.ru>
@ 2021-05-15 13:44 ` Guenter Roeck
0 siblings, 0 replies; only message in thread
From: Guenter Roeck @ 2021-05-15 13:44 UTC (permalink / raw)
To: Evgeny Novikov, Jean Delvare; +Cc: linux-hwmon, linux-kernel, ldv-project
On 5/15/21 6:20 AM, Evgeny Novikov wrote:
> Driver drivers/hwmon/pcf8591.ko declares and removes attribute group
> pcf8591_attr_group_opt, but it does not create it ever. Is it better to remove
> it completely or to do something else?
Do nothing. Look closely at the file instead to see how the attributes
are created, and realize that the group is only used to simplify
attribute removal.
Yes, the code is a bit odd and unusual, but it is WAI.
Guenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-15 13:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <141521621084257@mail.yandex.ru>
2021-05-15 13:44 ` hwmon: (pcf8591) Unused attribute group pcf8591_attr_group_opt Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).