* [PATCH 0/5] hwmon: Add driver for MAX6620 Fan controller
@ 2021-07-06 13:01 Balac, Arun Saravanan
2021-07-06 13:11 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Balac, Arun Saravanan @ 2021-07-06 13:01 UTC (permalink / raw)
To: linux, jdelvare; +Cc: linux-hwmon
From: Arun Saravanan Balachandran <Arun_Saravanan_Balac@dell.com>
Add driver for MAX6620 Fan controller
Arun Saravanan Balachandran (2):
Add attributes in MAX6620 driver to retrieve fan fault status
Update MAX6620 driver as per linux code guidelines
Cumulus Networks (2):
Driver for MAX6620 Fan sensor
MAX6620 fix rpm calculation accuracy
Shuotian Cheng (1):
Update MAX6620 driver to support newer kernel version
drivers/hwmon/Kconfig | 10 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/max6620.c | 625 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 636 insertions(+)
create mode 100644 drivers/hwmon/max6620.c
base-commit: 303392fd5c160822bf778270b28ec5ea50cab2b4
--
2.32.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/5] hwmon: Add driver for MAX6620 Fan controller
2021-07-06 13:01 [PATCH 0/5] hwmon: Add driver for MAX6620 Fan controller Balac, Arun Saravanan
@ 2021-07-06 13:11 ` Guenter Roeck
2021-07-26 7:47 ` Balac, Arun Saravanan
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2021-07-06 13:11 UTC (permalink / raw)
To: Balac, Arun Saravanan, jdelvare; +Cc: linux-hwmon
On 7/6/21 6:01 AM, Balac, Arun Saravanan wrote:
> From: Arun Saravanan Balachandran <Arun_Saravanan_Balac@dell.com>
>
> Add driver for MAX6620 Fan controller
>
> Arun Saravanan Balachandran (2):
> Add attributes in MAX6620 driver to retrieve fan fault status
> Update MAX6620 driver as per linux code guidelines
>
> Cumulus Networks (2):
> Driver for MAX6620 Fan sensor
> MAX6620 fix rpm calculation accuracy
>
> Shuotian Cheng (1):
> Update MAX6620 driver to support newer kernel version
>
> drivers/hwmon/Kconfig | 10 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/max6620.c | 625 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 636 insertions(+)
> create mode 100644 drivers/hwmon/max6620.c
>
>
> base-commit: 303392fd5c160822bf778270b28ec5ea50cab2b4
>
Please squash all patches into one, and please use
devm_hwmon_device_register_with_info to register the hardware
monitoring device.
Also please follow the guidelines in
Documentation/hwmon/submitting-patches.rst.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 0/5] hwmon: Add driver for MAX6620 Fan controller
2021-07-06 13:11 ` Guenter Roeck
@ 2021-07-26 7:47 ` Balac, Arun Saravanan
2021-07-26 13:42 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Balac, Arun Saravanan @ 2021-07-26 7:47 UTC (permalink / raw)
To: Guenter Roeck, jdelvare; +Cc: linux-hwmon
Thank you for the review comments.
Am currently working on the suggested changes and will submit the same for your review.
Request your insights on the recommended method to include the author information of the earlier patches,
in the commit message while squashing them into one.
Regards,
Arun Saravanan
-----Original Message-----
From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
Sent: Tuesday, July 6, 2021 6:42 PM
To: Balac, Arun Saravanan; jdelvare@suse.com
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 0/5] hwmon: Add driver for MAX6620 Fan controller
On 7/6/21 6:01 AM, Balac, Arun Saravanan wrote:
> From: Arun Saravanan Balachandran <Arun_Saravanan_Balac@dell.com>
>
> Add driver for MAX6620 Fan controller
>
> Arun Saravanan Balachandran (2):
> Add attributes in MAX6620 driver to retrieve fan fault status
> Update MAX6620 driver as per linux code guidelines
>
> Cumulus Networks (2):
> Driver for MAX6620 Fan sensor
> MAX6620 fix rpm calculation accuracy
>
> Shuotian Cheng (1):
> Update MAX6620 driver to support newer kernel version
>
> drivers/hwmon/Kconfig | 10 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/max6620.c | 625 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 636 insertions(+)
> create mode 100644 drivers/hwmon/max6620.c
>
>
> base-commit: 303392fd5c160822bf778270b28ec5ea50cab2b4
>
Please squash all patches into one, and please use
devm_hwmon_device_register_with_info to register the hardware
monitoring device.
Also please follow the guidelines in
Documentation/hwmon/submitting-patches.rst.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/5] hwmon: Add driver for MAX6620 Fan controller
2021-07-26 7:47 ` Balac, Arun Saravanan
@ 2021-07-26 13:42 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-07-26 13:42 UTC (permalink / raw)
To: Balac, Arun Saravanan, jdelvare; +Cc: linux-hwmon
On 7/26/21 12:47 AM, Balac, Arun Saravanan wrote:
> Thank you for the review comments.
> Am currently working on the suggested changes and will submit the same for your review.
>
> Request your insights on the recommended method to include the author information of the earlier patches,
> in the commit message while squashing them into one.
>
Either "based on ..." in the commit description or, more formally, "Originally-from:".
Guenter
> Regards,
> Arun Saravanan
>
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Tuesday, July 6, 2021 6:42 PM
> To: Balac, Arun Saravanan; jdelvare@suse.com
> Cc: linux-hwmon@vger.kernel.org
> Subject: Re: [PATCH 0/5] hwmon: Add driver for MAX6620 Fan controller
>
>
> On 7/6/21 6:01 AM, Balac, Arun Saravanan wrote:
>> From: Arun Saravanan Balachandran <Arun_Saravanan_Balac@dell.com>
>>
>> Add driver for MAX6620 Fan controller
>>
>> Arun Saravanan Balachandran (2):
>> Add attributes in MAX6620 driver to retrieve fan fault status
>> Update MAX6620 driver as per linux code guidelines
>>
>> Cumulus Networks (2):
>> Driver for MAX6620 Fan sensor
>> MAX6620 fix rpm calculation accuracy
>>
>> Shuotian Cheng (1):
>> Update MAX6620 driver to support newer kernel version
>>
>> drivers/hwmon/Kconfig | 10 +
>> drivers/hwmon/Makefile | 1 +
>> drivers/hwmon/max6620.c | 625 ++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 636 insertions(+)
>> create mode 100644 drivers/hwmon/max6620.c
>>
>>
>> base-commit: 303392fd5c160822bf778270b28ec5ea50cab2b4
>>
> Please squash all patches into one, and please use
> devm_hwmon_device_register_with_info to register the hardware
> monitoring device.
>
> Also please follow the guidelines in
> Documentation/hwmon/submitting-patches.rst.
>
> Thanks,
> Guenter
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-26 13:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 13:01 [PATCH 0/5] hwmon: Add driver for MAX6620 Fan controller Balac, Arun Saravanan
2021-07-06 13:11 ` Guenter Roeck
2021-07-26 7:47 ` Balac, Arun Saravanan
2021-07-26 13:42 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).