linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* amdgpu creating fan attribute for integrated graphics
@ 2018-11-28 16:20 Philippe L
       [not found] ` <BN6PR12MB180917C25343DCC507B3DB7BF7D10@BN6PR12MB1809.namprd12.prod.outlook.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe L @ 2018-11-28 16:20 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David (ChunMing) Zhou
  Cc: Guenter Roeck, linux-hwmon

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

Hello,

I'm writing to you after discussing a fancontrol issue on the lm-sensors
issue tracker. I have a AMD Ryzen 5 2400G APU (with integrated graphics).
The amdgpu driver is loaded and also creates a fan1_input attribute.
However there is no separate GPU fan, there is only the CPU (APU) fan which
is controlled by the motherboard. The fan1_input also seems to give some
invalid readouts. I have not yet reached the bottom of this investigation,
but so far my conclusion is that this causes fancontrol to choke up.

Specifically the comment by Guenter Roeck here
https://github.com/lm-sensors/lm-sensors/issues/144#issuecomment-442165451
describes the findings regarding the amdgpu driver.

I'm writing to notify you about this problem, perhaps there can be some
improvement in the amdgpu driver. I'm not really knowledgeable to discuss
the workings of these drivers but i can provide debug output if needed.

Best regards,
Philippe

[-- Attachment #2: Type: text/html, Size: 2021 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: amdgpu creating fan attribute for integrated graphics
       [not found] ` <BN6PR12MB180917C25343DCC507B3DB7BF7D10@BN6PR12MB1809.namprd12.prod.outlook.com>
@ 2018-11-28 20:00   ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2018-11-28 20:00 UTC (permalink / raw)
  To: Deucher, Alexander, Philippe L, Koenig, Christian, Zhou, David(ChunMing)
  Cc: linux-hwmon

On 11/28/18 10:53 AM, Deucher, Alexander wrote:
> I believe the attached patch should fix the issue.
> 

There is also a power attribute which returns -EINVAL, plus if I remember
correctly some voltage attributes.

Guenter

> 
> Alex
> 
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Philippe L <flip101@gmail.com>
> *Sent:* Wednesday, November 28, 2018 11:20:38 AM
> *To:* Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing)
> *Cc:* Guenter Roeck; linux-hwmon@vger.kernel.org
> *Subject:* amdgpu creating fan attribute for integrated graphics
> Hello,
> 
> I'm writing to you after discussing a fancontrol issue on the lm-sensors issue tracker. I have a AMD Ryzen 5 2400G APU (with integrated graphics). The amdgpu driver is loaded and also creates a fan1_input attribute. However there is no separate GPU fan, there is only the CPU (APU) fan which is controlled by the motherboard. The fan1_input also seems to give some invalid readouts. I have not yet reached the bottom of this investigation, but so far my conclusion is that this causes fancontrol to choke up.
> 
> Specifically the comment by Guenter Roeck here https://github.com/lm-sensors/lm-sensors/issues/144#issuecomment-442165451 describes the findings regarding the amdgpu driver.
> 
> I'm writing to notify you about this problem, perhaps there can be some improvement in the amdgpu driver. I'm not really knowledgeable to discuss the workings of these drivers but i can provide debug output if needed.
> 
> Best regards,
> Philippe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-29  7:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-28 16:20 amdgpu creating fan attribute for integrated graphics Philippe L
     [not found] ` <BN6PR12MB180917C25343DCC507B3DB7BF7D10@BN6PR12MB1809.namprd12.prod.outlook.com>
2018-11-28 20:00   ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).