From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "Mariusz Białończyk" <manio@skyboo.net>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: hwmon: (adt7475) Add support for inverting pwm output
Date: Tue, 18 Apr 2023 21:20:02 +0000 [thread overview]
Message-ID: <52e26a67-9131-2dc0-40cb-db5c07370027@alliedtelesis.co.nz> (raw)
In-Reply-To: <e398560f-f8d1-afbc-4aae-ab3cf2555e8e@alliedtelesis.co.nz>
On 19/04/23 08:41, Chris Packham wrote:
> Hi Marius,
>
> +cc linux-hwmon, lkml
>
> On 18/04/23 23:06, Mariusz Białończyk wrote:
>> Hi Chris,
>> I discovered by accident that my dmesg is telling me:
>> [Mon Apr 17 19:08:59 2023] adt7475 19-002e: Error configuring pwm
>> polarity
>> [Mon Apr 17 19:08:59 2023] adt7475 19-002e: ADT7473 device, revision 1
>>
>> motherboard:
>> DMI: System manufacturer System Product Name/M4A785TD-V EVO, BIOS
>> 2105 07/23/2010
>>
>> Is this something i need to be afraid, or it's nothing serious?
>
> It's probably harmless, unless your board is intentionally setting the
> pwm-active-state (which I suspect it won't be as your BIOS is probably
> taking care of that if required). I suspect it's more a case of the
> code not handling the absence of a device tree which the check for
> -EINVAL was supposed to deal with. There's an outside chance that
> there is a problem on the I2C bus but that would require your platform
> to be actively using the pwm polarity feature via a device tree
> (unlikely outside of embedded devices).
>
> I think it'd still be a good idea to squash the errant warning so
> genuine errors are caught. I'll see if I can provoke the issue on
> devices I have access to. Are you in a position to try a patch if I
> come up with one?
Ah I think I see the problem. On platforms without device tree support
the of_property_read_*() functions return -ENOSYS so I need to deal with
that error code as well as -EINVAL.
prev parent reply other threads:[~2023-04-18 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230418110623.vk6kettnjondulri@skyboo.net>
2023-04-18 20:41 ` hwmon: (adt7475) Add support for inverting pwm output Chris Packham
2023-04-18 21:20 ` Chris Packham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52e26a67-9131-2dc0-40cb-db5c07370027@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manio@skyboo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).