* Re: hwmon: (adt7475) Add support for inverting pwm output [not found] <20230418110623.vk6kettnjondulri@skyboo.net> @ 2023-04-18 20:41 ` Chris Packham 2023-04-18 21:20 ` Chris Packham 0 siblings, 1 reply; 2+ messages in thread From: Chris Packham @ 2023-04-18 20:41 UTC (permalink / raw) To: Mariusz Białończyk; +Cc: linux-hwmon, linux-kernel Hi Marius, +cc linux-hwmon, lkml On 18/04/23 23:06, Mariusz Białończyk wrote: > Hi Chris, > I discovered by accident that my dmesg is telling me: > [Mon Apr 17 19:08:59 2023] adt7475 19-002e: Error configuring pwm polarity > [Mon Apr 17 19:08:59 2023] adt7475 19-002e: ADT7473 device, revision 1 > > motherboard: > DMI: System manufacturer System Product Name/M4A785TD-V EVO, BIOS 2105 07/23/2010 > > Is this something i need to be afraid, or it's nothing serious? It's probably harmless, unless your board is intentionally setting the pwm-active-state (which I suspect it won't be as your BIOS is probably taking care of that if required). I suspect it's more a case of the code not handling the absence of a device tree which the check for -EINVAL was supposed to deal with. There's an outside chance that there is a problem on the I2C bus but that would require your platform to be actively using the pwm polarity feature via a device tree (unlikely outside of embedded devices). I think it'd still be a good idea to squash the errant warning so genuine errors are caught. I'll see if I can provoke the issue on devices I have access to. Are you in a position to try a patch if I come up with one? ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: hwmon: (adt7475) Add support for inverting pwm output 2023-04-18 20:41 ` hwmon: (adt7475) Add support for inverting pwm output Chris Packham @ 2023-04-18 21:20 ` Chris Packham 0 siblings, 0 replies; 2+ messages in thread From: Chris Packham @ 2023-04-18 21:20 UTC (permalink / raw) To: Mariusz Białończyk; +Cc: linux-hwmon, linux-kernel On 19/04/23 08:41, Chris Packham wrote: > Hi Marius, > > +cc linux-hwmon, lkml > > On 18/04/23 23:06, Mariusz Białończyk wrote: >> Hi Chris, >> I discovered by accident that my dmesg is telling me: >> [Mon Apr 17 19:08:59 2023] adt7475 19-002e: Error configuring pwm >> polarity >> [Mon Apr 17 19:08:59 2023] adt7475 19-002e: ADT7473 device, revision 1 >> >> motherboard: >> DMI: System manufacturer System Product Name/M4A785TD-V EVO, BIOS >> 2105 07/23/2010 >> >> Is this something i need to be afraid, or it's nothing serious? > > It's probably harmless, unless your board is intentionally setting the > pwm-active-state (which I suspect it won't be as your BIOS is probably > taking care of that if required). I suspect it's more a case of the > code not handling the absence of a device tree which the check for > -EINVAL was supposed to deal with. There's an outside chance that > there is a problem on the I2C bus but that would require your platform > to be actively using the pwm polarity feature via a device tree > (unlikely outside of embedded devices). > > I think it'd still be a good idea to squash the errant warning so > genuine errors are caught. I'll see if I can provoke the issue on > devices I have access to. Are you in a position to try a patch if I > come up with one? Ah I think I see the problem. On platforms without device tree support the of_property_read_*() functions return -ENOSYS so I need to deal with that error code as well as -EINVAL. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-18 21:20 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20230418110623.vk6kettnjondulri@skyboo.net> 2023-04-18 20:41 ` hwmon: (adt7475) Add support for inverting pwm output Chris Packham 2023-04-18 21:20 ` Chris Packham
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).