From: Guenter Roeck <linux@roeck-us.net>
To: Kun Yi <kunyi@google.com>,
jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com
Cc: openbmc@lists.ozlabs.org, joel@jms.id.au,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux hwmon-next v3 3/3] dt-bindings: (hwmon/sbtsi_tmep) Add SB-TSI hwmon driver bindings
Date: Sun, 5 Apr 2020 08:48:02 -0700 [thread overview]
Message-ID: <a49060b5-a529-e6b2-2690-cac4681c7722@roeck-us.net> (raw)
In-Reply-To: <20200405030118.191950-4-kunyi@google.com>
On 4/4/20 8:01 PM, Kun Yi wrote:
> Document device tree bindings for AMD SB-TSI emulated temperature
> sensor.
>
> Signed-off-by: Kun Yi <kunyi@google.com>
> ---
> .../devicetree/bindings/hwmon/amd,sbtsi.txt | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/amd,sbtsi.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/amd,sbtsi.txt b/Documentation/devicetree/bindings/hwmon/amd,sbtsi.txt
> new file mode 100644
> index 000000000000..be7293c43c0e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/amd,sbtsi.txt
> @@ -0,0 +1,26 @@
> +* Sideband interface Temperature Sensor Interface (SB-TSI) compliant
> +AMD SoC temperature device.
> +
> +SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible
> +interface that reports AMD SoC's Ttcl (normalized temperature),
> +and resembles a typical 8-pin remote temperature sensor's I2C interface
> +to BMC. The emulated thermal sensor can report temperatures in increments of
> +0.125 degrees, ranging from 0 to 255.875.
> +
> +Required properties:
> +- compatible: manufacturer and chip name, should be
> + "amd,sbtsi",
> +
> +- reg: I2C bus address of the device as specified in Section 6.3.1 of the
> +SoC register reference: The SB-TSI address is normally 98h for socket 0 and
> +90h for socket 1, but it could vary based on hardware address select pins.
> +
> +[open source SoC register reference]:
> + https://www.amd.com/system/files/TechDocs/56255_OSRR.pdf
> +
> +Example:
> +
> +sbtsi@4c {
> + compatible = "amd,sbtsi";
> + reg = <0x4c>;
> +};
>
Rob is going to ask you to provide this information in DT schema format
(Documentation/devicetree/writing-schema.rst). checkpatch tells you the same
nowadays.
Guenter
prev parent reply other threads:[~2020-04-05 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 3:01 [PATCH linux hwmon-next v3 0/3] SB-TSI hwmon driver v3 Kun Yi
2020-04-05 3:01 ` [PATCH linux hwmon-next v3 1/3] hwmon: (sbtsi) Add basic support for SB-TSI sensors Kun Yi
2020-04-05 16:27 ` Guenter Roeck
2020-04-05 3:01 ` [PATCH linux hwmon-next v3 2/3] hwmon: (sbtsi) Add documentation Kun Yi
2020-04-05 3:01 ` [PATCH linux hwmon-next v3 3/3] dt-bindings: (hwmon/sbtsi_tmep) Add SB-TSI hwmon driver bindings Kun Yi
2020-04-05 15:48 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a49060b5-a529-e6b2-2690-cac4681c7722@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=kunyi@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).