From: "Sa, Nuno" <Nuno.Sa@analog.com>
To: "mdf@kernel.org" <mdf@kernel.org>
Cc: "linux@roeck-us.net" <linux@roeck-us.net>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] include: fpga: adi-axi-common: Define version macros
Date: Mon, 30 Sep 2019 10:46:38 +0000 [thread overview]
Message-ID: <a9f4640768627fc17ff220996afd6d4b63de2505.camel@analog.com> (raw)
In-Reply-To: <20190927150114.GA2146@archbox>
Hi Moritz,
On Fri, 2019-09-27 at 08:01 -0700, Moritz Fischer wrote:
>
> Hi Nuno,
>
> On Thu, Sep 26, 2019 at 12:39:23PM +0200, Nuno Sá wrote:
> > Add commom macros to "parse" ADI HDL cores version, in terms of
> > major, minor and patch.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > include/linux/fpga/adi-axi-common.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/include/linux/fpga/adi-axi-common.h
> > b/include/linux/fpga/adi-axi-common.h
> > index 7fc95d5c95bb..5bc5603e6bc8 100644
> > --- a/include/linux/fpga/adi-axi-common.h
> > +++ b/include/linux/fpga/adi-axi-common.h
> > @@ -16,4 +16,8 @@
> > #define ADI_AXI_PCORE_VER(major, minor, patch) \
> > (((major) << 16) | ((minor) << 8) | (patch))
> >
> > +#define ADI_AXI_PCORE_VER_MAJOR(version) (((version) >> 16) &
> > 0xff)
> > +#define ADI_AXI_PCORE_VER_MINOR(version) (((version) >> 8) &
> > 0xff)
> > +#define ADI_AXI_PCORE_VER_PATCH(version) ((version) & 0xff)
> > +
> > #endif /* ADI_AXI_COMMON_H_ */
> > --
> > 2.23.0
> >
>
> While implemented in an FPGA I'm not sure if this needs to go into
> includelinux/fpga/.
>
> I'd suggest to add this to the actual driver for now, and once you
> have
> multiple users you can find a common location.
Will do that.
> Cheers,
> Moritz
Thanks!
Nuno Sá
next prev parent reply other threads:[~2019-09-30 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 10:39 [PATCH 0/3] Support AXI FAN Control IP core Nuno Sá
2019-09-26 10:39 ` [PATCH 1/3] include: fpga: adi-axi-common: Define version macros Nuno Sá
2019-09-27 15:01 ` Moritz Fischer
2019-09-30 10:46 ` Sa, Nuno [this message]
2019-09-26 10:39 ` [PATCH 2/3] hwmon: Support ADI Fan Control IP Nuno Sá
2019-10-06 15:32 ` Guenter Roeck
2019-10-07 13:52 ` Sa, Nuno
2019-10-07 14:18 ` Guenter Roeck
2019-10-07 15:08 ` Sa, Nuno
2019-10-08 15:59 ` Sa, Nuno
2019-10-08 20:11 ` Guenter Roeck
2019-10-09 7:10 ` Sa, Nuno
2019-09-26 10:39 ` [PATCH 3/3] dt-bindings: hwmon: Add AXI FAN Control documentation Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9f4640768627fc17ff220996afd6d4b63de2505.camel@analog.com \
--to=nuno.sa@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).