From: Colin Ian King <colin.king@canonical.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Jean Delvare" <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] hwmon: axi-fan-control: fix uninitialized dereference of pointer res
Date: Tue, 11 Feb 2020 16:41:31 +0000 [thread overview]
Message-ID: <c4dfa7e1-a833-7bfd-2d5b-800892fb5fe4@canonical.com> (raw)
In-Reply-To: <20200211163910.GA2975@roeck-us.net>
On 11/02/2020 16:39, Guenter Roeck wrote:
> On Tue, Feb 11, 2020 at 04:20:59PM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently the resource pointer ret is uninitialized and it is
>> being dereferenced when printing out a debug message. Fix this
>> by fetching the resource and assigning pointer res. It is
>> a moot point that we sanity check for a null res since a successful
>> call to devm_platform_ioremap_resource has already occurred so
>> in theory it should never be non-null.
>>
>> Addresses-Coverity: ("Uninitialized pointer read")
>> Fixes: 690dd9ce04f6 ("hwmon: Support ADI Fan Control IP")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> This has already been fixed by removing the message (and the
> then unused variable). The message was useless anyway since
> it printed the remapped address with %p.
>
> Guenter
OK, thanks. My static anaylsis can't keep up!
>
>> ---
>> drivers/hwmon/axi-fan-control.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
>> index 8041ba7cc152..36e0d060510a 100644
>> --- a/drivers/hwmon/axi-fan-control.c
>> +++ b/drivers/hwmon/axi-fan-control.c
>> @@ -415,6 +415,9 @@ static int axi_fan_control_probe(struct platform_device *pdev)
>> if (!ctl->clk_rate)
>> return -EINVAL;
>>
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + if (!res)
>> + return -EINVAL;
>> dev_dbg(&pdev->dev, "Re-mapped from 0x%08llX to %p\n",
>> (unsigned long long)res->start, ctl->base);
>>
>> --
>> 2.25.0
>>
prev parent reply other threads:[~2020-02-11 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 16:20 [PATCH][next] hwmon: axi-fan-control: fix uninitialized dereference of pointer res Colin King
2020-02-11 16:39 ` Guenter Roeck
2020-02-11 16:41 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4dfa7e1-a833-7bfd-2d5b-800892fb5fe4@canonical.com \
--to=colin.king@canonical.com \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).