Linux-Hwmon Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3 0/2] hwmon: (pmbus) add support for Gen 2 Renesas digital multiphase
@ 2020-03-20 16:15 Grant Peltier
  2020-03-20 16:16 ` [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen " Grant Peltier
  2020-03-20 16:16 ` [PATCH v3 2/2] docs: hwmon: Update documentation for isl68137 pmbus driver Grant Peltier
  0 siblings, 2 replies; 6+ messages in thread
From: Grant Peltier @ 2020-03-20 16:15 UTC (permalink / raw)
  To: linux, linux-hwmon, linux-kernel; +Cc: adam.vaughn.xh

The patch series adds support for 2nd generation Renesas digitial multiphase
voltage regulators. This functionality extends the existing ISL68137 PMBus
driver.

The series contains 2 patches:
  - patch #1 adds extends the ISL68137 driver to support Gen 2 devices
  - patch #2 adds documentation for the newly supported devices

Grant Peltier (2):
  hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase
  docs: hwmon: Update documentation for isl68137 pmbus driver

 Documentation/hwmon/isl68137.rst | 541 ++++++++++++++++++++++++++++++-
 drivers/hwmon/pmbus/Kconfig      |   6 +-
 drivers/hwmon/pmbus/isl68137.c   | 110 ++++++-
 3 files changed, 631 insertions(+), 26 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase
  2020-03-20 16:15 [PATCH v3 0/2] hwmon: (pmbus) add support for Gen 2 Renesas digital multiphase Grant Peltier
@ 2020-03-20 16:16 ` " Grant Peltier
  2020-03-21 22:09   ` Guenter Roeck
  2020-04-01 16:39   ` Guenter Roeck
  2020-03-20 16:16 ` [PATCH v3 2/2] docs: hwmon: Update documentation for isl68137 pmbus driver Grant Peltier
  1 sibling, 2 replies; 6+ messages in thread
From: Grant Peltier @ 2020-03-20 16:16 UTC (permalink / raw)
  To: linux, linux-hwmon, linux-kernel; +Cc: adam.vaughn.xh

Extend the isl68137 driver to provide support for 2nd generation Renesas
digital multiphase voltage regulators.

Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
---
 drivers/hwmon/pmbus/Kconfig    |   6 +-
 drivers/hwmon/pmbus/isl68137.c | 110 ++++++++++++++++++++++++++++-----
 2 files changed, 98 insertions(+), 18 deletions(-)

diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index a9ea06204767..1e3e5a61ed9c 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -92,10 +92,10 @@ config SENSORS_IRPS5401
 	  be called irps5401.
 
 config SENSORS_ISL68137
-	tristate "Intersil ISL68137"
+	tristate "Renesas Digital Multiphase Voltage Regulators"
 	help
-	  If you say yes here you get hardware monitoring support for Intersil
-	  ISL68137.
+	  If you say yes here you get hardware monitoring support for Renesas
+	  digital multiphase voltage regulators.
 
 	  This driver can also be built as a module. If so, the module will
 	  be called isl68137.
diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 515596c92fe1..47f6cce1da58 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -1,8 +1,9 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * Hardware monitoring driver for Intersil ISL68137
+ * Hardware monitoring driver for Renesas Digital Multiphase Voltage Regulators
  *
  * Copyright (c) 2017 Google Inc
+ * Copyright (c) 2020 Renesas Electronics America
  *
  */
 
@@ -14,9 +15,19 @@
 #include <linux/module.h>
 #include <linux/string.h>
 #include <linux/sysfs.h>
+
 #include "pmbus.h"
 
 #define ISL68137_VOUT_AVS	0x30
+#define RAA_DMPVR2_READ_VMON	0xc8
+
+enum versions {
+	isl68137,
+	raa_dmpvr2_1rail,
+	raa_dmpvr2_2rail,
+	raa_dmpvr2_3rail,
+	raa_dmpvr2_hv,
+};
 
 static ssize_t isl68137_avs_enable_show_page(struct i2c_client *client,
 					     int page,
@@ -98,13 +109,30 @@ static const struct attribute_group enable_group = {
 	.attrs = enable_attrs,
 };
 
-static const struct attribute_group *attribute_groups[] = {
+static const struct attribute_group *isl68137_attribute_groups[] = {
 	&enable_group,
 	NULL,
 };
 
-static struct pmbus_driver_info isl68137_info = {
-	.pages = 2,
+static int raa_dmpvr2_read_word_data(struct i2c_client *client, int page,
+				     int reg)
+{
+	int ret;
+
+	switch (reg) {
+	case PMBUS_VIRT_READ_VMON:
+		ret = pmbus_read_word_data(client, page, RAA_DMPVR2_READ_VMON);
+		break;
+	default:
+		ret = -ENODATA;
+		break;
+	}
+
+	return ret;
+}
+
+static struct pmbus_driver_info raa_dmpvr_info = {
+	.pages = 3,
 	.format[PSC_VOLTAGE_IN] = direct,
 	.format[PSC_VOLTAGE_OUT] = direct,
 	.format[PSC_CURRENT_IN] = direct,
@@ -113,7 +141,7 @@ static struct pmbus_driver_info isl68137_info = {
 	.format[PSC_TEMPERATURE] = direct,
 	.m[PSC_VOLTAGE_IN] = 1,
 	.b[PSC_VOLTAGE_IN] = 0,
-	.R[PSC_VOLTAGE_IN] = 3,
+	.R[PSC_VOLTAGE_IN] = 2,
 	.m[PSC_VOLTAGE_OUT] = 1,
 	.b[PSC_VOLTAGE_OUT] = 0,
 	.R[PSC_VOLTAGE_OUT] = 3,
@@ -133,24 +161,76 @@ static struct pmbus_driver_info isl68137_info = {
 	    | PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP2
 	    | PMBUS_HAVE_TEMP3 | PMBUS_HAVE_STATUS_TEMP
 	    | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT
-	    | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT,
-	.func[1] = PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT
-	    | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT,
-	.groups = attribute_groups,
+	    | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT
+		| PMBUS_HAVE_VMON,
+	.func[1] = PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT
+	    | PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP3 | PMBUS_HAVE_STATUS_TEMP
+	    | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | PMBUS_HAVE_IOUT
+	    | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT,
+	.func[2] = PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT
+	    | PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP3 | PMBUS_HAVE_STATUS_TEMP
+	    | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | PMBUS_HAVE_IOUT
+	    | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT,
 };
 
 static int isl68137_probe(struct i2c_client *client,
 			  const struct i2c_device_id *id)
 {
-	return pmbus_do_probe(client, id, &isl68137_info);
+	struct pmbus_driver_info *info;
+
+	info = devm_kzalloc(&client->dev, sizeof(*info), GFP_KERNEL);
+	if (!info)
+		return -ENOMEM;
+	memcpy(info, &raa_dmpvr_info, sizeof(*info));
+
+	switch (id->driver_data) {
+	case isl68137:
+		info->pages = 2;
+		info->R[PSC_VOLTAGE_IN] = 3;
+		info->func[0] &= ~PMBUS_HAVE_VMON;
+		info->func[1] = PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT
+		    | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT
+		    | PMBUS_HAVE_POUT;
+		info->groups = isl68137_attribute_groups;
+		break;
+	case raa_dmpvr2_1rail:
+		info->pages = 1;
+		info->read_word_data = raa_dmpvr2_read_word_data;
+		break;
+	case raa_dmpvr2_2rail:
+		info->pages = 2;
+		info->read_word_data = raa_dmpvr2_read_word_data;
+		break;
+	case raa_dmpvr2_3rail:
+		info->read_word_data = raa_dmpvr2_read_word_data;
+		break;
+	case raa_dmpvr2_hv:
+		info->pages = 1;
+		info->R[PSC_VOLTAGE_IN] = 1;
+		info->m[PSC_VOLTAGE_OUT] = 2;
+		info->R[PSC_VOLTAGE_OUT] = 2;
+		info->m[PSC_CURRENT_IN] = 2;
+		info->m[PSC_POWER] = 2;
+		info->R[PSC_POWER] = -1;
+		info->read_word_data = raa_dmpvr2_read_word_data;
+		break;
+	default:
+		return -ENODEV;
+	}
+
+	return pmbus_do_probe(client, id, info);
 }
 
-static const struct i2c_device_id isl68137_id[] = {
-	{"isl68137", 0},
+static const struct i2c_device_id raa_dmpvr_id[] = {
+	{"isl68137", isl68137},
+	{"raa_dmpvr2_1rail", raa_dmpvr2_1rail},
+	{"raa_dmpvr2_2rail", raa_dmpvr2_2rail},
+	{"raa_dmpvr2_3rail", raa_dmpvr2_3rail},
+	{"raa_dmpvr2_hv", raa_dmpvr2_hv},
 	{}
 };
 
-MODULE_DEVICE_TABLE(i2c, isl68137_id);
+MODULE_DEVICE_TABLE(i2c, raa_dmpvr_id);
 
 /* This is the driver that will be inserted */
 static struct i2c_driver isl68137_driver = {
@@ -159,11 +239,11 @@ static struct i2c_driver isl68137_driver = {
 		   },
 	.probe = isl68137_probe,
 	.remove = pmbus_do_remove,
-	.id_table = isl68137_id,
+	.id_table = raa_dmpvr_id,
 };
 
 module_i2c_driver(isl68137_driver);
 
 MODULE_AUTHOR("Maxim Sloyko <maxims@google.com>");
-MODULE_DESCRIPTION("PMBus driver for Intersil ISL68137");
+MODULE_DESCRIPTION("PMBus driver for Renesas digital multiphase voltage regulators");
 MODULE_LICENSE("GPL");
-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 2/2] docs: hwmon: Update documentation for isl68137 pmbus driver
  2020-03-20 16:15 [PATCH v3 0/2] hwmon: (pmbus) add support for Gen 2 Renesas digital multiphase Grant Peltier
  2020-03-20 16:16 ` [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen " Grant Peltier
@ 2020-03-20 16:16 ` Grant Peltier
  2020-03-21 22:10   ` Guenter Roeck
  1 sibling, 1 reply; 6+ messages in thread
From: Grant Peltier @ 2020-03-20 16:16 UTC (permalink / raw)
  To: linux, linux-hwmon, linux-kernel; +Cc: adam.vaughn.xh

Update documentation to include reference information for newly
supported 2nd generation Renesas digital multiphase voltage regulators.
Also update branding from Intersil to Renesas.

Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
---
 Documentation/hwmon/isl68137.rst | 541 ++++++++++++++++++++++++++++++-
 1 file changed, 533 insertions(+), 8 deletions(-)

diff --git a/Documentation/hwmon/isl68137.rst b/Documentation/hwmon/isl68137.rst
index a5a7c8545c9e..cc4b61447b63 100644
--- a/Documentation/hwmon/isl68137.rst
+++ b/Documentation/hwmon/isl68137.rst
@@ -3,7 +3,7 @@ Kernel driver isl68137
 
 Supported chips:
 
-  * Intersil ISL68137
+  * Renesas ISL68137
 
     Prefix: 'isl68137'
 
@@ -11,19 +11,405 @@ Supported chips:
 
     Datasheet:
 
-      Publicly available at the Intersil website
-      https://www.intersil.com/content/dam/Intersil/documents/isl6/isl68137.pdf
+      Publicly available at the Renesas website
+      https://www.renesas.com/us/en/www/doc/datasheet/isl68137.pdf
+
+  * Renesas ISL68220
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68221
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68222
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68223
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68224
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68225
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68226
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68227
+
+    Prefix: 'raa_dmpvr2_1rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68229
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68233
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL68239
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69222
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69223
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69224
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69225
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69227
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69228
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69234
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69236
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69239
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69242
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69243
+
+    Prefix: 'raa_dmpvr2_1rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69247
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69248
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69254
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69255
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69256
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69259
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69260
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69268
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69269
+
+    Prefix: 'raa_dmpvr2_3rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas ISL69298
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas RAA228000
+
+    Prefix: 'raa_dmpvr2_hv'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas RAA228004
+
+    Prefix: 'raa_dmpvr2_hv'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas RAA228006
+
+    Prefix: 'raa_dmpvr2_hv'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas RAA228228
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas RAA229001
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
+
+  * Renesas RAA229004
+
+    Prefix: 'raa_dmpvr2_2rail'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Publicly available (after August 2020 launch) at the Renesas website
 
 Authors:
       - Maxim Sloyko <maxims@google.com>
       - Robert Lippert <rlippert@google.com>
       - Patrick Venture <venture@google.com>
+      - Grant Peltier <grant.peltier.jg@renesas.com>
 
 Description
 -----------
 
-Intersil ISL68137 is a digital output 7-phase configurable PWM
-controller with an AVSBus interface.
+This driver supports the Renesas ISL68137 and all 2nd generation Renesas
+digital multiphase voltage regulators (raa_dmpvr2). The ISL68137 is a digital
+output 7-phase configurable PWM controller with an AVSBus interface. 2nd
+generation devices are grouped into 4 distinct configurations: '1rail' for
+single-rail devices, '2rail' for dual-rail devices, '3rail' for 3-rail devices,
+and 'hv' for high voltage single-rail devices. Consult the individual datasheets
+for more information.
 
 Usage Notes
 -----------
@@ -33,10 +419,14 @@ devices explicitly.
 
 The ISL68137 AVS operation mode must be enabled/disabled at runtime.
 
-Beyond the normal sysfs pmbus attributes, the driver exposes a control attribute.
+Beyond the normal sysfs pmbus attributes, the driver exposes a control attribute
+for the ISL68137.
+
+For 2nd generation Renesas digital multiphase voltage regulators, only the
+normal sysfs pmbus attributes are supported.
 
-Additional Sysfs attributes
----------------------------
+ISL68137 sysfs attributes
+-------------------------
 
 ======================= ====================================
 avs(0|1)_enable		Controls the AVS state of each rail.
@@ -78,3 +468,138 @@ temp[1-3]_crit_alarm	Chip temperature critical high alarm
 temp[1-3]_max		Maximum temperature
 temp[1-3]_max_alarm	Chip temperature high alarm
 ======================= ====================================
+
+raa_dmpvr2_1rail/hv sysfs attributes
+------------------------------------
+
+======================= ==========================================
+curr1_label		"iin"
+curr1_input		Measured input current
+curr1_crit		Critical maximum current
+curr1_crit_alarm	Current critical high alarm
+
+curr2_label		"iout"
+curr2_input		Measured output current
+curr2_crit		Critical maximum current
+curr2_crit_alarm	Current critical high alarm
+
+in1_label		"vin"
+in1_input		Measured input voltage
+in1_lcrit		Critical minimum input voltage
+in1_lcrit_alarm		Input voltage critical low alarm
+in1_crit		Critical maximum input voltage
+in1_crit_alarm		Input voltage critical high alarm
+
+in2_label		"vmon"
+in2_input		Scaled VMON voltage read from the VMON pin
+
+in3_label		"vout"
+in3_input		Measured output voltage
+in3_lcrit		Critical minimum output voltage
+in3_lcrit_alarm         Output voltage critical low alarm
+in3_crit		Critical maximum output voltage
+in3_crit_alarm          Output voltage critical high alarm
+
+power1_label		"pin"
+power1_input		Measured input power
+power1_alarm		Input power high alarm
+
+power2_label	        "pout"
+power2_input	        Measured output power
+
+temp[1-3]_input		Measured temperature
+temp[1-3]_crit		Critical high temperature
+temp[1-3]_crit_alarm	Chip temperature critical high alarm
+temp[1-3]_max		Maximum temperature
+temp[1-3]_max_alarm	Chip temperature high alarm
+======================= ==========================================
+
+raa_dmpvr2_2rail sysfs attributes
+---------------------------------
+
+======================= ==========================================
+curr[1-2]_label		"iin[1-2]"
+curr[1-2]_input		Measured input current
+curr[1-2]_crit		Critical maximum current
+curr[1-2]_crit_alarm	Current critical high alarm
+
+curr[3-4]_label		"iout[1-2]"
+curr[3-4]_input		Measured output current
+curr[3-4]_crit		Critical maximum current
+curr[3-4]_crit_alarm	Current critical high alarm
+
+in1_label		"vin"
+in1_input		Measured input voltage
+in1_lcrit		Critical minimum input voltage
+in1_lcrit_alarm		Input voltage critical low alarm
+in1_crit		Critical maximum input voltage
+in1_crit_alarm		Input voltage critical high alarm
+
+in2_label		"vmon"
+in2_input		Scaled VMON voltage read from the VMON pin
+
+in[3-4]_label		"vout[1-2]"
+in[3-4]_input		Measured output voltage
+in[3-4]_lcrit		Critical minimum output voltage
+in[3-4]_lcrit_alarm	Output voltage critical low alarm
+in[3-4]_crit		Critical maximum output voltage
+in[3-4]_crit_alarm	Output voltage critical high alarm
+
+power[1-2]_label	"pin[1-2]"
+power[1-2]_input	Measured input power
+power[1-2]_alarm	Input power high alarm
+
+power[3-4]_label	"pout[1-2]"
+power[3-4]_input	Measured output power
+
+temp[1-5]_input		Measured temperature
+temp[1-5]_crit		Critical high temperature
+temp[1-5]_crit_alarm	Chip temperature critical high alarm
+temp[1-5]_max		Maximum temperature
+temp[1-5]_max_alarm	Chip temperature high alarm
+======================= ==========================================
+
+raa_dmpvr2_3rail sysfs attributes
+---------------------------------
+
+======================= ==========================================
+curr[1-3]_label		"iin[1-3]"
+curr[1-3]_input		Measured input current
+curr[1-3]_crit		Critical maximum current
+curr[1-3]_crit_alarm	Current critical high alarm
+
+curr[4-6]_label		"iout[1-3]"
+curr[4-6]_input		Measured output current
+curr[4-6]_crit		Critical maximum current
+curr[4-6]_crit_alarm	Current critical high alarm
+
+in1_label		"vin"
+in1_input		Measured input voltage
+in1_lcrit		Critical minimum input voltage
+in1_lcrit_alarm		Input voltage critical low alarm
+in1_crit		Critical maximum input voltage
+in1_crit_alarm		Input voltage critical high alarm
+
+in2_label		"vmon"
+in2_input		Scaled VMON voltage read from the VMON pin
+
+in[3-5]_label		"vout[1-3]"
+in[3-5]_input		Measured output voltage
+in[3-5]_lcrit		Critical minimum output voltage
+in[3-5]_lcrit_alarm	Output voltage critical low alarm
+in[3-5]_crit		Critical maximum output voltage
+in[3-5]_crit_alarm	Output voltage critical high alarm
+
+power[1-3]_label	"pin[1-3]"
+power[1-3]_input	Measured input power
+power[1-3]_alarm	Input power high alarm
+
+power[4-6]_label	"pout[1-3]"
+power[4-6]_input	Measured output power
+
+temp[1-7]_input		Measured temperature
+temp[1-7]_crit		Critical high temperature
+temp[1-7]_crit_alarm	Chip temperature critical high alarm
+temp[1-7]_max		Maximum temperature
+temp[1-7]_max_alarm	Chip temperature high alarm
+======================= ==========================================
-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase
  2020-03-20 16:16 ` [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen " Grant Peltier
@ 2020-03-21 22:09   ` Guenter Roeck
  2020-04-01 16:39   ` Guenter Roeck
  1 sibling, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2020-03-21 22:09 UTC (permalink / raw)
  To: Grant Peltier; +Cc: linux-hwmon, linux-kernel, adam.vaughn.xh

On Fri, Mar 20, 2020 at 11:16:21AM -0500, Grant Peltier wrote:
> Extend the isl68137 driver to provide support for 2nd generation Renesas
> digital multiphase voltage regulators.
> 
> Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/Kconfig    |   6 +-
>  drivers/hwmon/pmbus/isl68137.c | 110 ++++++++++++++++++++++++++++-----
>  2 files changed, 98 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index a9ea06204767..1e3e5a61ed9c 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -92,10 +92,10 @@ config SENSORS_IRPS5401
>  	  be called irps5401.
>  
>  config SENSORS_ISL68137
> -	tristate "Intersil ISL68137"
> +	tristate "Renesas Digital Multiphase Voltage Regulators"
>  	help
> -	  If you say yes here you get hardware monitoring support for Intersil
> -	  ISL68137.
> +	  If you say yes here you get hardware monitoring support for Renesas
> +	  digital multiphase voltage regulators.
>  
>  	  This driver can also be built as a module. If so, the module will
>  	  be called isl68137.
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index 515596c92fe1..47f6cce1da58 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -1,8 +1,9 @@
>  // SPDX-License-Identifier: GPL-2.0+
>  /*
> - * Hardware monitoring driver for Intersil ISL68137
> + * Hardware monitoring driver for Renesas Digital Multiphase Voltage Regulators
>   *
>   * Copyright (c) 2017 Google Inc
> + * Copyright (c) 2020 Renesas Electronics America
>   *
>   */
>  
> @@ -14,9 +15,19 @@
>  #include <linux/module.h>
>  #include <linux/string.h>
>  #include <linux/sysfs.h>
> +
>  #include "pmbus.h"
>  
>  #define ISL68137_VOUT_AVS	0x30
> +#define RAA_DMPVR2_READ_VMON	0xc8
> +
> +enum versions {
> +	isl68137,
> +	raa_dmpvr2_1rail,
> +	raa_dmpvr2_2rail,
> +	raa_dmpvr2_3rail,
> +	raa_dmpvr2_hv,
> +};
>  
>  static ssize_t isl68137_avs_enable_show_page(struct i2c_client *client,
>  					     int page,
> @@ -98,13 +109,30 @@ static const struct attribute_group enable_group = {
>  	.attrs = enable_attrs,
>  };
>  
> -static const struct attribute_group *attribute_groups[] = {
> +static const struct attribute_group *isl68137_attribute_groups[] = {
>  	&enable_group,
>  	NULL,
>  };
>  
> -static struct pmbus_driver_info isl68137_info = {
> -	.pages = 2,
> +static int raa_dmpvr2_read_word_data(struct i2c_client *client, int page,
> +				     int reg)
> +{
> +	int ret;
> +
> +	switch (reg) {
> +	case PMBUS_VIRT_READ_VMON:
> +		ret = pmbus_read_word_data(client, page, RAA_DMPVR2_READ_VMON);
> +		break;
> +	default:
> +		ret = -ENODATA;
> +		break;
> +	}
> +
> +	return ret;
> +}
> +
> +static struct pmbus_driver_info raa_dmpvr_info = {
> +	.pages = 3,
>  	.format[PSC_VOLTAGE_IN] = direct,
>  	.format[PSC_VOLTAGE_OUT] = direct,
>  	.format[PSC_CURRENT_IN] = direct,
> @@ -113,7 +141,7 @@ static struct pmbus_driver_info isl68137_info = {
>  	.format[PSC_TEMPERATURE] = direct,
>  	.m[PSC_VOLTAGE_IN] = 1,
>  	.b[PSC_VOLTAGE_IN] = 0,
> -	.R[PSC_VOLTAGE_IN] = 3,
> +	.R[PSC_VOLTAGE_IN] = 2,
>  	.m[PSC_VOLTAGE_OUT] = 1,
>  	.b[PSC_VOLTAGE_OUT] = 0,
>  	.R[PSC_VOLTAGE_OUT] = 3,
> @@ -133,24 +161,76 @@ static struct pmbus_driver_info isl68137_info = {
>  	    | PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP2
>  	    | PMBUS_HAVE_TEMP3 | PMBUS_HAVE_STATUS_TEMP
>  	    | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT
> -	    | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT,
> -	.func[1] = PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT
> -	    | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT,
> -	.groups = attribute_groups,
> +	    | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT
> +		| PMBUS_HAVE_VMON,
> +	.func[1] = PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT
> +	    | PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP3 | PMBUS_HAVE_STATUS_TEMP
> +	    | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | PMBUS_HAVE_IOUT
> +	    | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT,
> +	.func[2] = PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT
> +	    | PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP3 | PMBUS_HAVE_STATUS_TEMP
> +	    | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | PMBUS_HAVE_IOUT
> +	    | PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_POUT,
>  };
>  
>  static int isl68137_probe(struct i2c_client *client,
>  			  const struct i2c_device_id *id)
>  {
> -	return pmbus_do_probe(client, id, &isl68137_info);
> +	struct pmbus_driver_info *info;
> +
> +	info = devm_kzalloc(&client->dev, sizeof(*info), GFP_KERNEL);
> +	if (!info)
> +		return -ENOMEM;
> +	memcpy(info, &raa_dmpvr_info, sizeof(*info));
> +
> +	switch (id->driver_data) {
> +	case isl68137:
> +		info->pages = 2;
> +		info->R[PSC_VOLTAGE_IN] = 3;
> +		info->func[0] &= ~PMBUS_HAVE_VMON;
> +		info->func[1] = PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT
> +		    | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT
> +		    | PMBUS_HAVE_POUT;
> +		info->groups = isl68137_attribute_groups;
> +		break;
> +	case raa_dmpvr2_1rail:
> +		info->pages = 1;
> +		info->read_word_data = raa_dmpvr2_read_word_data;
> +		break;
> +	case raa_dmpvr2_2rail:
> +		info->pages = 2;
> +		info->read_word_data = raa_dmpvr2_read_word_data;
> +		break;
> +	case raa_dmpvr2_3rail:
> +		info->read_word_data = raa_dmpvr2_read_word_data;
> +		break;
> +	case raa_dmpvr2_hv:
> +		info->pages = 1;
> +		info->R[PSC_VOLTAGE_IN] = 1;
> +		info->m[PSC_VOLTAGE_OUT] = 2;
> +		info->R[PSC_VOLTAGE_OUT] = 2;
> +		info->m[PSC_CURRENT_IN] = 2;
> +		info->m[PSC_POWER] = 2;
> +		info->R[PSC_POWER] = -1;
> +		info->read_word_data = raa_dmpvr2_read_word_data;
> +		break;
> +	default:
> +		return -ENODEV;
> +	}
> +
> +	return pmbus_do_probe(client, id, info);
>  }
>  
> -static const struct i2c_device_id isl68137_id[] = {
> -	{"isl68137", 0},
> +static const struct i2c_device_id raa_dmpvr_id[] = {
> +	{"isl68137", isl68137},
> +	{"raa_dmpvr2_1rail", raa_dmpvr2_1rail},
> +	{"raa_dmpvr2_2rail", raa_dmpvr2_2rail},
> +	{"raa_dmpvr2_3rail", raa_dmpvr2_3rail},
> +	{"raa_dmpvr2_hv", raa_dmpvr2_hv},
>  	{}
>  };
>  
> -MODULE_DEVICE_TABLE(i2c, isl68137_id);
> +MODULE_DEVICE_TABLE(i2c, raa_dmpvr_id);
>  
>  /* This is the driver that will be inserted */
>  static struct i2c_driver isl68137_driver = {
> @@ -159,11 +239,11 @@ static struct i2c_driver isl68137_driver = {
>  		   },
>  	.probe = isl68137_probe,
>  	.remove = pmbus_do_remove,
> -	.id_table = isl68137_id,
> +	.id_table = raa_dmpvr_id,
>  };
>  
>  module_i2c_driver(isl68137_driver);
>  
>  MODULE_AUTHOR("Maxim Sloyko <maxims@google.com>");
> -MODULE_DESCRIPTION("PMBus driver for Intersil ISL68137");
> +MODULE_DESCRIPTION("PMBus driver for Renesas digital multiphase voltage regulators");
>  MODULE_LICENSE("GPL");

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] docs: hwmon: Update documentation for isl68137 pmbus driver
  2020-03-20 16:16 ` [PATCH v3 2/2] docs: hwmon: Update documentation for isl68137 pmbus driver Grant Peltier
@ 2020-03-21 22:10   ` Guenter Roeck
  0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2020-03-21 22:10 UTC (permalink / raw)
  To: Grant Peltier; +Cc: linux-hwmon, linux-kernel, adam.vaughn.xh

On Fri, Mar 20, 2020 at 11:16:47AM -0500, Grant Peltier wrote:
> Update documentation to include reference information for newly
> supported 2nd generation Renesas digital multiphase voltage regulators.
> Also update branding from Intersil to Renesas.
> 
> Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  Documentation/hwmon/isl68137.rst | 541 ++++++++++++++++++++++++++++++-
>  1 file changed, 533 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/hwmon/isl68137.rst b/Documentation/hwmon/isl68137.rst
> index a5a7c8545c9e..cc4b61447b63 100644
> --- a/Documentation/hwmon/isl68137.rst
> +++ b/Documentation/hwmon/isl68137.rst
> @@ -3,7 +3,7 @@ Kernel driver isl68137
>  
>  Supported chips:
>  
> -  * Intersil ISL68137
> +  * Renesas ISL68137
>  
>      Prefix: 'isl68137'
>  
> @@ -11,19 +11,405 @@ Supported chips:
>  
>      Datasheet:
>  
> -      Publicly available at the Intersil website
> -      https://www.intersil.com/content/dam/Intersil/documents/isl6/isl68137.pdf
> +      Publicly available at the Renesas website
> +      https://www.renesas.com/us/en/www/doc/datasheet/isl68137.pdf
> +
> +  * Renesas ISL68220
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68221
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68222
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68223
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68224
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68225
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68226
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68227
> +
> +    Prefix: 'raa_dmpvr2_1rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68229
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68233
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL68239
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69222
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69223
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69224
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69225
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69227
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69228
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69234
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69236
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69239
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69242
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69243
> +
> +    Prefix: 'raa_dmpvr2_1rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69247
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69248
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69254
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69255
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69256
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69259
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69260
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69268
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69269
> +
> +    Prefix: 'raa_dmpvr2_3rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas ISL69298
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas RAA228000
> +
> +    Prefix: 'raa_dmpvr2_hv'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas RAA228004
> +
> +    Prefix: 'raa_dmpvr2_hv'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas RAA228006
> +
> +    Prefix: 'raa_dmpvr2_hv'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas RAA228228
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas RAA229001
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
> +
> +  * Renesas RAA229004
> +
> +    Prefix: 'raa_dmpvr2_2rail'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Publicly available (after August 2020 launch) at the Renesas website
>  
>  Authors:
>        - Maxim Sloyko <maxims@google.com>
>        - Robert Lippert <rlippert@google.com>
>        - Patrick Venture <venture@google.com>
> +      - Grant Peltier <grant.peltier.jg@renesas.com>
>  
>  Description
>  -----------
>  
> -Intersil ISL68137 is a digital output 7-phase configurable PWM
> -controller with an AVSBus interface.
> +This driver supports the Renesas ISL68137 and all 2nd generation Renesas
> +digital multiphase voltage regulators (raa_dmpvr2). The ISL68137 is a digital
> +output 7-phase configurable PWM controller with an AVSBus interface. 2nd
> +generation devices are grouped into 4 distinct configurations: '1rail' for
> +single-rail devices, '2rail' for dual-rail devices, '3rail' for 3-rail devices,
> +and 'hv' for high voltage single-rail devices. Consult the individual datasheets
> +for more information.
>  
>  Usage Notes
>  -----------
> @@ -33,10 +419,14 @@ devices explicitly.
>  
>  The ISL68137 AVS operation mode must be enabled/disabled at runtime.
>  
> -Beyond the normal sysfs pmbus attributes, the driver exposes a control attribute.
> +Beyond the normal sysfs pmbus attributes, the driver exposes a control attribute
> +for the ISL68137.
> +
> +For 2nd generation Renesas digital multiphase voltage regulators, only the
> +normal sysfs pmbus attributes are supported.
>  
> -Additional Sysfs attributes
> ----------------------------
> +ISL68137 sysfs attributes
> +-------------------------
>  
>  ======================= ====================================
>  avs(0|1)_enable		Controls the AVS state of each rail.
> @@ -78,3 +468,138 @@ temp[1-3]_crit_alarm	Chip temperature critical high alarm
>  temp[1-3]_max		Maximum temperature
>  temp[1-3]_max_alarm	Chip temperature high alarm
>  ======================= ====================================
> +
> +raa_dmpvr2_1rail/hv sysfs attributes
> +------------------------------------
> +
> +======================= ==========================================
> +curr1_label		"iin"
> +curr1_input		Measured input current
> +curr1_crit		Critical maximum current
> +curr1_crit_alarm	Current critical high alarm
> +
> +curr2_label		"iout"
> +curr2_input		Measured output current
> +curr2_crit		Critical maximum current
> +curr2_crit_alarm	Current critical high alarm
> +
> +in1_label		"vin"
> +in1_input		Measured input voltage
> +in1_lcrit		Critical minimum input voltage
> +in1_lcrit_alarm		Input voltage critical low alarm
> +in1_crit		Critical maximum input voltage
> +in1_crit_alarm		Input voltage critical high alarm
> +
> +in2_label		"vmon"
> +in2_input		Scaled VMON voltage read from the VMON pin
> +
> +in3_label		"vout"
> +in3_input		Measured output voltage
> +in3_lcrit		Critical minimum output voltage
> +in3_lcrit_alarm         Output voltage critical low alarm
> +in3_crit		Critical maximum output voltage
> +in3_crit_alarm          Output voltage critical high alarm
> +
> +power1_label		"pin"
> +power1_input		Measured input power
> +power1_alarm		Input power high alarm
> +
> +power2_label	        "pout"
> +power2_input	        Measured output power
> +
> +temp[1-3]_input		Measured temperature
> +temp[1-3]_crit		Critical high temperature
> +temp[1-3]_crit_alarm	Chip temperature critical high alarm
> +temp[1-3]_max		Maximum temperature
> +temp[1-3]_max_alarm	Chip temperature high alarm
> +======================= ==========================================
> +
> +raa_dmpvr2_2rail sysfs attributes
> +---------------------------------
> +
> +======================= ==========================================
> +curr[1-2]_label		"iin[1-2]"
> +curr[1-2]_input		Measured input current
> +curr[1-2]_crit		Critical maximum current
> +curr[1-2]_crit_alarm	Current critical high alarm
> +
> +curr[3-4]_label		"iout[1-2]"
> +curr[3-4]_input		Measured output current
> +curr[3-4]_crit		Critical maximum current
> +curr[3-4]_crit_alarm	Current critical high alarm
> +
> +in1_label		"vin"
> +in1_input		Measured input voltage
> +in1_lcrit		Critical minimum input voltage
> +in1_lcrit_alarm		Input voltage critical low alarm
> +in1_crit		Critical maximum input voltage
> +in1_crit_alarm		Input voltage critical high alarm
> +
> +in2_label		"vmon"
> +in2_input		Scaled VMON voltage read from the VMON pin
> +
> +in[3-4]_label		"vout[1-2]"
> +in[3-4]_input		Measured output voltage
> +in[3-4]_lcrit		Critical minimum output voltage
> +in[3-4]_lcrit_alarm	Output voltage critical low alarm
> +in[3-4]_crit		Critical maximum output voltage
> +in[3-4]_crit_alarm	Output voltage critical high alarm
> +
> +power[1-2]_label	"pin[1-2]"
> +power[1-2]_input	Measured input power
> +power[1-2]_alarm	Input power high alarm
> +
> +power[3-4]_label	"pout[1-2]"
> +power[3-4]_input	Measured output power
> +
> +temp[1-5]_input		Measured temperature
> +temp[1-5]_crit		Critical high temperature
> +temp[1-5]_crit_alarm	Chip temperature critical high alarm
> +temp[1-5]_max		Maximum temperature
> +temp[1-5]_max_alarm	Chip temperature high alarm
> +======================= ==========================================
> +
> +raa_dmpvr2_3rail sysfs attributes
> +---------------------------------
> +
> +======================= ==========================================
> +curr[1-3]_label		"iin[1-3]"
> +curr[1-3]_input		Measured input current
> +curr[1-3]_crit		Critical maximum current
> +curr[1-3]_crit_alarm	Current critical high alarm
> +
> +curr[4-6]_label		"iout[1-3]"
> +curr[4-6]_input		Measured output current
> +curr[4-6]_crit		Critical maximum current
> +curr[4-6]_crit_alarm	Current critical high alarm
> +
> +in1_label		"vin"
> +in1_input		Measured input voltage
> +in1_lcrit		Critical minimum input voltage
> +in1_lcrit_alarm		Input voltage critical low alarm
> +in1_crit		Critical maximum input voltage
> +in1_crit_alarm		Input voltage critical high alarm
> +
> +in2_label		"vmon"
> +in2_input		Scaled VMON voltage read from the VMON pin
> +
> +in[3-5]_label		"vout[1-3]"
> +in[3-5]_input		Measured output voltage
> +in[3-5]_lcrit		Critical minimum output voltage
> +in[3-5]_lcrit_alarm	Output voltage critical low alarm
> +in[3-5]_crit		Critical maximum output voltage
> +in[3-5]_crit_alarm	Output voltage critical high alarm
> +
> +power[1-3]_label	"pin[1-3]"
> +power[1-3]_input	Measured input power
> +power[1-3]_alarm	Input power high alarm
> +
> +power[4-6]_label	"pout[1-3]"
> +power[4-6]_input	Measured output power
> +
> +temp[1-7]_input		Measured temperature
> +temp[1-7]_crit		Critical high temperature
> +temp[1-7]_crit_alarm	Chip temperature critical high alarm
> +temp[1-7]_max		Maximum temperature
> +temp[1-7]_max_alarm	Chip temperature high alarm
> +======================= ==========================================

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase
  2020-03-20 16:16 ` [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen " Grant Peltier
  2020-03-21 22:09   ` Guenter Roeck
@ 2020-04-01 16:39   ` Guenter Roeck
  1 sibling, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2020-04-01 16:39 UTC (permalink / raw)
  To: Grant Peltier; +Cc: linux-hwmon, linux-kernel, adam.vaughn.xh

On Fri, Mar 20, 2020 at 11:16:21AM -0500, Grant Peltier wrote:
> Extend the isl68137 driver to provide support for 2nd generation Renesas
> digital multiphase voltage regulators.
> 
> Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
> ---
[ ... ]

>  
> -static const struct i2c_device_id isl68137_id[] = {
> -	{"isl68137", 0},
> +static const struct i2c_device_id raa_dmpvr_id[] = {
> +	{"isl68137", isl68137},
> +	{"raa_dmpvr2_1rail", raa_dmpvr2_1rail},
> +	{"raa_dmpvr2_2rail", raa_dmpvr2_2rail},
> +	{"raa_dmpvr2_3rail", raa_dmpvr2_3rail},
> +	{"raa_dmpvr2_hv", raa_dmpvr2_hv},
>  	{}

I clearly didn't pay attention. I2C device IDs need to match chip names,
not functionality. Unfortunately I only realized that when I wrote the
pull request, and I didn't want to drop the patch. I'll send a fixup
patch later.

Guenter

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 16:15 [PATCH v3 0/2] hwmon: (pmbus) add support for Gen 2 Renesas digital multiphase Grant Peltier
2020-03-20 16:16 ` [PATCH v3 1/2] hwmon: (pmbus) add support for 2nd Gen " Grant Peltier
2020-03-21 22:09   ` Guenter Roeck
2020-04-01 16:39   ` Guenter Roeck
2020-03-20 16:16 ` [PATCH v3 2/2] docs: hwmon: Update documentation for isl68137 pmbus driver Grant Peltier
2020-03-21 22:10   ` Guenter Roeck

Linux-Hwmon Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-hwmon/0 linux-hwmon/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hwmon linux-hwmon/ https://lore.kernel.org/linux-hwmon \
		linux-hwmon@vger.kernel.org
	public-inbox-index linux-hwmon

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-hwmon


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git