* [PATCH v2 00/10] Add per channel properies support in tmp421
@ 2021-09-23 14:00 Krzysztof Adamski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Adamski @ 2021-09-23 14:00 UTC (permalink / raw)
To: Guenter Roeck, Jean Delvare
Cc: Rob Herring, linux-hwmon, devicetree, Przemyslaw Cencner
Hi,
This series adds support for defining per-channel properies (like
n-factor and label) to the TMP421 driver. It starts by adding the
missing DT binding for tmp421, in the form that was there before any of
my changes. Then I do the changes to the driver and finally adjust the
bindings to my changes.
The precedence for this case is:
[PATCH v9 2/2] hwmon: (ina3221) Read channel input source info from DT
Which can be found here:
https://lkml.org/lkml/2018/10/2/136
My patches does similar thing but to tmp422 - we need a way to define
the labels for specific channels as well as to define the n-factor (that
is board specific as it depends on the diodes used for remote sensing).
A possibility to disable unused channels seems like a good idea too.
Here comes V2. Changes compared to v1:
- fixed sparse warnings about making function declarations static
- changed the policy for broken DT - in case of errors, the probe will
return an error instead of continuing
- in addition to disabling the channels specified in DT, the probe
function will also enable all the others in case they were disabled by
some other code earlier
NOTE: this may be a backwards incompatible change - if some channels
were disabled by some bootloader code previously the channels would
stay like that and now they would be enabled during probe, even if
nothing is specified in DT. Is this what we want?
- added support for HWMON_T_ENABLE
- updated documentation
- NOTE: I haven't changed anything related to DT as the discussion has
no clear conclusion yet.
Krzysztof Adamski (10):
dt-bindings: hwmon: add missing tmp421 binding
hwmon: (tmp421) introduce MAX_CHANNELS define
hwmon: (tmp421) introduce a channel struct
hwmon: (tmp421) add support for defining labels from DT
hwmon: (tmp421) support disabling channels from DT
hwmon: (tmp421) support specifying n-factor via DT
hwmon: (tmp421) really disable channels
hwmon: (tmp421) support HWMON_T_ENABLE
dt-bindings: hwmon: allow specifying channels for tmp421
hwmon: (tmp421) update documentation
.../devicetree/bindings/hwmon/tmp421.yaml | 109 +++++++++++
Documentation/hwmon/tmp421.rst | 10 +
drivers/hwmon/tmp421.c | 172 ++++++++++++++++--
3 files changed, 280 insertions(+), 11 deletions(-)
create mode 100644 Documentation/devicetree/bindings/hwmon/tmp421.yaml
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 00/10] Add per channel properies support in tmp421
@ 2021-09-24 9:36 Krzysztof Adamski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Adamski @ 2021-09-24 9:36 UTC (permalink / raw)
To: Guenter Roeck, Jean Delvare
Cc: Rob Herring, linux-hwmon, devicetree, Przemyslaw Cencner
Hi,
This series adds support for defining per-channel properies (like
n-factor and label) to the TMP421 driver. It starts by adding the
missing DT binding for tmp421, in the form that was there before any of
my changes. Then I do the changes to the driver and finally adjust the
bindings to my changes.
The precedence for this case is:
[PATCH v9 2/2] hwmon: (ina3221) Read channel input source info from DT
Which can be found here:
https://lkml.org/lkml/2018/10/2/136
My patches does similar thing but to tmp422 - we need a way to define
the labels for specific channels as well as to define the n-factor (that
is board specific as it depends on the diodes used for remote sensing).
A possibility to disable unused channels seems like a good idea too.
Here comes V2. Changes compared to v1:
- renamed tmp421.yaml to ti,tmp421.yaml
- fixed sparse warnings about making function declarations static
- changed the policy for broken DT - in case of errors, the probe will
return an error instead of continuing
- in addition to disabling the channels specified in DT, the probe
function will also enable all the others in case they were disabled by
some other code earlier
NOTE: this may be a backwards incompatible change - if some channels
were disabled by some bootloader code previously the channels would
stay like that and now they would be enabled during probe, even if
nothing is specified in DT. Is this what we want?
- added support for HWMON_T_ENABLE
- updated documentation
- NOTE: I haven't changed anything related to DT as the discussion has
no clear conclusion yet.
Krzysztof Adamski (10):
dt-bindings: hwmon: add missing tmp421 binding
hwmon: (tmp421) introduce MAX_CHANNELS define
hwmon: (tmp421) introduce a channel struct
hwmon: (tmp421) add support for defining labels from DT
hwmon: (tmp421) support disabling channels from DT
hwmon: (tmp421) support specifying n-factor via DT
hwmon: (tmp421) really disable channels
hwmon: (tmp421) support HWMON_T_ENABLE
hwmon: (tmp421) update documentation
dt-bindings: hwmon: allow specifying channels for tmp421
.../devicetree/bindings/hwmon/ti,tmp421.yaml | 109 +++++++++++
Documentation/hwmon/tmp421.rst | 10 +
drivers/hwmon/tmp421.c | 172 ++++++++++++++++--
3 files changed, 280 insertions(+), 11 deletions(-)
create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-24 9:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-23 14:00 [PATCH v2 00/10] Add per channel properies support in tmp421 Krzysztof Adamski
2021-09-24 9:36 Krzysztof Adamski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).