* [PATCH net] net: mana: Add rmb after checking owner bits
@ 2022-09-11 20:40 Haiyang Zhang
2022-09-12 21:59 ` Dexuan Cui
2022-09-20 1:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Haiyang Zhang @ 2022-09-11 20:40 UTC (permalink / raw)
To: linux-hyperv, netdev
Cc: haiyangz, decui, kys, sthemmin, paulros, shacharr, olaf,
vkuznets, davem, linux-kernel, stable
Per GDMA spec, rmb is necessary after checking owner_bits, before
reading EQ or CQ entries.
Add rmb in these two places to comply with the specs.
Cc: stable@vger.kernel.org
Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
Reported-by: Sinan Kaya <Sinan.Kaya@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/net/ethernet/microsoft/mana/gdma_main.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c
index 5f9240182351..e10b9f8f89e1 100644
--- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
+++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
@@ -397,6 +397,11 @@ static void mana_gd_process_eq_events(void *arg)
break;
}
+ /* Per GDMA spec, rmb is necessary after checking owner_bits, before
+ * reading eqe.
+ */
+ rmb();
+
mana_gd_process_eqe(eq);
eq->head++;
@@ -1134,6 +1139,11 @@ static int mana_gd_read_cqe(struct gdma_queue *cq, struct gdma_comp *comp)
if (WARN_ON_ONCE(owner_bits != new_bits))
return -1;
+ /* Per GDMA spec, rmb is necessary after checking owner_bits, before
+ * reading completion info
+ */
+ rmb();
+
comp->wq_num = cqe->cqe_info.wq_num;
comp->is_sq = cqe->cqe_info.is_sq;
memcpy(comp->cqe_data, cqe->cqe_data, GDMA_COMP_DATA_SIZE);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net] net: mana: Add rmb after checking owner bits
2022-09-11 20:40 [PATCH net] net: mana: Add rmb after checking owner bits Haiyang Zhang
@ 2022-09-12 21:59 ` Dexuan Cui
2022-09-20 1:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Dexuan Cui @ 2022-09-12 21:59 UTC (permalink / raw)
To: Haiyang Zhang, linux-hyperv, netdev
Cc: KY Srinivasan, Stephen Hemminger, Paul Rosswurm, Shachar Raindel,
olaf, vkuznets, davem, linux-kernel, stable
> From: LKML haiyangz <lkmlhyz@microsoft.com> On Behalf Of Haiyang Zhang
> Sent: Sunday, September 11, 2022 1:40 PM
> ...
> Per GDMA spec, rmb is necessary after checking owner_bits, before
> reading EQ or CQ entries.
>
> Add rmb in these two places to comply with the specs.
>
> Cc: stable@vger.kernel.org
> Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network
> Adapter (MANA)")
> Reported-by: Sinan Kaya <Sinan.Kaya@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: mana: Add rmb after checking owner bits
2022-09-11 20:40 [PATCH net] net: mana: Add rmb after checking owner bits Haiyang Zhang
2022-09-12 21:59 ` Dexuan Cui
@ 2022-09-20 1:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-20 1:00 UTC (permalink / raw)
To: Haiyang Zhang
Cc: linux-hyperv, netdev, decui, kys, sthemmin, paulros, shacharr,
olaf, vkuznets, davem, linux-kernel, stable
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 11 Sep 2022 13:40:05 -0700 you wrote:
> Per GDMA spec, rmb is necessary after checking owner_bits, before
> reading EQ or CQ entries.
>
> Add rmb in these two places to comply with the specs.
>
> Cc: stable@vger.kernel.org
> Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
> Reported-by: Sinan Kaya <Sinan.Kaya@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
>
> [...]
Here is the summary with links:
- [net] net: mana: Add rmb after checking owner bits
https://git.kernel.org/netdev/net/c/6fd2c68da55c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-20 1:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-11 20:40 [PATCH net] net: mana: Add rmb after checking owner bits Haiyang Zhang
2022-09-12 21:59 ` Dexuan Cui
2022-09-20 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).