From: Wei Liu <wei.liu@kernel.org>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Andres Beltran <t-mabelt@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
"parri.andrea@gmail.com" <parri.andrea@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening
Date: Mon, 29 Jun 2020 22:26:12 +0000 [thread overview]
Message-ID: <20200629222612.pxbuuifod6tyudfu@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <BL0PR2101MB0930DB73E3B5A89DD3E55481CA6E0@BL0PR2101MB0930.namprd21.prod.outlook.com>
On Mon, Jun 29, 2020 at 09:33:15PM +0000, Haiyang Zhang wrote:
>
>
> > -----Original Message-----
> > From: Andres Beltran <lkmlabelt@gmail.com>
> > Sent: Monday, June 29, 2020 4:02 PM
> > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> > wei.liu@kernel.org
> > Cc: linux-hyperv@vger.kernel.org; linux-kernel@vger.kernel.org; Michael
> > Kelley <mikelley@microsoft.com>; parri.andrea@gmail.com; Andres Beltran
> > <lkmlabelt@gmail.com>; David S . Miller <davem@davemloft.net>; Jakub
> > Kicinski <kuba@kernel.org>; netdev@vger.kernel.org
> > Subject: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate
> > transaction IDs for VMBus hardening
> >
> > Currently, pointers to guest memory are passed to Hyper-V as
> > transaction IDs in netvsc. In the face of errors or malicious
> > behavior in Hyper-V, netvsc should not expose or trust the transaction
> > IDs returned by Hyper-V to be valid guest memory addresses. Instead,
> > use small integers generated by vmbus_requestor as requests
> > (transaction) IDs.
> >
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Andres Beltran <lkmlabelt@gmail.com>
>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
>
>
Thanks Haiyang for reviewing.
David and Jakub:
This patch depends on the first patch. I intend to pick up this patch
via hyperv.git. This makes life easier for all of us. Let me know if you
disagree.
Wei.
prev parent reply other threads:[~2020-06-29 22:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 20:02 [PATCH v2 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening Andres Beltran
2020-06-29 20:02 ` [PATCH v2 1/3] Drivers: hv: vmbus: Add " Andres Beltran
2020-06-29 20:46 ` Wei Liu
2020-06-29 21:51 ` Andres Beltran
2020-06-29 21:56 ` Michael Kelley
2020-06-29 22:09 ` Andres Beltran
2020-06-29 22:15 ` Wei Liu
2020-06-29 22:20 ` Wei Liu
2020-06-29 23:45 ` Andres Beltran
2020-06-30 10:09 ` Wei Liu
2020-06-30 10:17 ` Wei Liu
2020-06-30 10:48 ` Wei Liu
2020-06-29 20:02 ` [PATCH v2 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs " Andres Beltran
2020-06-29 20:02 ` [PATCH v2 3/3] hv_netvsc: " Andres Beltran
2020-06-29 21:33 ` Haiyang Zhang
2020-06-29 22:26 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629222612.pxbuuifod6tyudfu@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=sthemmin@microsoft.com \
--cc=t-mabelt@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).