From: Jakub Kicinski <kuba@kernel.org>
To: Chi Song <chisong@microsoft.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 net-next] net: hyperv: dump TX indirection table to ethtool regs
Date: Thu, 23 Jul 2020 10:08:43 -0700 [thread overview]
Message-ID: <20200723100843.5c7dc128@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <alpine.LRH.2.23.451.2007222356070.2641@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.inter>
On Wed, 22 Jul 2020 23:59:09 -0700 (PDT) Chi Song wrote:
> An imbalanced TX indirection table causes netvsc to have low
> performance. This table is created and managed during runtime. To help
> better diagnose performance issues caused by imbalanced tables, it needs
> make TX indirection tables visible.
>
> Because TX indirection table is driver specified information, so
> display it via ethtool register dump.
>
> Signed-off-by: Chi Song <chisong@microsoft.com>
The patch looks good to me, but it has been corrupted by your email
client, could you perhaps try git send-email?
> + memcpy(regs_buff, ndc->tx_table, VRSS_SEND_TAB_SIZE *
> sizeof(u32));
next prev parent reply other threads:[~2020-07-23 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 6:59 [PATCH v7 net-next] net: hyperv: dump TX indirection table to ethtool regs Chi Song
2020-07-23 17:08 ` Jakub Kicinski [this message]
2020-07-23 19:35 ` Michal Kubecek
2020-07-23 19:55 ` Haiyang Zhang
2020-07-23 20:22 ` Michal Kubecek
2020-07-24 4:14 ` [PATCH v8 " Chi Song
2020-07-24 15:28 ` Haiyang Zhang
2020-07-24 22:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723100843.5c7dc128@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=chisong@microsoft.com \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).