linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: Chi Song <chisong@microsoft.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 net-next] net: hyperv: dump TX indirection table to ethtool regs
Date: Thu, 23 Jul 2020 21:35:42 +0200	[thread overview]
Message-ID: <20200723193542.6vwu4cbokbihw3nh@lion.mk-sys.cz> (raw)
In-Reply-To: <alpine.LRH.2.23.451.2007222356070.2641@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.inter>

On Wed, Jul 22, 2020 at 11:59:09PM -0700, Chi Song wrote:
> An imbalanced TX indirection table causes netvsc to have low
> performance. This table is created and managed during runtime. To help
> better diagnose performance issues caused by imbalanced tables, it needs
> make TX indirection tables visible.
> 
> Because TX indirection table is driver specified information, so
> display it via ethtool register dump.

Is the Tx indirection table really unique to netvsc or can we expect
other drivers to support similar feature? Also, would it make sense to
allow also setting the table with ethtool? (AFAICS it can be only set
from hypervisor at the moment.)

It kind of feels that the actual reason for using register dump was that
it's there and it was easy to use rather than that the information would
logically belong there. We already have a specific interface for getting
and seting receive indirection table; perhaps it would make sense to
have also one for the transmit indirection table.

Michal

  parent reply	other threads:[~2020-07-23 19:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  6:59 [PATCH v7 net-next] net: hyperv: dump TX indirection table to ethtool regs Chi Song
2020-07-23 17:08 ` Jakub Kicinski
2020-07-23 19:35 ` Michal Kubecek [this message]
2020-07-23 19:55   ` Haiyang Zhang
2020-07-23 20:22     ` Michal Kubecek
2020-07-24  4:14 ` [PATCH v8 " Chi Song
2020-07-24 15:28   ` Haiyang Zhang
2020-07-24 22:18   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723193542.6vwu4cbokbihw3nh@lion.mk-sys.cz \
    --to=mkubecek@suse.cz \
    --cc=chisong@microsoft.com \
    --cc=davem@davemloft.net \
    --cc=haiyangz@microsoft.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).