* [PATCH AUTOSEL 4.14 40/66] hv_netvsc: Validate number of allocated sub-channels [not found] <20201223022253.2793452-1-sashal@kernel.org> @ 2020-12-23 2:22 ` Sasha Levin 2020-12-23 2:47 ` Michael Kelley 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2020-12-23 2:22 UTC (permalink / raw) To: linux-kernel, stable Cc: Andrea Parri (Microsoft), Saruhan Karademir, Haiyang Zhang, Jakub Kicinski, David S. Miller, netdev, Wei Liu, Sasha Levin, linux-hyperv From: "Andrea Parri (Microsoft)" <parri.andrea@gmail.com> [ Upstream commit 206ad34d52a2f1205c84d08c12fc116aad0eb407 ] Lack of validation could lead to out-of-bound reads and information leaks (cf. usage of nvdev->chan_table[]). Check that the number of allocated sub-channels fits into the expected range. Suggested-by: Saruhan Karademir <skarade@microsoft.com> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> Acked-by: Jakub Kicinski <kuba@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: netdev@vger.kernel.org Link: https://lore.kernel.org/r/20201118153310.112404-1-parri.andrea@gmail.com Signed-off-by: Wei Liu <wei.liu@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/net/hyperv/rndis_filter.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index aa0bbffe49005..1db34b7a423ef 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -1100,6 +1100,11 @@ int rndis_set_subchannel(struct net_device *ndev, struct netvsc_device *nvdev) return -EIO; } + /* Check that number of allocated sub channel is within the expected range */ + if (init_packet->msg.v5_msg.subchn_comp.num_subchannels > nvdev->num_chn - 1) { + netdev_err(ndev, "invalid number of allocated sub channel\n"); + return -EINVAL; + } nvdev->num_chn = 1 + init_packet->msg.v5_msg.subchn_comp.num_subchannels; -- 2.27.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH AUTOSEL 4.14 40/66] hv_netvsc: Validate number of allocated sub-channels 2020-12-23 2:22 ` [PATCH AUTOSEL 4.14 40/66] hv_netvsc: Validate number of allocated sub-channels Sasha Levin @ 2020-12-23 2:47 ` Michael Kelley 2020-12-23 8:59 ` Andrea Parri 0 siblings, 1 reply; 4+ messages in thread From: Michael Kelley @ 2020-12-23 2:47 UTC (permalink / raw) To: Sasha Levin, linux-kernel, stable Cc: Andrea Parri (Microsoft), Saruhan Karademir, Haiyang Zhang, Jakub Kicinski, David S. Miller, netdev, Wei Liu, linux-hyperv From: Sasha Levin <sashal@kernel.org> Sent: Tuesday, December 22, 2020 6:22 PM > > From: "Andrea Parri (Microsoft)" <parri.andrea@gmail.com> > > [ Upstream commit 206ad34d52a2f1205c84d08c12fc116aad0eb407 ] > > Lack of validation could lead to out-of-bound reads and information > leaks (cf. usage of nvdev->chan_table[]). Check that the number of > allocated sub-channels fits into the expected range. > > Suggested-by: Saruhan Karademir <skarade@microsoft.com> > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com> > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> > Acked-by: Jakub Kicinski <kuba@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: netdev@vger.kernel.org > Link: > https://lore.kernel.org/linux-hyperv/20201118153310.112404-1-parri.andrea@gmail.com/ > Signed-off-by: Wei Liu <wei.liu@kernel.org> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > drivers/net/hyperv/rndis_filter.c | 5 +++++ > 1 file changed, 5 insertions(+) > Sasha -- This patch is one of an ongoing group of patches where a Linux guest running on Hyper-V will start assuming that hypervisor behavior might be malicious, and guards against such behavior. Because this is a new assumption, these patches are more properly treated as new functionality rather than as bug fixes. So I would propose that we *not* bring such patches back to stable branches. Michael ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 4.14 40/66] hv_netvsc: Validate number of allocated sub-channels 2020-12-23 2:47 ` Michael Kelley @ 2020-12-23 8:59 ` Andrea Parri 2020-12-23 14:14 ` Sasha Levin 0 siblings, 1 reply; 4+ messages in thread From: Andrea Parri @ 2020-12-23 8:59 UTC (permalink / raw) To: Michael Kelley Cc: Sasha Levin, linux-kernel, stable, Saruhan Karademir, Haiyang Zhang, Jakub Kicinski, David S. Miller, netdev, Wei Liu, linux-hyperv On Wed, Dec 23, 2020 at 02:47:56AM +0000, Michael Kelley wrote: > From: Sasha Levin <sashal@kernel.org> Sent: Tuesday, December 22, 2020 6:22 PM > > > > From: "Andrea Parri (Microsoft)" <parri.andrea@gmail.com> > > > > [ Upstream commit 206ad34d52a2f1205c84d08c12fc116aad0eb407 ] > > > > Lack of validation could lead to out-of-bound reads and information > > leaks (cf. usage of nvdev->chan_table[]). Check that the number of > > allocated sub-channels fits into the expected range. > > > > Suggested-by: Saruhan Karademir <skarade@microsoft.com> > > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com> > > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> > > Acked-by: Jakub Kicinski <kuba@kernel.org> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Jakub Kicinski <kuba@kernel.org> > > Cc: netdev@vger.kernel.org > > Link: > > https://lore.kernel.org/linux-hyperv/20201118153310.112404-1-parri.andrea@gmail.com/ > > Signed-off-by: Wei Liu <wei.liu@kernel.org> > > Signed-off-by: Sasha Levin <sashal@kernel.org> > > --- > > drivers/net/hyperv/rndis_filter.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > Sasha -- This patch is one of an ongoing group of patches where a Linux > guest running on Hyper-V will start assuming that hypervisor behavior might > be malicious, and guards against such behavior. Because this is a new > assumption, these patches are more properly treated as new functionality > rather than as bug fixes. So I would propose that we *not* bring such patches > back to stable branches. Thank you, Michael. Just to confirm, I agree with Michael's assessment above and I join his proposal to *not* backport such patches to stable. Thanks, Andrea ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 4.14 40/66] hv_netvsc: Validate number of allocated sub-channels 2020-12-23 8:59 ` Andrea Parri @ 2020-12-23 14:14 ` Sasha Levin 0 siblings, 0 replies; 4+ messages in thread From: Sasha Levin @ 2020-12-23 14:14 UTC (permalink / raw) To: Andrea Parri Cc: Michael Kelley, linux-kernel, stable, Saruhan Karademir, Haiyang Zhang, Jakub Kicinski, David S. Miller, netdev, Wei Liu, linux-hyperv On Wed, Dec 23, 2020 at 09:59:31AM +0100, Andrea Parri wrote: >On Wed, Dec 23, 2020 at 02:47:56AM +0000, Michael Kelley wrote: >> From: Sasha Levin <sashal@kernel.org> Sent: Tuesday, December 22, 2020 6:22 PM >> > >> > From: "Andrea Parri (Microsoft)" <parri.andrea@gmail.com> >> > >> > [ Upstream commit 206ad34d52a2f1205c84d08c12fc116aad0eb407 ] >> > >> > Lack of validation could lead to out-of-bound reads and information >> > leaks (cf. usage of nvdev->chan_table[]). Check that the number of >> > allocated sub-channels fits into the expected range. >> > >> > Suggested-by: Saruhan Karademir <skarade@microsoft.com> >> > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com> >> > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> >> > Acked-by: Jakub Kicinski <kuba@kernel.org> >> > Cc: "David S. Miller" <davem@davemloft.net> >> > Cc: Jakub Kicinski <kuba@kernel.org> >> > Cc: netdev@vger.kernel.org >> > Link: >> > https://lore.kernel.org/linux-hyperv/20201118153310.112404-1-parri.andrea@gmail.com/ >> > Signed-off-by: Wei Liu <wei.liu@kernel.org> >> > Signed-off-by: Sasha Levin <sashal@kernel.org> >> > --- >> > drivers/net/hyperv/rndis_filter.c | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> >> Sasha -- This patch is one of an ongoing group of patches where a Linux >> guest running on Hyper-V will start assuming that hypervisor behavior might >> be malicious, and guards against such behavior. Because this is a new >> assumption, these patches are more properly treated as new functionality >> rather than as bug fixes. So I would propose that we *not* bring such patches >> back to stable branches. > >Thank you, Michael. Just to confirm, I agree with Michael's assessment >above and I join his proposal to *not* backport such patches to stable. I'll drop it then, thanks. -- Thanks, Sasha ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-23 14:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201223022253.2793452-1-sashal@kernel.org>
2020-12-23 2:22 ` [PATCH AUTOSEL 4.14 40/66] hv_netvsc: Validate number of allocated sub-channels Sasha Levin
2020-12-23 2:47 ` Michael Kelley
2020-12-23 8:59 ` Andrea Parri
2020-12-23 14:14 ` Sasha Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).