From: Vlastimil Babka <vbabka@suse.cz>
To: David Hildenbrand <david@redhat.com>,
Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-acpi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Oscar Salvador <osalvador@suse.de>,
Mike Rapoport <rppt@kernel.org>,
Scott Cheloha <cheloha@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH RFC 3/4] mm/page_alloc: always move pages to the tail of the freelist in unset_migratetype_isolate()
Date: Fri, 25 Sep 2020 10:39:33 +0200 [thread overview]
Message-ID: <8e9a4427-3c95-22f5-1e0b-5e3c9fa86592@suse.cz> (raw)
In-Reply-To: <dc550ba3-6b65-bb4e-30a3-2740b1e21be9@redhat.com>
On 9/25/20 10:05 AM, David Hildenbrand wrote:
>>>> static inline void del_page_from_free_list(struct page *page, struct zone *zone,
>>>> unsigned int order)
>>>> {
>>>> @@ -2323,7 +2332,7 @@ static inline struct page *__rmqueue_cma_fallback(struct zone *zone,
>>>> */
>>>> static int move_freepages(struct zone *zone,
>>>> struct page *start_page, struct page *end_page,
>>>> - int migratetype, int *num_movable)
>>>> + int migratetype, int *num_movable, bool to_tail)
>>>> {
>>>> struct page *page;
>>>> unsigned int order;
>>>> @@ -2354,7 +2363,10 @@ static int move_freepages(struct zone *zone,
>>>> VM_BUG_ON_PAGE(page_zone(page) != zone, page);
>>>>
>>>> order = page_order(page);
>>>> - move_to_free_list(page, zone, order, migratetype);
>>>> + if (to_tail)
>>>> + move_to_free_list_tail(page, zone, order, migratetype);
>>>> + else
>>>> + move_to_free_list(page, zone, order, migratetype);
>>>> page += 1 << order;
>>>> pages_moved += 1 << order;
>>>> }
>>>> @@ -2362,8 +2374,9 @@ static int move_freepages(struct zone *zone,
>>>> return pages_moved;
>>>> }
>>>>
>>>> -int move_freepages_block(struct zone *zone, struct page *page,
>>>> - int migratetype, int *num_movable)
>>>> +static int __move_freepages_block(struct zone *zone, struct page *page,
>>>> + int migratetype, int *num_movable,
>>>> + bool to_tail)
>>>> {
>>>> unsigned long start_pfn, end_pfn;
>>>> struct page *start_page, *end_page;
>>>> @@ -2384,7 +2397,20 @@ int move_freepages_block(struct zone *zone, struct page *page,
>>>> return 0;
>>>>
>>>> return move_freepages(zone, start_page, end_page, migratetype,
>>>> - num_movable);
>>>> + num_movable, to_tail);
>>>> +}
>>>> +
>>>> +int move_freepages_block(struct zone *zone, struct page *page,
>>>> + int migratetype, int *num_movable)
>>>> +{
>>>> + return __move_freepages_block(zone, page, migratetype, num_movable,
>>>> + false);
>>>> +}
>>>> +
>>>> +int move_freepages_block_tail(struct zone *zone, struct page *page,
>>>> + int migratetype)
>>>> +{
>>>> + return __move_freepages_block(zone, page, migratetype, NULL, true);
>>>> }
>>>
>>> Likewise, just 5 callers of move_freepages_block(), all in the files you're
>>> already changing, so no need for this wrappers IMHO.
>
> As long as we don't want to move the implementation to the header, we'll
> need it for the constant propagation to work at compile time (we don't
> really have link-time optimizations). Or am I missing something?
I guess move_freepages_block() is not exactly fast path, so we could do without it.
> Thanks!
>
next prev parent reply other threads:[~2020-09-25 8:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 18:34 [PATCH RFC 0/4] mm: place pages to the freelist tail when onling and undoing isolation David Hildenbrand
2020-09-16 18:34 ` [PATCH RFC 1/4] mm/page_alloc: convert "report" flag of __free_one_page() to a proper flag David Hildenbrand
2020-09-16 21:44 ` Alexander Duyck
2020-09-18 1:53 ` Wei Yang
2020-09-18 7:23 ` David Hildenbrand
2020-09-24 10:19 ` Vlastimil Babka
2020-09-25 10:34 ` Oscar Salvador
2020-09-16 18:34 ` [PATCH RFC 2/4] mm/page_alloc: place pages to tail in __putback_isolated_page() David Hildenbrand
2020-09-16 21:50 ` Alexander Duyck
2020-09-18 2:07 ` Wei Yang
2020-09-18 7:27 ` David Hildenbrand
2020-09-21 1:57 ` Wei Yang
2020-09-18 2:16 ` Wei Yang
2020-09-18 7:29 ` David Hildenbrand
2020-09-24 10:37 ` Vlastimil Babka
2020-09-25 8:10 ` David Hildenbrand
2020-09-25 13:19 ` Oscar Salvador
2020-09-25 13:30 ` David Hildenbrand
2020-09-16 18:34 ` [PATCH RFC 3/4] mm/page_alloc: always move pages to the tail of the freelist in unset_migratetype_isolate() David Hildenbrand
2020-09-18 2:29 ` Wei Yang
2020-09-18 7:30 ` David Hildenbrand
2020-09-24 11:13 ` Vlastimil Babka
2020-09-25 2:45 ` Wei Yang
2020-09-25 8:05 ` David Hildenbrand
2020-09-25 8:39 ` Vlastimil Babka [this message]
2020-09-25 13:13 ` David Hildenbrand
2020-09-25 13:57 ` Oscar Salvador
2020-09-16 18:34 ` [PATCH RFC 4/4] mm/page_alloc: place pages to tail in __free_pages_core() David Hildenbrand
2020-09-24 13:44 ` Vlastimil Babka
2020-09-28 7:58 ` Oscar Salvador
2020-09-28 8:36 ` David Hildenbrand
2020-09-28 12:53 ` Oscar Salvador
2020-09-16 18:50 ` [PATCH RFC 0/4] mm: place pages to the freelist tail when onling and undoing isolation osalvador
2020-09-16 19:31 ` David Hildenbrand
2020-09-18 2:30 ` Wei Yang
2020-09-18 7:32 ` David Hildenbrand
2020-09-23 14:31 ` Vlastimil Babka
2020-09-23 15:26 ` David Hildenbrand
2020-09-24 9:40 ` Mel Gorman
2020-09-24 9:54 ` David Hildenbrand
2020-09-24 13:59 ` Vlastimil Babka
2020-09-24 14:29 ` David Hildenbrand
2020-09-24 1:57 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e9a4427-3c95-22f5-1e0b-5e3c9fa86592@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=cheloha@linux.ibm.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=osalvador@suse.de \
--cc=richard.weiyang@linux.alibaba.com \
--cc=rppt@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).