linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
@ 2021-10-01 13:55 Andy Shevchenko
  2021-10-01 22:11 ` Haiyang Zhang
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2021-10-01 13:55 UTC (permalink / raw)
  To: Andy Shevchenko, linux-hyperv, linux-kernel
  Cc: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu,
	Dexuan Cui, Greg Kroah-Hartman

There is no user of anything in uuid.h in the hyperv.h. Replace it with
more appropriate types.h.

Fixes: f081bbb3fd03 ("hyper-v: Remove internal types from UAPI header")
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/uapi/linux/hyperv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
index 6135d92e0d47..daf82a230c0e 100644
--- a/include/uapi/linux/hyperv.h
+++ b/include/uapi/linux/hyperv.h
@@ -26,7 +26,7 @@
 #ifndef _UAPI_HYPERV_H
 #define _UAPI_HYPERV_H
 
-#include <linux/uuid.h>
+#include <linux/types.h>
 
 /*
  * Framework version for util services.
-- 
2.33.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
  2021-10-01 13:55 [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h Andy Shevchenko
@ 2021-10-01 22:11 ` Haiyang Zhang
  2021-10-02  7:46   ` Andy Shevchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Haiyang Zhang @ 2021-10-01 22:11 UTC (permalink / raw)
  To: Andy Shevchenko, linux-hyperv, linux-kernel
  Cc: KY Srinivasan, Stephen Hemminger, Wei Liu, Dexuan Cui,
	Greg Kroah-Hartman



> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Friday, October 1, 2021 9:56 AM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
> hyperv@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> Wei Liu <wei.liu@kernel.org>; Dexuan Cui <decui@microsoft.com>; Greg
> Kroah-Hartman <gregkh@linuxfoundation.org>
> Subject: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
> 
> There is no user of anything in uuid.h in the hyperv.h. Replace it with
> more appropriate types.h.
> 
> Fixes: f081bbb3fd03 ("hyper-v: Remove internal types from UAPI header")
> Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  include/uapi/linux/hyperv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
> index 6135d92e0d47..daf82a230c0e 100644
> --- a/include/uapi/linux/hyperv.h
> +++ b/include/uapi/linux/hyperv.h
> @@ -26,7 +26,7 @@
>  #ifndef _UAPI_HYPERV_H
>  #define _UAPI_HYPERV_H
> 
> -#include <linux/uuid.h>
> +#include <linux/types.h>
> 
>  /*

Hyper-v drivers are using uuid/guid APIs, but they can get the defs from
linux/mod_devicetable.h:

./include/linux/mod_devicetable.h:#include <linux/uuid.h>
./include/linux/hyperv.h:#include <uapi/linux/hyperv.h>
./include/linux/hyperv.h:#include <linux/mod_devicetable.h>

So your patch looks fine. Thanks.

Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
  2021-10-01 22:11 ` Haiyang Zhang
@ 2021-10-02  7:46   ` Andy Shevchenko
  2021-10-06 12:06     ` Wei Liu
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2021-10-02  7:46 UTC (permalink / raw)
  To: Haiyang Zhang
  Cc: Andy Shevchenko, linux-hyperv, linux-kernel, KY Srinivasan,
	Stephen Hemminger, Wei Liu, Dexuan Cui, Greg Kroah-Hartman

On Sat, Oct 2, 2021 at 1:36 AM Haiyang Zhang <haiyangz@microsoft.com> wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Friday, October 1, 2021 9:56 AM

...

> Hyper-v drivers are using uuid/guid APIs, but they can get the defs from
> linux/mod_devicetable.h:
>
> ./include/linux/mod_devicetable.h:#include <linux/uuid.h>
> ./include/linux/hyperv.h:#include <uapi/linux/hyperv.h>
> ./include/linux/hyperv.h:#include <linux/mod_devicetable.h>

Yes, drivers inside the kernel may use that and this is the correct
way. The uAPI is not using it.

> So your patch looks fine. Thanks.
>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>

Thank you!


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
  2021-10-02  7:46   ` Andy Shevchenko
@ 2021-10-06 12:06     ` Wei Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2021-10-06 12:06 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Haiyang Zhang, Andy Shevchenko, linux-hyperv, linux-kernel,
	KY Srinivasan, Stephen Hemminger, Wei Liu, Dexuan Cui,
	Greg Kroah-Hartman

On Sat, Oct 02, 2021 at 10:46:16AM +0300, Andy Shevchenko wrote:
> On Sat, Oct 2, 2021 at 1:36 AM Haiyang Zhang <haiyangz@microsoft.com> wrote:
> > > -----Original Message-----
> > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Sent: Friday, October 1, 2021 9:56 AM
> 
> ...
> 
> > Hyper-v drivers are using uuid/guid APIs, but they can get the defs from
> > linux/mod_devicetable.h:
> >
> > ./include/linux/mod_devicetable.h:#include <linux/uuid.h>
> > ./include/linux/hyperv.h:#include <uapi/linux/hyperv.h>
> > ./include/linux/hyperv.h:#include <linux/mod_devicetable.h>
> 
> Yes, drivers inside the kernel may use that and this is the correct
> way. The uAPI is not using it.
> 
> > So your patch looks fine. Thanks.
> >
> > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> 
> Thank you!

Applied to hyperv-fixes. Thanks.

Wei.

> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-06 12:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 13:55 [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h Andy Shevchenko
2021-10-01 22:11 ` Haiyang Zhang
2021-10-02  7:46   ` Andy Shevchenko
2021-10-06 12:06     ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).