* [PATCH] net: mana: store return status in signed variable
@ 2022-10-04 10:11 Muhammad Usama Anjum
2022-10-06 1:48 ` Long Li
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Usama Anjum @ 2022-10-04 10:11 UTC (permalink / raw)
To: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu,
Dexuan Cui, Long Li, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Jason Gunthorpe, Ajay Sharma
Cc: Muhammad Usama Anjum, kernel, kernel-janitors, linux-hyperv,
netdev, linux-kernel
The mana_adev_idx_alloc() can return negative value. Save its return
value in ret which is signed variable and check if it is correct value.
Fixes: ee928282bfa7 ("net: mana: Add support for auxiliary device")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
drivers/net/ethernet/microsoft/mana/mana_en.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 7ca313c7b7b3..1c59502d34b5 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -2203,11 +2203,10 @@ static int add_adev(struct gdma_dev *gd)
return -ENOMEM;
adev = &madev->adev;
- adev->id = mana_adev_idx_alloc();
- if (adev->id < 0) {
- ret = adev->id;
+ ret = mana_adev_idx_alloc();
+ if (ret < 0)
goto idx_fail;
- }
+ adev->id = ret;
adev->name = "rdma";
adev->dev.parent = gd->gdma_context->dev;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] net: mana: store return status in signed variable
2022-10-04 10:11 [PATCH] net: mana: store return status in signed variable Muhammad Usama Anjum
@ 2022-10-06 1:48 ` Long Li
0 siblings, 0 replies; 2+ messages in thread
From: Long Li @ 2022-10-06 1:48 UTC (permalink / raw)
To: Muhammad Usama Anjum, KY Srinivasan, Haiyang Zhang,
Stephen Hemminger, Wei Liu, Dexuan Cui, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jason Gunthorpe,
Ajay Sharma
Cc: kernel, kernel-janitors, linux-hyperv, netdev, linux-kernel
> Subject: [PATCH] net: mana: store return status in signed variable
>
> [Some people who received this message don't often get email from
> usama.anjum@collabora.com. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
>
> The mana_adev_idx_alloc() can return negative value. Save its return value
> in ret which is signed variable and check if it is correct value.
>
> Fixes: ee928282bfa7 ("net: mana: Add support for auxiliary device")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/net/ethernet/microsoft/mana/mana_en.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c
> b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index 7ca313c7b7b3..1c59502d34b5 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -2203,11 +2203,10 @@ static int add_adev(struct gdma_dev *gd)
> return -ENOMEM;
>
> adev = &madev->adev;
> - adev->id = mana_adev_idx_alloc();
> - if (adev->id < 0) {
> - ret = adev->id;
> + ret = mana_adev_idx_alloc();
> + if (ret < 0)
> goto idx_fail;
> - }
> + adev->id = ret;
>
> adev->name = "rdma";
> adev->dev.parent = gd->gdma_context->dev;
> --
> 2.30.2
Thank you, I'm folding this patch into the next v7 patch series.
Long
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-06 1:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 10:11 [PATCH] net: mana: store return status in signed variable Muhammad Usama Anjum
2022-10-06 1:48 ` Long Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).