* [PATCH] drivers: hid: Add a module description line
@ 2019-04-22 21:31 Joseph Salisbury
2019-04-23 3:15 ` Michael Kelley
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Joseph Salisbury @ 2019-04-22 21:31 UTC (permalink / raw)
To: KY Srinivasan, Haiyang Zhang, Stephen Hemminger, Michael Kelley,
sashal, jikos, benjamin.tissoires
Cc: linux-hyperv, linux-input, linux-kernel
Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
---
drivers/hid/hid-hyperv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index 704049e62d58..d3311d714d35 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void)
}
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver");
+
module_init(mousevsc_init);
module_exit(mousevsc_exit);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] drivers: hid: Add a module description line
2019-04-22 21:31 [PATCH] drivers: hid: Add a module description line Joseph Salisbury
@ 2019-04-23 3:15 ` Michael Kelley
2019-04-23 3:25 ` Joseph Salisbury
2019-04-23 3:46 ` [PATCH][v2] drivers: hid: Add a module description line to the hid_hyperv driver Joseph Salisbury
2019-04-23 16:38 ` Michael Kelley
2 siblings, 1 reply; 6+ messages in thread
From: Michael Kelley @ 2019-04-23 3:15 UTC (permalink / raw)
To: Joseph Salisbury, KY Srinivasan, Haiyang Zhang,
Stephen Hemminger, sashal, jikos, benjamin.tissoires
Cc: linux-hyperv, linux-input, linux-kernel
From: Joseph Salisbury <Joseph.Salisbury@microsoft.com> Sent: Monday, April 22, 2019 2:31 PM
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
> ---
> drivers/hid/hid-hyperv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index 704049e62d58..d3311d714d35 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void)
> }
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver");
> +
> module_init(mousevsc_init);
> module_exit(mousevsc_exit);
> --
> 2.17.1
Even though it will likely be redundant with the commit title, there
probably needs to be a short commit message. (And also with the
other two similar patches.)
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] drivers: hid: Add a module description line
2019-04-23 3:15 ` Michael Kelley
@ 2019-04-23 3:25 ` Joseph Salisbury
0 siblings, 0 replies; 6+ messages in thread
From: Joseph Salisbury @ 2019-04-23 3:25 UTC (permalink / raw)
To: Michael Kelley, KY Srinivasan, Haiyang Zhang, Stephen Hemminger,
sashal, jikos, benjamin.tissoires
Cc: linux-hyperv, linux-input, linux-kernel
Thanks for the feedback. I'll probably update each patch subject with the module names as well. I'll send a v2 for all three.
Thanks,
Joe
-----Original Message-----
From: Michael Kelley <mikelley@microsoft.com>
Sent: Monday, April 22, 2019 11:16 PM
To: Joseph Salisbury <Joseph.Salisbury@microsoft.com>; KY Srinivasan <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>; sashal@kernel.org; jikos@kernel.org; benjamin.tissoires@redhat.com
Cc: linux-hyperv@vger.kernel.org; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: RE: [PATCH] drivers: hid: Add a module description line
From: Joseph Salisbury <Joseph.Salisbury@microsoft.com> Sent: Monday, April 22, 2019 2:31 PM
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
> ---
> drivers/hid/hid-hyperv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c index
> 704049e62d58..d3311d714d35 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void) }
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver");
> +
> module_init(mousevsc_init);
> module_exit(mousevsc_exit);
> --
> 2.17.1
Even though it will likely be redundant with the commit title, there
probably needs to be a short commit message. (And also with the
other two similar patches.)
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH][v2] drivers: hid: Add a module description line to the hid_hyperv driver
2019-04-22 21:31 [PATCH] drivers: hid: Add a module description line Joseph Salisbury
2019-04-23 3:15 ` Michael Kelley
@ 2019-04-23 3:46 ` Joseph Salisbury
2019-04-23 16:38 ` Michael Kelley
2 siblings, 0 replies; 6+ messages in thread
From: Joseph Salisbury @ 2019-04-23 3:46 UTC (permalink / raw)
To: KY Srinivasan, Haiyang Zhang, Stephen Hemminger, Michael Kelley,
sashal, jikos, benjamin.tissoires
Cc: linux-hyperv, linux-input, linux-kernel
This patch only adds a MODULE_DESCRIPTION statement to the driver.
This change is only cosmetic, so there should be no runtime impact.
Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
---
drivers/hid/hid-hyperv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index 704049e62d58..d3311d714d35 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void)
}
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver");
+
module_init(mousevsc_init);
module_exit(mousevsc_exit);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH][v2] drivers: hid: Add a module description line to the hid_hyperv driver
2019-04-22 21:31 [PATCH] drivers: hid: Add a module description line Joseph Salisbury
2019-04-23 3:15 ` Michael Kelley
2019-04-23 3:46 ` [PATCH][v2] drivers: hid: Add a module description line to the hid_hyperv driver Joseph Salisbury
@ 2019-04-23 16:38 ` Michael Kelley
2019-04-23 19:44 ` Sasha Levin
2 siblings, 1 reply; 6+ messages in thread
From: Michael Kelley @ 2019-04-23 16:38 UTC (permalink / raw)
To: Joseph Salisbury, KY Srinivasan, Haiyang Zhang,
Stephen Hemminger, sashal, jikos, benjamin.tissoires
Cc: linux-hyperv, linux-input, linux-kernel
From: Joseph Salisbury <joseph.salisbury@microsoft.com> Sent: Monday, April 22, 2019 8:47 PM
>
> This patch only adds a MODULE_DESCRIPTION statement to the driver.
> This change is only cosmetic, so there should be no runtime impact.
>
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
> ---
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][v2] drivers: hid: Add a module description line to the hid_hyperv driver
2019-04-23 16:38 ` Michael Kelley
@ 2019-04-23 19:44 ` Sasha Levin
0 siblings, 0 replies; 6+ messages in thread
From: Sasha Levin @ 2019-04-23 19:44 UTC (permalink / raw)
To: Michael Kelley
Cc: Joseph Salisbury, KY Srinivasan, Haiyang Zhang,
Stephen Hemminger, jikos, benjamin.tissoires, linux-hyperv,
linux-input, linux-kernel
On Tue, Apr 23, 2019 at 04:38:05PM +0000, Michael Kelley wrote:
>From: Joseph Salisbury <joseph.salisbury@microsoft.com> Sent: Monday, April 22, 2019 8:47 PM
>>
>> This patch only adds a MODULE_DESCRIPTION statement to the driver.
>> This change is only cosmetic, so there should be no runtime impact.
>>
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
>> ---
>
>Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Queued up for hyperv-next, thanks!
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-23 19:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-22 21:31 [PATCH] drivers: hid: Add a module description line Joseph Salisbury
2019-04-23 3:15 ` Michael Kelley
2019-04-23 3:25 ` Joseph Salisbury
2019-04-23 3:46 ` [PATCH][v2] drivers: hid: Add a module description line to the hid_hyperv driver Joseph Salisbury
2019-04-23 16:38 ` Michael Kelley
2019-04-23 19:44 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).