From: Borislav Petkov <bp@alien8.de>
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc: "hpa@zytor.com" <hpa@zytor.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Dexuan Cui <decui@microsoft.com>,
"luto@kernel.org" <luto@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"hch@infradead.org" <hch@infradead.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"brijesh.singh@amd.com" <brijesh.singh@amd.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"isaku.yamahata@intel.com" <isaku.yamahata@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"jane.chu@oracle.com" <jane.chu@oracle.com>,
"seanjc@google.com" <seanjc@google.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Subject: Re: [Patch v3 01/14] x86/ioremap: Fix page aligned size calculation in __ioremap_caller()
Date: Mon, 21 Nov 2022 20:45:10 +0100 [thread overview]
Message-ID: <Y3vVRnAZmDCyQ3Wo@zn.tnic> (raw)
In-Reply-To: <BYAPR21MB168871875A5D58698273E914D70A9@BYAPR21MB1688.namprd21.prod.outlook.com>
On Mon, Nov 21, 2022 at 04:40:16PM +0000, Michael Kelley (LINUX) wrote:
> As discussed in a parallel thread [1], the incorrect code here doesn't have
> any real impact in already released Linux kernels. It only affects the
> transition that my patch series implements to change the way vTOM
> is handled.
Are you sure?
PHYSICAL_PAGE_MASK is controlled by __PHYSICAL_MASK which is determined
by CONFIG_DYNAMIC_PHYSICAL_MASK and __PHYSICAL_MASK_SHIFT which all
differ depending on configurations and also dynamic.
It is probably still ok, in probably all possible cases even though I
wouldn't bet on it.
And this fix is simple and all clear so lemme ask it differently: what
would be any downsides in backporting it to stable, just in case?
> I don't know what the tradeoffs are for backporting a fix that doesn't solve
> a real problem vs. just letting it be. Every backport carries some overhead
> in the process
Have you seen the deluge of stable fixes? :-)
> and there's always a non-zero risk of breaking something.
I don't see how this one would cause any breakage...
> I've leaned away from adding the "Fixes:" tag in such cases. But if
> it's better to go ahead and add the "Fixes:" tag for what's only a
> theoretical problem, I'm OK with doing so.
I think this is a good to have fix anyway as it is Obviously
Correct(tm).
Unless you have any reservations you haven't shared yet...
> [1] https://lkml.org/lkml/2022/11/11/1348
Btw, the proper way to reference to a mail message now is simply to do:
https://lore.kernel.org/r/<Message-ID>
as long as it has been posted on some ML which lore archives. And I
think it archives all.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-11-21 19:45 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 18:41 [Patch v3 00/14] Add PCI pass-thru support to Hyper-V Confidential VMs Michael Kelley
2022-11-16 18:41 ` [Patch v3 01/14] x86/ioremap: Fix page aligned size calculation in __ioremap_caller() Michael Kelley
2022-11-21 13:32 ` Borislav Petkov
2022-11-21 16:40 ` Michael Kelley (LINUX)
2022-11-21 19:45 ` Borislav Petkov [this message]
2022-11-21 21:02 ` Michael Kelley (LINUX)
2022-11-21 18:14 ` Dave Hansen
2022-11-21 21:04 ` Michael Kelley (LINUX)
2022-11-21 21:08 ` Borislav Petkov
2022-11-16 18:41 ` [Patch v3 02/14] x86/ioapic: Gate decrypted mapping on cc_platform_has() attribute Michael Kelley
2022-11-17 21:39 ` Sathyanarayanan Kuppuswamy
2022-11-21 13:50 ` Borislav Petkov
2022-11-21 16:43 ` Michael Kelley (LINUX)
2022-11-21 19:47 ` Borislav Petkov
2022-11-16 18:41 ` [Patch v3 03/14] x86/hyperv: Reorder code in prep for subsequent patch Michael Kelley
2022-11-16 18:41 ` [Patch v3 04/14] Drivers: hv: Explicitly request decrypted in vmap_pfn() calls Michael Kelley
2022-11-16 18:41 ` [Patch v3 05/14] x86/mm: Handle decryption/re-encryption of bss_decrypted consistently Michael Kelley
2022-11-16 20:35 ` Tom Lendacky
2022-11-16 21:15 ` Tom Lendacky
2022-11-18 2:59 ` Michael Kelley (LINUX)
2022-11-17 21:47 ` Sathyanarayanan Kuppuswamy
2022-11-18 2:55 ` Michael Kelley (LINUX)
2022-11-21 14:39 ` Borislav Petkov
2022-11-21 22:06 ` Sathyanarayanan Kuppuswamy
2022-11-22 17:59 ` Michael Kelley (LINUX)
2022-11-28 10:50 ` Borislav Petkov
2022-11-28 2:52 ` Dexuan Cui
2022-11-28 14:15 ` Tom Lendacky
2022-11-28 18:06 ` Dexuan Cui
2022-11-21 14:40 ` Borislav Petkov
2022-11-16 18:41 ` [Patch v3 06/14] init: Call mem_encrypt_init() after Hyper-V hypercall init is done Michael Kelley
2022-11-16 21:14 ` Tom Lendacky
2022-11-21 14:46 ` Borislav Petkov
2022-11-16 18:41 ` [Patch v3 07/14] x86/hyperv: Change vTOM handling to use standard coco mechanisms Michael Kelley
2022-11-17 2:59 ` Tianyu Lan
2022-11-21 15:03 ` Borislav Petkov
2022-11-22 18:22 ` Michael Kelley (LINUX)
2022-11-22 18:30 ` Dave Hansen
2022-11-22 22:02 ` Michael Kelley (LINUX)
2022-11-22 22:18 ` Borislav Petkov
2022-11-23 0:59 ` Michael Kelley (LINUX)
2022-11-28 14:38 ` Michael Kelley (LINUX)
2022-11-28 16:33 ` Borislav Petkov
2022-11-28 16:59 ` Michael Kelley (LINUX)
2022-11-28 17:24 ` Borislav Petkov
2022-11-28 17:55 ` Michael Kelley (LINUX)
2022-11-28 19:56 ` Borislav Petkov
2022-11-29 1:15 ` Michael Kelley (LINUX)
2022-11-29 8:40 ` Borislav Petkov
2022-11-29 15:49 ` Michael Kelley (LINUX)
2022-11-29 17:47 ` Borislav Petkov
2022-11-30 16:11 ` Michael Kelley (LINUX)
2022-11-16 18:41 ` [Patch v3 08/14] swiotlb: Remove bounce buffer remapping for Hyper-V Michael Kelley
2022-11-16 18:41 ` [Patch v3 09/14] Drivers: hv: vmbus: Remove second mapping of VMBus monitor pages Michael Kelley
2022-11-16 18:41 ` [Patch v3 10/14] Drivers: hv: vmbus: Remove second way of mapping ring buffers Michael Kelley
2022-11-16 18:41 ` [Patch v3 11/14] hv_netvsc: Remove second mapping of send and recv buffers Michael Kelley
2022-11-16 18:41 ` [Patch v3 12/14] Drivers: hv: Don't remap addresses that are above shared_gpa_boundary Michael Kelley
2022-11-16 18:41 ` [Patch v3 13/14] PCI: hv: Add hypercalls to read/write MMIO space Michael Kelley
2022-11-17 15:16 ` Wei Liu
2022-11-17 16:14 ` Michael Kelley (LINUX)
2022-11-17 17:01 ` Wei Liu
2022-11-17 16:32 ` Sean Christopherson
2022-11-17 17:00 ` Wei Liu
2022-11-17 18:33 ` Haiyang Zhang
2022-11-18 2:38 ` Michael Kelley (LINUX)
2022-11-16 18:41 ` [Patch v3 14/14] PCI: hv: Enable PCI pass-thru devices in Confidential VMs Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3vVRnAZmDCyQ3Wo@zn.tnic \
--to=bp@alien8.de \
--cc=Tianyu.Lan@microsoft.com \
--cc=ak@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=brijesh.singh@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=isaku.yamahata@intel.com \
--cc=jane.chu@oracle.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kuba@kernel.org \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).