From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: longli@linuxonhyperv.com
Cc: linux-fs@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
Long Li <longli@microsoft.com>, Jonathan Corbet <corbet@lwn.net>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
Mike Rapoport <rppt@kernel.org>,
Ben Widawsky <ben.widawsky@intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
Andra Paraschiv <andraprs@amazon.com>,
Siddharth Gupta <sidgup@codeaurora.org>,
Hannes Reinecke <hare@suse.de>,
linux-doc@vger.kernel.org
Subject: Re: [Patch v4 2/3] Drivers: hv: add Azure Blob driver
Date: Tue, 20 Jul 2021 09:34:29 +0200 [thread overview]
Message-ID: <YPZ8hX7sx1RFL0c5@kroah.com> (raw)
In-Reply-To: <1626751866-15765-3-git-send-email-longli@linuxonhyperv.com>
On Mon, Jul 19, 2021 at 08:31:05PM -0700, longli@linuxonhyperv.com wrote:
> +struct az_blob_device {
> + struct hv_device *device;
> +
> + /* Opened files maintained by this device */
> + struct list_head file_list;
> + /* Lock for protecting file_list */
> + spinlock_t file_lock;
> +
> + /* The refcount for this device */
> + refcount_t count;
Just use a kref please if you really need this. Are you sure you do?
You already have 2 other reference counted objects being used here, why
make it 3?
> + /* Pending requests to VSP */
> + atomic_t pending;
Why does this need to be atomic?
> + wait_queue_head_t waiting_to_drain;
> +
> + bool removing;
Are you sure this actually works properly? Why is it needed vs. any
other misc device?
> +/* VSC->VSP request */
> +struct az_blob_vsp_request {
> + u32 version;
> + u32 timeout_ms;
> + u32 data_buffer_offset;
> + u32 data_buffer_length;
> + u32 data_buffer_valid;
> + u32 operation_type;
> + u32 request_buffer_offset;
> + u32 request_buffer_length;
> + u32 response_buffer_offset;
> + u32 response_buffer_length;
> + guid_t transaction_id;
> +} __packed;
Why packed? If this is going across the wire somewhere, you need to
specify the endian-ness of these values, right? If this is not going
across the wire, no need for it to be packed.
> +
> +/* VSP->VSC response */
> +struct az_blob_vsp_response {
> + u32 length;
> + u32 error;
> + u32 response_len;
> +} __packed;
Same here.
> +
> +struct az_blob_vsp_request_ctx {
> + struct list_head list;
> + struct completion wait_vsp;
> + struct az_blob_request_sync *request;
> +};
> +
> +struct az_blob_file_ctx {
> + struct list_head list;
> +
> + /* List of pending requests to VSP */
> + struct list_head vsp_pending_requests;
> + /* Lock for protecting vsp_pending_requests */
> + spinlock_t vsp_pending_lock;
> + wait_queue_head_t wait_vsp_pending;
> +
> + pid_t pid;
Why do you need a pid? What namespace is this pid in?
> +static int az_blob_probe(struct hv_device *device,
> + const struct hv_vmbus_device_id *dev_id)
> +{
> + int ret;
> + struct az_blob_device *dev;
> +
> + dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> + if (!dev)
> + return -ENOMEM;
> +
> + spin_lock_init(&dev->file_lock);
> + INIT_LIST_HEAD(&dev->file_list);
> + atomic_set(&dev->pending, 0);
> + init_waitqueue_head(&dev->waiting_to_drain);
> +
> + ret = az_blob_connect_to_vsp(device, dev, AZ_BLOB_RING_SIZE);
> + if (ret)
> + goto fail;
> +
> + refcount_set(&dev->count, 1);
> + az_blob_dev = dev;
> +
> + // create user-mode client library facing device
> + ret = az_blob_create_device(dev);
> + if (ret) {
> + dev_err(AZ_DEV, "failed to create device ret=%d\n", ret);
> + az_blob_remove_vmbus(device);
> + goto fail;
> + }
> +
> + dev_info(AZ_DEV, "successfully probed device\n");
When drivers are working properly, they should be quiet.
And what is with the AZ_DEV macro mess?
And can you handle more than one device in the system at one time? I
think your debugfs logic will get really confused.
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-20 9:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 3:31 [Patch v4 0/3] Introduce a driver to support host accelerated access to Microsoft Azure Blob longli
2021-07-20 3:31 ` [Patch v4 1/3] Drivers: hv: vmbus: add support to ignore certain PCIE devices longli
2021-07-20 3:31 ` [Patch v4 2/3] Drivers: hv: add Azure Blob driver longli
2021-07-20 5:26 ` Greg Kroah-Hartman
2021-07-20 5:30 ` Greg Kroah-Hartman
2021-07-20 7:34 ` Greg Kroah-Hartman [this message]
2021-07-20 19:57 ` Long Li
2021-07-21 5:08 ` Greg Kroah-Hartman
2021-07-20 11:10 ` Jiri Slaby
2021-07-20 22:12 ` Long Li
2021-07-21 4:57 ` Jiri Slaby
2021-07-21 16:07 ` Long Li
2021-07-20 3:31 ` [Patch v4 3/3] Drivers: hv: Add to maintainer for Hyper-V/Azure drivers longli
2021-07-20 4:37 ` [Patch v4 0/3] Introduce a driver to support host accelerated access to Microsoft Azure Blob Bart Van Assche
2021-07-20 6:01 ` Christoph Hellwig
2021-07-20 7:05 ` Long Li
2021-07-20 15:15 ` Bart Van Assche
2021-07-20 17:33 ` Long Li
2021-07-20 18:16 ` gregkh
2021-07-20 18:52 ` Long Li
2021-07-20 15:54 ` Greg KH
2021-07-20 18:37 ` Long Li
2021-07-21 5:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPZ8hX7sx1RFL0c5@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andraprs@amazon.com \
--cc=ben.widawsky@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=hdegoede@redhat.com \
--cc=jirislaby@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fs@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=luzmaximilian@gmail.com \
--cc=rppt@kernel.org \
--cc=sidgup@codeaurora.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).