* [PATCH -next] RDMA/mana_ib: change mana_ib_dev_ops to static
@ 2022-09-23 14:48 Yang Yingliang
2022-09-23 14:43 ` Jason Gunthorpe
0 siblings, 1 reply; 3+ messages in thread
From: Yang Yingliang @ 2022-09-23 14:48 UTC (permalink / raw)
To: linux-rdma, linux-hyperv; +Cc: longli, jgg, yangyingliang
mana_ib_dev_ops is only used in device.c now, change it
to static.
Fixes: 6dce3468a04c ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/infiniband/hw/mana/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c
index c0a5a37583ff..4724af751f33 100644
--- a/drivers/infiniband/hw/mana/device.c
+++ b/drivers/infiniband/hw/mana/device.c
@@ -10,7 +10,7 @@ MODULE_DESCRIPTION("Microsoft Azure Network Adapter IB driver");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(NET_MANA);
-const struct ib_device_ops mana_ib_dev_ops = {
+static const struct ib_device_ops mana_ib_dev_ops = {
.owner = THIS_MODULE,
.driver_id = RDMA_DRIVER_MANA,
.uverbs_abi_ver = MANA_IB_UVERBS_ABI_VERSION,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] RDMA/mana_ib: change mana_ib_dev_ops to static
2022-09-23 14:48 [PATCH -next] RDMA/mana_ib: change mana_ib_dev_ops to static Yang Yingliang
@ 2022-09-23 14:43 ` Jason Gunthorpe
2022-09-23 18:08 ` Long Li
0 siblings, 1 reply; 3+ messages in thread
From: Jason Gunthorpe @ 2022-09-23 14:43 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-rdma, linux-hyperv, longli
On Fri, Sep 23, 2022 at 10:48:09PM +0800, Yang Yingliang wrote:
> mana_ib_dev_ops is only used in device.c now, change it
> to static.
>
> Fixes: 6dce3468a04c ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/infiniband/hw/mana/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Microsoft folks, you need to squash these sorts of patches into the
next version of your series and repost it after a few weeks. You will
probably get a few
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH -next] RDMA/mana_ib: change mana_ib_dev_ops to static
2022-09-23 14:43 ` Jason Gunthorpe
@ 2022-09-23 18:08 ` Long Li
0 siblings, 0 replies; 3+ messages in thread
From: Long Li @ 2022-09-23 18:08 UTC (permalink / raw)
To: Jason Gunthorpe, Yang Yingliang; +Cc: linux-rdma, linux-hyperv
> Subject: Re: [PATCH -next] RDMA/mana_ib: change mana_ib_dev_ops to
> static
>
> On Fri, Sep 23, 2022 at 10:48:09PM +0800, Yang Yingliang wrote:
> > mana_ib_dev_ops is only used in device.c now, change it to static.
> >
> > Fixes: 6dce3468a04c ("RDMA/mana_ib: Add a driver for Microsoft Azure
> > Network Adapter")
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > ---
> > drivers/infiniband/hw/mana/device.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Microsoft folks, you need to squash these sorts of patches into the next
> version of your series and repost it after a few weeks. You will probably get a
> few
>
> Jason
Thank you, will do.
Long
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-23 18:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 14:48 [PATCH -next] RDMA/mana_ib: change mana_ib_dev_ops to static Yang Yingliang
2022-09-23 14:43 ` Jason Gunthorpe
2022-09-23 18:08 ` Long Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).