* [PATCH] i2c: s3c2410: Delete unneeded variable: "ret"
@ 2021-09-16 10:37 Xiang wangx
2021-09-16 10:52 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Xiang wangx @ 2021-09-16 10:37 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: linux-i2c, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Xiang wangx
variable: "ret" defined but not used in function "i2c_s3c_irq_nextbyte"
Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index b49a1b170bb2..6df85b23156c 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -385,7 +385,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
{
unsigned long tmp;
unsigned char byte;
- int ret = 0;
switch (i2c->state) {
@@ -548,7 +547,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
tmp &= ~S3C2410_IICCON_IRQPEND;
writel(tmp, i2c->regs + S3C2410_IICCON);
out:
- return ret;
+ return 0;
}
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: s3c2410: Delete unneeded variable: "ret"
2021-09-16 10:37 [PATCH] i2c: s3c2410: Delete unneeded variable: "ret" Xiang wangx
@ 2021-09-16 10:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-16 10:52 UTC (permalink / raw)
To: Xiang wangx; +Cc: linux-i2c, linux-arm-kernel, linux-samsung-soc, linux-kernel
On 16/09/2021 12:37, Xiang wangx wrote:
> variable: "ret" defined but not used in function "i2c_s3c_irq_nextbyte"
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index b49a1b170bb2..6df85b23156c 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -385,7 +385,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
> {
> unsigned long tmp;
> unsigned char byte;
> - int ret = 0;
>
> switch (i2c->state) {
>
> @@ -548,7 +547,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
> tmp &= ~S3C2410_IICCON_IRQPEND;
> writel(tmp, i2c->regs + S3C2410_IICCON);
> out:
> - return ret;
> + return 0;
Change is okay but I would go step further - made the function return
void(). None of the callers check for return so no functionality is lost.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-16 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 10:37 [PATCH] i2c: s3c2410: Delete unneeded variable: "ret" Xiang wangx
2021-09-16 10:52 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).