* [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing
@ 2020-05-12 12:24 Geert Uytterhoeven
2020-05-12 12:26 ` Bartosz Golaszewski
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-05-12 12:24 UTC (permalink / raw)
To: Bartosz Golaszewski, Rob Herring
Cc: linux-i2c, devicetree, Geert Uytterhoeven
"258" is an odd power-of-two ;-)
Obviously this is a typo, and the intended value is "256".
Fixes: 7f3bf4203774013b ("dt-bindings: at24: convert the binding document to yaml")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/eeprom/at24.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index d77bc475fd148d99..4cee72d5331877a8 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -124,7 +124,7 @@ properties:
may result in data loss! If not specified, a safety value of
'1' is used which will be very slow.
$ref: /schemas/types.yaml#/definitions/uint32
- enum: [1, 8, 16, 32, 64, 128, 258]
+ enum: [1, 8, 16, 32, 64, 128, 256]
default: 1
read-only:
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing
2020-05-12 12:24 [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing Geert Uytterhoeven
@ 2020-05-12 12:26 ` Bartosz Golaszewski
2020-05-12 12:56 ` Wolfram Sang
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Bartosz Golaszewski @ 2020-05-12 12:26 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Rob Herring, linux-i2c, linux-devicetree
wt., 12 maj 2020 o 14:24 Geert Uytterhoeven <geert+renesas@glider.be>
napisał(a):
>
> "258" is an odd power-of-two ;-)
> Obviously this is a typo, and the intended value is "256".
>
> Fixes: 7f3bf4203774013b ("dt-bindings: at24: convert the binding document to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index d77bc475fd148d99..4cee72d5331877a8 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -124,7 +124,7 @@ properties:
> may result in data loss! If not specified, a safety value of
> '1' is used which will be very slow.
> $ref: /schemas/types.yaml#/definitions/uint32
> - enum: [1, 8, 16, 32, 64, 128, 258]
> + enum: [1, 8, 16, 32, 64, 128, 256]
> default: 1
>
> read-only:
> --
> 2.17.1
>
Ha! Of course it is. :)
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing
2020-05-12 12:24 [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing Geert Uytterhoeven
2020-05-12 12:26 ` Bartosz Golaszewski
@ 2020-05-12 12:56 ` Wolfram Sang
2020-05-15 9:27 ` Wolfram Sang
2020-05-19 18:52 ` Rob Herring
3 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-05-12 12:56 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bartosz Golaszewski, Rob Herring, linux-i2c, devicetree
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
On Tue, May 12, 2020 at 02:24:47PM +0200, Geert Uytterhoeven wrote:
> "258" is an odd power-of-two ;-)
Geez, you got two additional for free, Geert ;)
> Obviously this is a typo, and the intended value is "256".
Obviously.
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing
2020-05-12 12:24 [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing Geert Uytterhoeven
2020-05-12 12:26 ` Bartosz Golaszewski
2020-05-12 12:56 ` Wolfram Sang
@ 2020-05-15 9:27 ` Wolfram Sang
2020-05-15 9:36 ` Wolfram Sang
2020-05-19 18:52 ` Rob Herring
3 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2020-05-15 9:27 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bartosz Golaszewski, Rob Herring, linux-i2c, devicetree
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
On Tue, May 12, 2020 at 02:24:47PM +0200, Geert Uytterhoeven wrote:
> "258" is an odd power-of-two ;-)
> Obviously this is a typo, and the intended value is "256".
>
> Fixes: 7f3bf4203774013b ("dt-bindings: at24: convert the binding document to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Since I have a PR for Linus pending anyhow, I step ahead and apply it to
my tree. Hope this is fine for everyone. Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing
2020-05-15 9:27 ` Wolfram Sang
@ 2020-05-15 9:36 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-05-15 9:36 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bartosz Golaszewski, Rob Herring, linux-i2c, devicetree
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Fri, May 15, 2020 at 11:27:55AM +0200, Wolfram Sang wrote:
> On Tue, May 12, 2020 at 02:24:47PM +0200, Geert Uytterhoeven wrote:
> > "258" is an odd power-of-two ;-)
> > Obviously this is a typo, and the intended value is "256".
> >
> > Fixes: 7f3bf4203774013b ("dt-bindings: at24: convert the binding document to yaml")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Since I have a PR for Linus pending anyhow, I step ahead and apply it to
> my tree. Hope this is fine for everyone. Applied to for-current, thanks!
Brown paper bag, please. This is in -next only, so I rather leave it for
Rob because of the dependencies.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing
2020-05-12 12:24 [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing Geert Uytterhoeven
` (2 preceding siblings ...)
2020-05-15 9:27 ` Wolfram Sang
@ 2020-05-19 18:52 ` Rob Herring
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-05-19 18:52 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, linux-i2c, Bartosz Golaszewski, devicetree
On Tue, 12 May 2020 14:24:47 +0200, Geert Uytterhoeven wrote:
> "258" is an odd power-of-two ;-)
> Obviously this is a typo, and the intended value is "256".
>
> Fixes: 7f3bf4203774013b ("dt-bindings: at24: convert the binding document to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-19 18:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 12:24 [PATCH] dt-bindings: eeprom: at24: Fix list of page sizes for writing Geert Uytterhoeven
2020-05-12 12:26 ` Bartosz Golaszewski
2020-05-12 12:56 ` Wolfram Sang
2020-05-15 9:27 ` Wolfram Sang
2020-05-15 9:36 ` Wolfram Sang
2020-05-19 18:52 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).