* [PATCH v1] i2c: cadence: Add an error handling for platform_get_irq()
@ 2020-05-19 14:43 Dejin Zheng
0 siblings, 0 replies; only message in thread
From: Dejin Zheng @ 2020-05-19 14:43 UTC (permalink / raw)
To: wsa, michal.simek, linux-i2c; +Cc: linux-kernel, Dejin Zheng
The driver initialization should be end immediately after found
the platform_get_irq() function return an error.
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
drivers/i2c/busses/i2c-cadence.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index 89d58f7d2a25..0e8debe32cea 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -912,6 +912,8 @@ static int cdns_i2c_probe(struct platform_device *pdev)
return PTR_ERR(id->membase);
id->irq = platform_get_irq(pdev, 0);
+ if (id->irq < 0)
+ return id->irq;
id->adap.owner = THIS_MODULE;
id->adap.dev.of_node = pdev->dev.of_node;
--
2.25.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-19 14:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 14:43 [PATCH v1] i2c: cadence: Add an error handling for platform_get_irq() Dejin Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).