* [PATCH] i2c: i801: Exclude device from suspend direct complete optimization
@ 2020-09-10 9:57 Jean Delvare
2020-09-21 9:30 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2020-09-10 9:57 UTC (permalink / raw)
To: Linux I2C; +Cc: Volker Rümelin, Bjorn Helgaas, Vaibhav Gupta, Wolfram Sang
By default, PCI drivers with runtime PM enabled will skip the calls
to suspend and resume on system PM. For this driver, we don't want
that, as we need to perform additional steps for system PM to work
properly on all systems. So instruct the PM core to not skip these
calls.
Fixes: a9c8088c7988 ("i2c: i801: Don't restore config registers on runtime PM")
Reported-by: Volker Rümelin <volker.ruemelin@googlemail.com>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org
---
drivers/i2c/busses/i2c-i801.c | 1 +
1 file changed, 1 insertion(+)
--- linux-5.8.orig/drivers/i2c/busses/i2c-i801.c 2020-09-09 18:41:55.118961045 +0200
+++ linux-5.8/drivers/i2c/busses/i2c-i801.c 2020-09-10 11:36:40.352858458 +0200
@@ -1917,6 +1917,7 @@ static int i801_probe(struct pci_dev *de
pci_set_drvdata(dev, priv);
+ dev_pm_set_driver_flags(&dev->dev, DPM_FLAG_NO_DIRECT_COMPLETE);
pm_runtime_set_autosuspend_delay(&dev->dev, 1000);
pm_runtime_use_autosuspend(&dev->dev);
pm_runtime_put_autosuspend(&dev->dev);
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: i801: Exclude device from suspend direct complete optimization
2020-09-10 9:57 [PATCH] i2c: i801: Exclude device from suspend direct complete optimization Jean Delvare
@ 2020-09-21 9:30 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2020-09-21 9:30 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux I2C, Volker Rümelin, Bjorn Helgaas, Vaibhav Gupta
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Thu, Sep 10, 2020 at 11:57:08AM +0200, Jean Delvare wrote:
> By default, PCI drivers with runtime PM enabled will skip the calls
> to suspend and resume on system PM. For this driver, we don't want
> that, as we need to perform additional steps for system PM to work
> properly on all systems. So instruct the PM core to not skip these
> calls.
>
> Fixes: a9c8088c7988 ("i2c: i801: Don't restore config registers on runtime PM")
> Reported-by: Volker Rümelin <volker.ruemelin@googlemail.com>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: stable@vger.kernel.org
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-21 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 9:57 [PATCH] i2c: i801: Exclude device from suspend direct complete optimization Jean Delvare
2020-09-21 9:30 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).