linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] v3u: enable I2C0-6
@ 2020-12-23 17:24 Wolfram Sang
  2020-12-23 17:25 ` [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support Wolfram Sang
  0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2020-12-23 17:24 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, devicetree, linux-clk, linux-i2c, linux-kernel

These patches are needed to enable I2C on the Falcon board for the V3U.
Patch #5 is only for demonstration purposes. The series depends on my
RWDT series, Ulrich's PFC v2 series and Geert's DMA placeholder. A
branch can be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/v3u/i2c

There is also a series in-flight to handle spurious interrupts on the
V3U. Because I have never seen one, I wouldn't call it a dependency, so
the series is handled seperately.

Looking forward to comments...


Koji Matsuoka (2):
  arm64: dts: renesas: Add I2C to R8A779A0
  arm64: dts: renesas: Add I2C support for falcon board

Wolfram Sang (3):
  dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support
  clk: renesas: r8a779a0: add clocks for I2C
  v3u: enable other I2C busses for testing

 .../devicetree/bindings/i2c/renesas,i2c.txt   |   1 +
 .../boot/dts/renesas/r8a779a0-falcon.dts      |  93 +++++++++++++
 arch/arm64/boot/dts/renesas/r8a779a0.dtsi     | 122 ++++++++++++++++++
 drivers/clk/renesas/r8a779a0-cpg-mssr.c       |   7 +
 4 files changed, 223 insertions(+)

-- 
2.28.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support
  2020-12-23 17:24 [PATCH 0/5] v3u: enable I2C0-6 Wolfram Sang
@ 2020-12-23 17:25 ` Wolfram Sang
  2021-01-05 12:30   ` Geert Uytterhoeven
                     ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-12-23 17:25 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Rob Herring, linux-i2c, devicetree, linux-kernel

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 Documentation/devicetree/bindings/i2c/renesas,i2c.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/renesas,i2c.txt b/Documentation/devicetree/bindings/i2c/renesas,i2c.txt
index 96d869ac3839..5762d2d1ab9c 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,i2c.txt
+++ b/Documentation/devicetree/bindings/i2c/renesas,i2c.txt
@@ -26,6 +26,7 @@ Required properties:
 	"renesas,i2c-r8a77980" if the device is a part of a R8A77980 SoC.
 	"renesas,i2c-r8a77990" if the device is a part of a R8A77990 SoC.
 	"renesas,i2c-r8a77995" if the device is a part of a R8A77995 SoC.
+	"renesas,i2c-r8a779a0" if the device is a part of a R8A779A0 SoC.
 	"renesas,rcar-gen1-i2c" for a generic R-Car Gen1 compatible device.
 	"renesas,rcar-gen2-i2c" for a generic R-Car Gen2 or RZ/G1 compatible
 				device.
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support
  2020-12-23 17:25 ` [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support Wolfram Sang
@ 2021-01-05 12:30   ` Geert Uytterhoeven
  2021-01-17 11:44     ` Wolfram Sang
  2021-01-08  2:38   ` Rob Herring
  2021-01-17 11:34   ` Wolfram Sang
  2 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-01-05 12:30 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Linux-Renesas, Rob Herring, Linux I2C,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List

On Wed, Dec 23, 2020 at 6:27 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/Documentation/devicetree/bindings/i2c/renesas,i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/renesas,i2c.txt
> @@ -26,6 +26,7 @@ Required properties:
>         "renesas,i2c-r8a77980" if the device is a part of a R8A77980 SoC.
>         "renesas,i2c-r8a77990" if the device is a part of a R8A77990 SoC.
>         "renesas,i2c-r8a77995" if the device is a part of a R8A77995 SoC.
> +       "renesas,i2c-r8a779a0" if the device is a part of a R8A779A0 SoC.
>         "renesas,rcar-gen1-i2c" for a generic R-Car Gen1 compatible device.
>         "renesas,rcar-gen2-i2c" for a generic R-Car Gen2 or RZ/G1 compatible
>                                 device.

Note that this doesn't say anything about (in)compatibility with generic
R-Car Gen3 compatible devices (hint: yaml conversion?).

New features:
  - Slave Clock Stretch Select,
  - Fast Mode+ Enable,
  - Enhanced First Bit Setup Cycle configuration.

Looks like the R-Car V3U variant can be treated as a generic R-Car Gen3
variant (lacking the new features, of course).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support
  2020-12-23 17:25 ` [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support Wolfram Sang
  2021-01-05 12:30   ` Geert Uytterhoeven
@ 2021-01-08  2:38   ` Rob Herring
  2021-01-17 11:34   ` Wolfram Sang
  2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-01-08  2:38 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-kernel, devicetree, Rob Herring, linux-renesas-soc, linux-i2c

On Wed, 23 Dec 2020 18:25:00 +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  Documentation/devicetree/bindings/i2c/renesas,i2c.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support
  2020-12-23 17:25 ` [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support Wolfram Sang
  2021-01-05 12:30   ` Geert Uytterhoeven
  2021-01-08  2:38   ` Rob Herring
@ 2021-01-17 11:34   ` Wolfram Sang
  2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2021-01-17 11:34 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Rob Herring, linux-i2c, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

On Wed, Dec 23, 2020 at 06:25:00PM +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support
  2021-01-05 12:30   ` Geert Uytterhoeven
@ 2021-01-17 11:44     ` Wolfram Sang
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2021-01-17 11:44 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linux-Renesas, Rob Herring, Linux I2C,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]


> New features:
>   - Slave Clock Stretch Select,
>   - Fast Mode+ Enable,
>   - Enhanced First Bit Setup Cycle configuration.
> 
> Looks like the R-Car V3U variant can be treated as a generic R-Car Gen3
> variant (lacking the new features, of course).

FM+ doesn't need an update. It will just handle higher values for the
bus frequency. This is also the most likely one to be supported in
Linux. First Bit setup is not even supported yet in the basic version.
Configuration via Linux is unclear same as SlaveClockStretch. Use cases
are unclear, too, which we would need for implementating any of this.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-17 11:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 17:24 [PATCH 0/5] v3u: enable I2C0-6 Wolfram Sang
2020-12-23 17:25 ` [PATCH 1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support Wolfram Sang
2021-01-05 12:30   ` Geert Uytterhoeven
2021-01-17 11:44     ` Wolfram Sang
2021-01-08  2:38   ` Rob Herring
2021-01-17 11:34   ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).