* [PATCH] i2c: mv64xxx: Fix check for missing clock
@ 2021-02-08 6:19 Samuel Holland
2021-02-09 10:42 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2021-02-08 6:19 UTC (permalink / raw)
To: Gregory CLEMENT, Wolfram Sang, linux-i2c
Cc: linux-kernel, Samuel Holland, Dan Carpenter
In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
pointers to optional clocks were replaced by NULL to simplify the resume
callback implementation. However, that commit missed that the IS_ERR
check in mv64xxx_of_config should be replaced with a NULL check. As a
result, the check always passes, even for an invalid device tree.
Fixes: e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
index b03c344323d1..c590d36b5fd1 100644
--- a/drivers/i2c/busses/i2c-mv64xxx.c
+++ b/drivers/i2c/busses/i2c-mv64xxx.c
@@ -813,7 +813,7 @@ mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data,
* need to know tclk in order to calculate bus clock
* factors.
*/
- if (IS_ERR(drv_data->clk)) {
+ if (!drv_data->clk) {
rc = -ENODEV;
goto out;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: mv64xxx: Fix check for missing clock
2021-02-08 6:19 [PATCH] i2c: mv64xxx: Fix check for missing clock Samuel Holland
@ 2021-02-09 10:42 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2021-02-09 10:42 UTC (permalink / raw)
To: Samuel Holland; +Cc: Gregory CLEMENT, linux-i2c, linux-kernel, Dan Carpenter
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Mon, Feb 08, 2021 at 12:19:22AM -0600, Samuel Holland wrote:
> In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
> pointers to optional clocks were replaced by NULL to simplify the resume
> callback implementation. However, that commit missed that the IS_ERR
> check in mv64xxx_of_config should be replaced with a NULL check. As a
> result, the check always passes, even for an invalid device tree.
>
> Fixes: e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Added "RPM" to $subject and applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-09 10:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 6:19 [PATCH] i2c: mv64xxx: Fix check for missing clock Samuel Holland
2021-02-09 10:42 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).