From: Wolfram Sang <wsa@the-dreams.de>
To: Ulrich Hecht <uli@fpond.eu>
Cc: Ulrich Hecht <uli+renesas@fpond.eu>,
linux-renesas-soc@vger.kernel.org, geert@linux-m68k.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: rcar: implement atomic transfers
Date: Fri, 19 Feb 2021 13:01:42 +0100 [thread overview]
Message-ID: <20210219120142.GA32306@ninjato> (raw)
In-Reply-To: <1817984199.148366.1613664221431@webmail.strato.com>
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
On Thu, Feb 18, 2021 at 05:03:41PM +0100, Ulrich Hecht wrote:
>
> > On 02/18/2021 11:49 AM Wolfram Sang <wsa@the-dreams.de> wrote:
> > > Implements atomic transfers. Tested by rebooting an r8a7790 Lager board
> > > after connecting the i2c-rcar controller to the PMIC in
> > > arch/arm/boot/dts/r8a7790-lager.dts like so:
> > >
> > > compatible = "i2c-demux-pinctrl";
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pmic_irq_pins>;
> > > - i2c-parent = <&iic3>, <&i2c3>;
> > > + i2c-parent = <&i2c3>, <&iic3>;
> > > i2c-bus-name = "i2c-pwr";
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > >
> > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
> >
> > Doesn't apply against 5.11 or i2c/for-next. What is the base here?
>
> renesas-drivers-2021-02-09-v5.11-rc7
Ok, now it applies, good. Testing went also fine, works nicely.
From a maintaining perspective, I think, though, we should have only one
master_xfer() function and use 'atomic_xfer' in there to skip stuff etc.
Otherwise fixes in one function might be forgotten in the other one. Or?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-02-19 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 16:45 [PATCH] i2c: rcar: implement atomic transfers Ulrich Hecht
2021-02-18 10:49 ` Wolfram Sang
2021-02-18 16:03 ` Ulrich Hecht
2021-02-19 12:01 ` Wolfram Sang [this message]
2021-02-22 9:13 ` Ulrich Hecht
2021-02-25 9:50 ` Geert Uytterhoeven
2021-03-18 10:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219120142.GA32306@ninjato \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=uli+renesas@fpond.eu \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).