linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ulrich Hecht <uli+renesas@fpond.eu>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: rcar: implement atomic transfers
Date: Thu, 25 Feb 2021 10:50:58 +0100	[thread overview]
Message-ID: <CAMuHMdVsAgOrf2=4Fud6SWy6T98F5aFvD5aGdiu646=7bLbUZw@mail.gmail.com> (raw)
In-Reply-To: <20210212164541.8986-1-uli+renesas@fpond.eu>

On Fri, Feb 12, 2021 at 5:45 PM Ulrich Hecht <uli+renesas@fpond.eu> wrote:
> Implements atomic transfers. Tested by rebooting an r8a7790 Lager board
> after connecting the i2c-rcar controller to the PMIC in
> arch/arm/boot/dts/r8a7790-lager.dts like so:
>
>                 compatible = "i2c-demux-pinctrl";
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pmic_irq_pins>;
> -               i2c-parent = <&iic3>, <&i2c3>;
> +               i2c-parent = <&i2c3>, <&iic3>;
>                 i2c-bus-name = "i2c-pwr";
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>

LGTM (IANIE = ... No I2C Expert), so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2021-02-25  9:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 16:45 [PATCH] i2c: rcar: implement atomic transfers Ulrich Hecht
2021-02-18 10:49 ` Wolfram Sang
2021-02-18 16:03   ` Ulrich Hecht
2021-02-19 12:01     ` Wolfram Sang
2021-02-22  9:13       ` Ulrich Hecht
2021-02-25  9:50 ` Geert Uytterhoeven [this message]
2021-03-18 10:59 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVsAgOrf2=4Fud6SWy6T98F5aFvD5aGdiu646=7bLbUZw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=uli+renesas@fpond.eu \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).