* [PATCH] i2c: imx: Use devm_request_irq()
@ 2021-03-19 9:33 Tian Tao
2021-03-19 9:40 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-03-19 9:33 UTC (permalink / raw)
To: linux, shawnguo, s.hauer, sumit.semwal, christian.koenig; +Cc: linux-i2c
Use devm_request_irq() to get rid of manual unregistration.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/i2c/busses/i2c-imx.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index b80fdc1..e377d4a 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1435,8 +1435,8 @@ static int i2c_imx_probe(struct platform_device *pdev)
goto rpm_disable;
/* Request IRQ */
- ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED,
- pdev->name, i2c_imx);
+ ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr,
+ IRQF_SHARED, pdev->name, i2c_imx);
if (ret) {
dev_err(&pdev->dev, "can't claim irq %d\n", irq);
goto rpm_disable;
@@ -1481,7 +1481,6 @@ static int i2c_imx_probe(struct platform_device *pdev)
clk_notifier_unregister:
clk_notifier_unregister(i2c_imx->clk, &i2c_imx->clk_change_nb);
- free_irq(irq, i2c_imx);
rpm_disable:
pm_runtime_put_noidle(&pdev->dev);
pm_runtime_disable(&pdev->dev);
@@ -1494,7 +1493,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
static int i2c_imx_remove(struct platform_device *pdev)
{
struct imx_i2c_struct *i2c_imx = platform_get_drvdata(pdev);
- int irq, ret;
+ int ret;
ret = pm_runtime_get_sync(&pdev->dev);
if (ret < 0)
@@ -1514,9 +1513,6 @@ static int i2c_imx_remove(struct platform_device *pdev)
imx_i2c_write_reg(0, i2c_imx, IMX_I2C_I2SR);
clk_notifier_unregister(i2c_imx->clk, &i2c_imx->clk_change_nb);
- irq = platform_get_irq(pdev, 0);
- if (irq >= 0)
- free_irq(irq, i2c_imx);
clk_disable_unprepare(i2c_imx->clk);
pm_runtime_put_noidle(&pdev->dev);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: imx: Use devm_request_irq()
2021-03-19 9:33 [PATCH] i2c: imx: Use devm_request_irq() Tian Tao
@ 2021-03-19 9:40 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2021-03-19 9:40 UTC (permalink / raw)
To: Tian Tao
Cc: linux, shawnguo, s.hauer, sumit.semwal, christian.koenig, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On Fri, Mar 19, 2021 at 05:33:40PM +0800, Tian Tao wrote:
> Use devm_request_irq() to get rid of manual unregistration.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Please don't send such patches unless you have a deep understanding of
the hardware. devm and interrupts are a dangerous combination because
you can get interrupts when the driver is gone already ( == OOPS) if you
don't pay close attention.
For this reason, I won't take janitorial patches with regard to devm and
interrupts.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-19 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 9:33 [PATCH] i2c: imx: Use devm_request_irq() Tian Tao
2021-03-19 9:40 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).