* [PATCH -next] i2c: designware: Fix return value check in navi_amd_register_client()
@ 2021-04-07 1:52 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2021-04-07 1:52 UTC (permalink / raw)
To: weiyongjun1, Sanket Goswami, Jarkko Nikula
Cc: linux-i2c, kernel-janitors, Hulk Robot
In case of error, the function i2c_new_client_device() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index 7ca0017883a6..0f409a4c2da0 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -132,8 +132,8 @@ static int navi_amd_register_client(struct dw_i2c_dev *dev)
info.irq = dev->irq;
dev->slave = i2c_new_client_device(&dev->adapter, &info);
- if (!dev->slave)
- return -ENODEV;
+ if (IS_ERR(dev->slave))
+ return PTR_ERR(dev->slave);
return 0;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-07 1:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 1:52 [PATCH -next] i2c: designware: Fix return value check in navi_amd_register_client() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).