From: Wolfram Sang <wsa@kernel.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] i2c: mpc: Interrupt driven transfer
Date: Mon, 12 Apr 2021 20:17:42 +0200 [thread overview]
Message-ID: <20210412181742.GA3175@kunai> (raw)
In-Reply-To: <723acaa7-ff57-40c2-a733-a520c5899800@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]
Hi Chris,
> Yep I plan on being around. I've got access to a couple of designs with
> P2040 and T2081 so hopefully that's sufficient to deal with any
> regressions. One issue is a lack of different i2c devices (the systems
> we have tend to use the same devices) but hopefully any reports of
> regression will be from people with access to such devices.
Sounds very good to me.
> > That kind of leads to the question if you want to
> > step up as the maintainer for this driver?
> Sure can do. It'd be nice if it was someone from NXP but I think they've
> lost interest in the PowerPC based SoCs. Should I send a patch for
> MAINTAINERS? If so does that go through the i2c tree?
Yes, please send a patch and I will merge it via I2C. I don't have hope
for someone from NXP because it was difficult enough to get maintainers
for the actively sold SoCs.
> > Only thing I noticed was a "BUG" and "BUG_ON" and wonder if we really
> > need to halt the kernel in that case. Maybe WARN is enough?
>
> Yeah I think they can both be WARN variants. The one in mpc_xfer() can
> happily continue. It's a little less clear what I should do in
> mpc_i2c_do_action() if the WARN is ever hit but in theory it should be
> an unreachable case anyway so the only thing that could get there is
> some kind of memory corruption which would likely cause a crash elsewhere.
Yeah, please change to WARN.
> Do you want me to send a V3 of just that patch?
Yes, plus the MAINTAINERS patch, please.
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-12 18:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 1:52 [PATCH v2 0/6] i2c: mpc: Refactor to improve responsiveness Chris Packham
2021-03-29 1:52 ` [PATCH v2 1/6] dt-bindings: i2c-mpc: Document interrupt property as required Chris Packham
2021-03-30 15:13 ` Rob Herring
2021-03-29 1:52 ` [PATCH v2 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema Chris Packham
2021-03-30 15:18 ` Rob Herring
2021-03-29 1:52 ` [PATCH v2 3/6] i2c: mpc: Make use of i2c_recover_bus() Chris Packham
2021-03-29 1:52 ` [PATCH v2 4/6] i2c: mpc: make interrupt mandatory and remove polling code Chris Packham
2021-04-10 20:16 ` Wolfram Sang
2021-04-11 23:57 ` Chris Packham
2021-03-29 1:52 ` [PATCH v2 5/6] i2c: mpc: use device managed APIs Chris Packham
2021-04-12 22:52 ` Andy Shevchenko
2021-04-12 22:55 ` Andy Shevchenko
2021-04-12 23:21 ` Chris Packham
2021-04-12 23:26 ` Chris Packham
2021-04-12 23:34 ` Andy Shevchenko
2021-03-29 1:52 ` [PATCH v2 6/6] i2c: mpc: Interrupt driven transfer Chris Packham
2021-04-10 20:13 ` Wolfram Sang
2021-04-11 21:31 ` Chris Packham
2021-04-12 18:17 ` Wolfram Sang [this message]
2021-04-12 22:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412181742.GA3175@kunai \
--to=wsa@kernel.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).