* [PATCH] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work
@ 2023-05-29 7:23 carlos.song
2023-06-13 23:39 ` Andi Shyti
0 siblings, 1 reply; 3+ messages in thread
From: carlos.song @ 2023-05-29 7:23 UTC (permalink / raw)
To: aisheng.dong, shawnguo, s.hauer, kernel, festevam
Cc: carlos.song, xiaoning.wang, haibo.chen, linux-imx, linux-i2c,
linux-arm-kernel, linux-kernel
From: Gao Pan <pandy.gao@nxp.com>
Add debug message when i2c peripheral clk rate is 0, then
directly return -EINVAL.
Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Signed-off-by: Carlos Song <carlos.song@nxp.com>
---
drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index 11240bf8e8e2..62111fe9f207 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -209,6 +209,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
lpi2c_imx_set_mode(lpi2c_imx);
clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
+ if (!clk_rate) {
+ dev_dbg(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");
+ return -EINVAL;
+ }
+
if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
filt = 0;
else
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work
2023-05-29 7:23 [PATCH] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work carlos.song
@ 2023-06-13 23:39 ` Andi Shyti
2023-07-24 10:19 ` [EXT] " Carlos Song
0 siblings, 1 reply; 3+ messages in thread
From: Andi Shyti @ 2023-06-13 23:39 UTC (permalink / raw)
To: carlos.song
Cc: aisheng.dong, shawnguo, s.hauer, kernel, festevam, xiaoning.wang,
haibo.chen, linux-imx, linux-i2c, linux-arm-kernel, linux-kernel
Hi,
On Mon, May 29, 2023 at 03:23:16PM +0800, carlos.song@nxp.com wrote:
> From: Gao Pan <pandy.gao@nxp.com>
>
> Add debug message when i2c peripheral clk rate is 0, then
> directly return -EINVAL.
>
> Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
> Signed-off-by: Gao Pan <pandy.gao@nxp.com>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> ---
> drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
> index 11240bf8e8e2..62111fe9f207 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -209,6 +209,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
> lpi2c_imx_set_mode(lpi2c_imx);
>
> clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
> + if (!clk_rate) {
> + dev_dbg(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");
> + return -EINVAL;
> + }
should this rather be a dev_err?
And, BTW, did you actually hit this?
Andi
> +
> if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
> filt = 0;
> else
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] Re: [PATCH] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work
2023-06-13 23:39 ` Andi Shyti
@ 2023-07-24 10:19 ` Carlos Song
0 siblings, 0 replies; 3+ messages in thread
From: Carlos Song @ 2023-07-24 10:19 UTC (permalink / raw)
To: Andi Shyti
Cc: Aisheng Dong, shawnguo, s.hauer, kernel, festevam, Clark Wang,
Bough Chen, dl-linux-imx, linux-i2c, linux-arm-kernel,
linux-kernel
Hi, Andi
> -----Original Message-----
> From: Andi Shyti <andi.shyti@kernel.org>
> Sent: Wednesday, June 14, 2023 7:40 AM
> To: Carlos Song <carlos.song@nxp.com>
> Cc: Aisheng Dong <aisheng.dong@nxp.com>; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; Clark
> Wang <xiaoning.wang@nxp.com>; Bough Chen <haibo.chen@nxp.com>;
> dl-linux-imx <linux-imx@nxp.com>; linux-i2c@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH] i2c: imx-lpi2c: add debug message when i2c
> peripheral clk doesn't work
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
>
>
> Hi,
>
> On Mon, May 29, 2023 at 03:23:16PM +0800, carlos.song@nxp.com wrote:
> > From: Gao Pan <pandy.gao@nxp.com>
> >
> > Add debug message when i2c peripheral clk rate is 0, then directly
> > return -EINVAL.
> >
> > Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
> > Signed-off-by: Gao Pan <pandy.gao@nxp.com>
> > Signed-off-by: Carlos Song <carlos.song@nxp.com>
> > ---
> > drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c
> > b/drivers/i2c/busses/i2c-imx-lpi2c.c
> > index 11240bf8e8e2..62111fe9f207 100644
> > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> > @@ -209,6 +209,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct
> *lpi2c_imx)
> > lpi2c_imx_set_mode(lpi2c_imx);
> >
> > clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
> > + if (!clk_rate) {
> > + dev_dbg(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");
> > + return -EINVAL;
> > + }
>
> should this rather be a dev_err?
>
Carlos: Yes, I will fix it.
> And, BTW, did you actually hit this?
>
Carlos: No, not frequently. But I think it will be safer maybe.
> Andi
>
> > +
> > if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
> > filt = 0;
> > else
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-24 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-29 7:23 [PATCH] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work carlos.song
2023-06-13 23:39 ` Andi Shyti
2023-07-24 10:19 ` [EXT] " Carlos Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).